Re: [PATCH v2 06/10] net: pcs: xpcs: add ANRESTART support for SGMII link recovery

From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>, Coia Prant <coiaprant@gmail.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>, Vinod Koul <vkoul@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Romain Gantois <romain.gantois@bootlin.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Russell King <linux@armlinux.org.uk>,
	Shawn Lin <shawn.lin@rock-chips.com>,
	David Heidelberg <david@ixit.cz>,
	netdev@vger.kernel.org, linux-rockchip@lists.infradead.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-renesas-soc@vger.kernel.org,
	Jiawen Wu <jiawenwu@trustnetic.com>
Subject: Re: [PATCH v2 06/10] net: pcs: xpcs: add ANRESTART support for SGMII link recovery
Date: Sun, 2 Aug 2026 16:59:28 +0200	[thread overview]
Message-ID: <82df688c-80c7-4536-afd8-1332005b0736@bootlin.com> (raw)
In-Reply-To: <2886b24e-1c3d-48f7-8b22-9620fa0404f7@lunn.ch>

Hi,

On 8/2/26 16:30, Andrew Lunn wrote:
> On Sun, Aug 02, 2026 at 11:11:40AM +0800, Coia Prant wrote:
>> Hi Andrew,
>>
>> Thanks for the careful review.
>>
>>> This probably needs more wide spread testing. I would be afraid that
>>> if you kick off an AN cycle, you loose the link until it completes?
>>> You would of noticed that on your hardware, but other hardware
>>> obviously behaves differently...
>>
>> The trigger condition is: link is down AND an_complete is set.
> 
> Ah, i missed the "link is down" check. That makes it safer.
> 
> I still find it interesting that this devices is different. Has the
> silicon vendor done the integration of the licensed IP wrong?
> 
>> Regarding testing:
>> - Jiawen Wu has tested this on Wangxun NICs and reported no regression
>>   (Tested-by tag included in the patch).
> 
> Probably Maxime will test on the platform he has, but i don't know if
> any use the XPCS.

Indeed :( The only XPCS HW I have right now is the ksz9477 switch, and it
uses an old version of the IP with its own quirks.

I'll test it indeed, but I've yet to find some affordable HW with an XPCS
and that I can easily source :(

Maxime

> 
> 	Andrew

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy