From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F52AC61DC4 for ; Thu, 27 Aug 2026 23:14:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4cyxMK5WJ3iDPibzwxU1GwI23KHEug36QlKQAMzyuTA=; b=KdwJCyb2mQEx6E /HjbL16eHiCrzEjK41I0ySGjKxrpeynD9/FX7V/vDLtor6JDuTdN6rNF8stumwBiDULM3SNBHE5mc idpT9S5z2yScAuz6+/lItlrQJLwO+jIAfVwwukBNR46WpyDNV0kyDMCEwDtjBc9xwyKP8jo6BxhsF 1K/WlUpMQnmRcT5m3/pr4B0VB4cPHVq8FX8+55EGnMWSc80YrCbPuTVcYpv5U2nKuiDy90ykDR6tk dAZ53Y2zQLTo+dzZHy7gA0HE/x4nvg9NRljlLSnO34PqVlWDNKiGX1rzue2LcXRR4u3MztJOfy1i6 B1is+04eYh5x0LIQc5Ew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzjIl-00000004tID-1aWk; Thu, 27 Aug 2026 23:14:31 +0000 Received: from mx.nabladev.com ([2a00:f820:417:0:178:251:229:89]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wzjIi-00000004tHg-2bc3; Thu, 27 Aug 2026 23:14:30 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C1AA711C5D3; Fri, 28 Aug 2026 01:14:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1787872460; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=gjJ6weS85s22FsCPd+HQktbWCP2SfOGkFBLAdeRpKpo=; b=i7CL2o6SLSrZdwX0d5+AsU2vabHXYQ1NNmnV/xx2ISa23sMUmdIGRb53cNIhJNGVbZsTdx WAdF9ERf6Uf1CaoM097RPCbumDaf+d475mXRefKf7E7+X43sCbomSMuwll7k0fkXQffzdB SBs+jMee+mA+bafgxAFrGyRltI7WCGMsa1gPCTxJpGarj6jWNq8H4dKdfA97nEK9HNF9m6 +eoWKLE7AVgdSFiIdQW8feBK8viOr+0M1k4N8Bivc0VUQEMLpewdXAcly+bg2aBeCZgbl9 h8RkaXiO6LcP9y7SaIxMYoqAi+28TMwMG5q2J5j9uzvv/EIWpD+n0M2ipwuSbA== Message-ID: <84bd4b0b-69c3-451e-9e0b-690191f52537@nabladev.com> Date: Fri, 28 Aug 2026 01:14:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/9] dt-bindings: phy: Document ST STM32MP25 USB2-FEMTO PHY To: Krzysztof Kozlowski , linux-usb@vger.kernel.org Cc: fabrice.gasnier@foss.st.com, Pankaj Dev , Rahul Kumar , =?UTF-8?Q?Cl=C3=A9ment_Le_Goffic?= , Alexandre Torgue , Christian Bruel , Conor Dooley , Greg Kroah-Hartman , Krzysztof Kozlowski , Maxime Coquelin , Neil Armstrong , Rob Herring , Rosen Penev , Thinh Nguyen , Vinod Koul , devicetree@vger.kernel.org, kernel@dh-electronics.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com References: <20260822074816.548662-1-marex@nabladev.com> <20260822074816.548662-2-marex@nabladev.com> <7a16614a-bd1b-462a-be13-4a9c22aa588e@kernel.org> <34c48ff1-524f-4d24-b53f-99e7171d08db@nabladev.com> <25e10cfe-40dc-45f4-8a92-cd81263420ea@kernel.org> Content-Language: en-US From: Marek Vasut In-Reply-To: <25e10cfe-40dc-45f4-8a92-cd81263420ea@kernel.org> X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260827_161428_879577_CBCFF5A9 X-CRM114-Status: UNSURE ( 9.62 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 8/27/26 11:33 PM, Krzysztof Kozlowski wrote: > On 27/08/2026 16:53, Marek Vasut wrote: >> On 8/27/26 2:54 PM, Krzysztof Kozlowski wrote: >>> On 22/08/2026 09:46, Marek Vasut wrote: >>>> +description: >>>> + USB2 PHY block in STM32 is attached to USB 2.0 Host controller and >>>> + USB 2.0 side of DWC3 DRD controller, and provides the USB LS/FS/HS >>>> + connectivity. Both PHYs are the FEMTO-PHY, but their configuration >>>> + bits in the system control register are different for each variant. >>>> + >>>> +maintainers: >>>> + - Fabrice Gasnier >>>> + - Marek Vasut >>>> + - Pankaj Dev >>>> + >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - st,stm32mp25-usb2phy1 >>>> + - st,stm32mp25-usb2phy2 >>>> + >>>> + "#clock-cells": >>>> + const: 1 >>>> + >>> >>> As pointed out by different patchset built on top of it, this is wrong. >> >> What is wrong in this (V3) of the patchset ? I think the ST patches were >> fixing up V2 and what they were fixing up is already fixed here in V3. > > Probably I got confused... but I had impression the ST patches were > adding here "reg" property, no? It is there in V3: " + "#clock-cells": + const: 1 + + "#phy-cells": + const: 0 + + reg: <------------------ HERE + maxItems: 1 + + clocks: + maxItems: 1 + + resets: + maxItems: 1 " -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy