From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8EA0C44501 for ; Thu, 9 Jul 2026 13:00:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DiRXcNgnMQyR/Y6IdSP+QT+Ko2iu6rCK8eLdFK+TOOM=; b=C5iGGzboala+tf d7SD28tkBbupEdL7TQqN7tAYNBKdls/HcwtpDi0JhRyjOe5xlFlilIFxvjcKSTN/0QlBXb+kT4GdD KXiD7nsNPvRXUaGdQPXi9TNCNIZ99PlNcx8thoj9SZqfh+j3vQT+dCSfmmJ9M+qced6jTV5NpzNYX uLP/+xH+1ra6llL27ReDxZqwQTTVklWO/GXgTGGZBieusD7H8/mezGtl4bLFtLYnmi3AWMV+1pHSK Jlfs4ChwUAeSS/tsfKWs4cRaRrQfip/rZWodELSrAfG+vcsh44CFdl6Q1XgMRYyjYtKh/nwjraVtm USxrZ5txfBz+N4mDoYHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1whoMX-00000002UJ5-1Vc8; Thu, 09 Jul 2026 13:00:21 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1whoMW-00000002UIe-00aA for linux-phy@lists.infradead.org; Thu, 09 Jul 2026 13:00:20 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 25CBC601D9; Thu, 9 Jul 2026 13:00:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46BF11F000E9; Thu, 9 Jul 2026 13:00:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783602018; bh=cdGK6bbw7pzAK2kABSDnHKy3D6QQE++VD2qiKdt6Tf0=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=gJrJwx6h6mC3P6r3vk0uQcvGWk/r2FnziFWM68WR8WFpXa/L8AWvv36wiq8/c8fs0 yTIYZBy55yk3U0tk48iovTsyKFMTCcQYyAPJmqT3gkp6sEfoLtEuqtdAUZSvrK14d7 wRZoEMT0KTTbCSHwyJcRFr+RPmig1AtygWEazIBx3HRmA8yFQMFZ6z/BWZce0BDnCT wfVGizkrWakvS3D0JEz/Og8wEk7R+w6GIKnM9fLxaDCKzsZWab0GJkrPRPvZLM/wNm NBBxUsKMGk/yxh+7ErAubVDmbiHXiamiPgrJE6u2uajQKPStRf/pO+6CTv5I0Sqhbj nrcp8Vfg73V2A== From: Mattijs Korpershoek To: sashiko-reviews@lists.linux.dev Cc: olteanv@gmail.com, devicetree@vger.kernel.org, robh@kernel.org, linux-phy@lists.infradead.org, vkoul@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org Subject: Re: [PATCH 2/2] phy: qcom: qmp-usb: Add support for SA8255P In-Reply-To: <20260708131123.3F29B1F00A3A@smtp.kernel.org> References: <20260708-phy-qcom-qmp-usb-8255-v1-0-8d852a9535db@kernel.org> <20260708-phy-qcom-qmp-usb-8255-v1-2-8d852a9535db@kernel.org> <20260708131123.3F29B1F00A3A@smtp.kernel.org> Date: Thu, 09 Jul 2026 15:00:15 +0200 Message-ID: <87bjcgl3mo.fsf@kernel.org> MIME-Version: 1.0 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKdWwgMDgsIDIwMjYgYXQgMTM6MTEsIHNhc2hpa28tYm90QGtlcm5lbC5vcmcgd3Jv dGU6Cgo+IFRoYW5rIHlvdSBmb3IgeW91ciBjb250cmlidXRpb24hIFNhc2hpa28gQUkgcmV2aWV3 IGZvdW5kIDIgcG90ZW50aWFsIGlzc3VlKHMpIHRvIGNvbnNpZGVyOgo+IC0gW0hpZ2hdIFRoZSBk cml2ZXIgbGVha3MgcnVudGltZSBQTSB1c2FnZSBjb3VudGVycyBmb3IgaXRzIG1hbnVhbGx5IG1h bmFnZWQgcG93ZXIgZG9tYWlucyAoJ3VzYl90cmFuc2ZlcicgYW5kICd1c2JfY29yZScpIG9uIG11 bHRpcGxlIGVycm9yIHBhdGhzLCBsZWF2aW5nIGhhcmR3YXJlIHBlcm1hbmVudGx5IGFjdGl2ZSBh bmQgcmlza2luZyB1c2FnZSBjb3VudGVyIG92ZXJmbG93Lgo+IC0gW0hpZ2hdIFRlYXJkb3duIG9w ZXJhdGlvbnMgZGlzYWJsZSBQTSBkb21haW5zIGJlZm9yZSBkaXNhYmxpbmcgbGVhZiBjb25zdW1l ciBjbG9ja3MgYW5kIGFzc2VydGluZyByZXNldHMsIHZpb2xhdGluZyBzdHJpY3QgcmV2ZXJzZS1p bml0aWFsaXphdGlvbiBvcmRlcmluZyBhbmQgcmlza2luZyBoYXJkd2FyZSBhY2Nlc3MgZmF1bHRz Lgo+IC0tCj4KPiAtLS0gUGF0Y2ggWzJdOiBbUEFUQ0ggMi8yXSBwaHk6IHFjb206IHFtcC11c2I6 IEFkZCBzdXBwb3J0IGZvciBTQTgyNTVQIC0tLQo+IGNvbW1pdCA0ODc2NjdmZTNjMDc2YmJlMDg1 MWVlMTczOWE1ZDBmMjMxMTYzNGQ5Cj4gQXV0aG9yOiBTcmlyYW0gRGFzaCA8cXVpY19zcmlyYW1k QHF1aWNpbmMuY29tPgo+IFN1YmplY3Q6IHBoeTogcWNvbTogcW1wLXVzYjogQWRkIHN1cHBvcnQg Zm9yIFNBODI1NVAKPgo+IFRoaXMgY29tbWl0IGFkZHMgc3VwcG9ydCBmb3IgdGhlIFNBODI1NVAg U29DIHRvIHRoZSBRTVAgVVNCIFBIWSBkcml2ZXIuCj4gSXQgaW50cm9kdWNlcyBmaXJtd2FyZS1t YW5hZ2VkIHBvd2VyIGRvbWFpbnMgdGhhdCBhcmUgY29udHJvbGxlZCB2aWEKPiBydW50aW1lIFBN IEFQSXMgZHVyaW5nIHRoZSBkcml2ZXIncyBwb3dlciBzdGF0ZSB0cmFuc2l0aW9ucy4KPgo+PiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9waHkvcXVhbGNvbW0vcGh5LXFjb20tcW1wLXVzYi5jIGIvZHJp dmVycy9waHkvcXVhbGNvbW0vcGh5LXFjb20tcW1wLXVzYi5jCj4+IGluZGV4IGM1NTA3MTY4ZTEz NTQuLjJhYzZhMjM4NjhiZjkgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvcGh5L3F1YWxjb21tL3Bo eS1xY29tLXFtcC11c2IuYwo+PiArKysgYi9kcml2ZXJzL3BoeS9xdWFsY29tbS9waHktcWNvbS1x bXAtdXNiLmMKPiBbIC4uLiBdCj4+IEBAIC0xODkwLDYgKzE4OTAsNzcgQEAgc3RhdGljIGNvbnN0 IHN0cnVjdCBxbXBfcGh5X2NmZyBnbHltdXJfdXNiM191bmlwaHlfY2ZnID0gewo+IFsgLi4uIF0K Pj4gKy8qIGQzX3RvX2QwIHRyYW5zaXRpb24gYnkgdHVybmluZyBvbiBhbGwgdGhlIHN1cHBsaWVy cyAqLwo+PiArc3RhdGljIGludCBxbXBfdXNiX2QzX3RvX2QwKHN0cnVjdCBxbXBfdXNiICpxbXAp Cj4+ICt7Cj4+ICsJaW50IHJldDsKPj4gKwo+PiArCWlmICghcW1wLT5wZF9saXN0KQo+PiArCQly ZXR1cm4gMDsKPj4gKwo+PiArCXJldCA9IHBtX3J1bnRpbWVfcmVzdW1lX2FuZF9nZXQocW1wLT5w ZF9saXN0LT5wZF9kZXZzWzBdKTsKPj4gKwlpZiAocmV0KQo+PiArCQlyZXR1cm4gcmV0Owo+PiAr Cj4+ICsJcmV0ID0gcG1fcnVudGltZV9yZXN1bWVfYW5kX2dldChxbXAtPnBkX2xpc3QtPnBkX2Rl dnNbMV0pOwo+PiArCj4+ICsJcmV0dXJuIHJldDsKPgo+IFtTZXZlcml0eTogSGlnaF0KPiBJZiB0 aGUgcmVzdW1lIG9mIHBkX2RldnNbMV0gZmFpbHMgaGVyZSwgd2lsbCB0aGlzIGxlYWsgdGhlIHJ1 bnRpbWUgUE0gdXNhZ2UKPiBjb3VudGVyIGZvciBwZF9kZXZzWzBdPyBTaG91bGQgdGhlcmUgYmUg YSBwbV9ydW50aW1lX3B1dF9zeW5jKCkgZm9yCj4gcGRfZGV2c1swXSBiZWZvcmUgcmV0dXJuaW5n IHRoZSBlcnJvcj8KCkluZGVlZC4gV2lsbCBmaXggaW4gdjIuCgo+Cj4+ICt9Cj4+ICsKPj4gKy8q IGQwX3RvX2QzIHRyYW5zaXRpb24gYnkgdHVybmluZyBvZmYgYWxsIHRoZSBzdXBwbGllcnMgKi8K Pj4gK3N0YXRpYyB2b2lkIHFtcF91c2JfZDBfdG9fZDMoc3RydWN0IHFtcF91c2IgKnFtcCkKPj4g K3sKPj4gKwlpZiAoIXFtcC0+cGRfbGlzdCkKPj4gKwkJcmV0dXJuOwo+PiArCj4+ICsJcG1fcnVu dGltZV9wdXRfc3luYyhxbXAtPnBkX2xpc3QtPnBkX2RldnNbMF0pOwo+PiArCXBtX3J1bnRpbWVf cHV0X3N5bmMocW1wLT5wZF9saXN0LT5wZF9kZXZzWzFdKTsKPgo+IFtTZXZlcml0eTogSGlnaF0K PiBTaW5jZSBxbXBfdXNiX2QzX3RvX2QwKCkgZW5hYmxlcyB0aGVzZSBkb21haW5zIGluIHRoZSBv cmRlciAwIHRoZW4gMSwKPiBzaG91bGQgdGhpcyBkaXNhYmxlIHRoZW0gaW4gdGhlIHJldmVyc2Ug b3JkZXIgKDEgdGhlbiAwKT8KCkluZGVlZC4gV2lsbCBmaXggaW4gdjIuCgo+Cj4+ICt9Cj4gWyAu Li4gXQo+PiBAQCAtMTk4MCw2ICsxOTgwLDEyIEBAIHN0YXRpYyBpbnQgcW1wX3VzYl9pbml0KHN0 cnVjdCBwaHkgKnBoeSkKPj4gIAl2b2lkIF9faW9tZW0gKnBjcyA9IHFtcC0+cGNzOwo+PiAgCWlu dCByZXQ7Cj4+ICAKPj4gKwlyZXQgPSBxbXBfdXNiX2QzX3RvX2QwKHFtcCk7Cj4+ICsJaWYgKHJl dCA8IDApIHsKPj4gKwkJZGV2X2VycihxbXAtPmRldiwgIkZhaWxlZCB0byB0cmFuc2l0aW9uIHRv IGQwIHN0YXRlXG4iKTsKPj4gKwkJcmV0dXJuIHJldDsKPj4gKwl9Cj4+ICsKPj4gIAlyZXQgPSBy ZWd1bGF0b3JfYnVsa19lbmFibGUoY2ZnLT5udW1fdnJlZ3MsIHFtcC0+dnJlZ3MpOwo+PiAgCWlm IChyZXQpIHsKPj4gIAkJZGV2X2VycihxbXAtPmRldiwgImZhaWxlZCB0byBlbmFibGUgcmVndWxh dG9ycywgZXJyPSVkXG4iLCByZXQpOwo+PiAgCQlyZXR1cm4gcmV0Owo+Cj4gW1NldmVyaXR5OiBI aWdoXQo+IElmIHJlZ3VsYXRvcl9idWxrX2VuYWJsZSgpIGZhaWxzLCB0aGlzIHJldHVybnMgZGly ZWN0bHkuIERvZXMgdGhpcyBsZWF2ZQo+IHRoZSBQTSBkb21haW5zIGVuYWJsZWQsIGxlYWtpbmcg dGhlaXIgdXNhZ2UgY291bnRlcnMgc2luY2UgcW1wX3VzYl9kMF90b19kMygpCj4gaXMgbm90IGNh bGxlZCB0byBiYWxhbmNlIHRoZSBlYXJsaWVyIHFtcF91c2JfZDNfdG9fZDAoKSBjYWxsPwoKSW5k ZWVkLiBXaWxsIGZpeCBpbiB2Mi4KCj4KPj4gQEAgLTIwMjUsNiArMjAyNSw4IEBAIHN0YXRpYyBp bnQgcW1wX3VzYl9leGl0KHN0cnVjdCBwaHkgKnBoeSkKPj4gIAlzdHJ1Y3QgcW1wX3VzYiAqcW1w ID0gcGh5X2dldF9kcnZkYXRhKHBoeSk7Cj4+ICAJY29uc3Qgc3RydWN0IHFtcF9waHlfY2ZnICpj ZmcgPSBxbXAtPmNmZzsKPj4gIAo+PiArCXFtcF91c2JfZDBfdG9fZDMocW1wKTsKPj4gKwo+PiAg CXJlc2V0X2NvbnRyb2xfYnVsa19hc3NlcnQocW1wLT5udW1fcmVzZXRzLCBxbXAtPnJlc2V0cyk7 Cj4+ICAKPj4gIAljbGtfYnVsa19kaXNhYmxlX3VucHJlcGFyZShxbXAtPm51bV9jbGtzLCBxbXAt PmNsa3MpOwo+Cj4gW1NldmVyaXR5OiBIaWdoXQo+IFRoaXMgZGlzYWJsZXMgdGhlIHBvd2VyIGRv bWFpbnMgdmlhIHFtcF91c2JfZDBfdG9fZDMoKSBiZWZvcmUgZGlzYWJsaW5nCj4gdGhlIGxlYWYg Y2xvY2tzIGFuZCBhc3NlcnRpbmcgdGhlIHJlc2V0cy4gQ2FuIHRoaXMgc2VxdWVuY2UgY2F1c2UK PiB1bmNsb2NrZWQgb3IgdW5wb3dlcmVkIHJlZ2lzdGVyIGFjY2Vzc2VzIGFuZCB0cmlnZ2VyIGhh cmR3YXJlIGZhdWx0cz8KPiBTaG91bGQgdGhlIGRvbWFpbnMgYmUgZGlzYWJsZWQgYXQgdGhlIGVu ZCBvZiB0aGUgdGVhcmRvd24gaW5zdGVhZD8KCk5vIGJlY2F1c2UgcmVzZXRzIGFuZCBjbG9ja3Mg YXJlIG5vdCB1c2VkIGluIHRoZSBmaXJtd2FyZS1tYW5hZ2VkIG1vZGUuCkJ1dCBmb3IgY29uc2lz dGVuY3ksIEkgd2lsbCBtb3ZlIHFtcF91c2JfZDBfdG9fZDMoKSBhdCB0aGUgZW5kIG9mCnFtcF91 c2JfZXhpdCgpIGluIHYyLgoKPgo+PiBAQCAtMjIxMiw2ICsyMjEyLDggQEAgc3RhdGljIGludCBf X21heWJlX3VudXNlZCBxbXBfdXNiX3J1bnRpbWVfc3VzcGVuZChzdHJ1Y3QgZGV2aWNlICpkZXYp Cj4+ICAKPj4gIAlxbXBfdXNiX2VuYWJsZV9hdXRvbm9tb3VzX21vZGUocW1wKTsKPj4gIAo+PiAr CXFtcF91c2JfZDBfdG9fZDEocW1wKTsKPj4gKwo+PiAgCWNsa19kaXNhYmxlX3VucHJlcGFyZShx bXAtPnBpcGVfY2xrKTsKPj4gIAljbGtfYnVsa19kaXNhYmxlX3VucHJlcGFyZShxbXAtPm51bV9j bGtzLCBxbXAtPmNsa3MpOwo+Cj4gW1NldmVyaXR5OiBIaWdoXQo+IFNpbWlsYXIgdG8gdGhlIGV4 aXQgcGF0aCwgdGhpcyBwb3dlcnMgb2ZmIHRoZSB0cmFuc2ZlciBkb21haW4gYmVmb3JlCj4gdGhl IGNsb2NrcyBhcmUgZGlzYWJsZWQuIENvdWxkIHRoaXMgY2F1c2UgYnVzIGVycm9ycyB3aGVuIHRo ZSBjbG9ja3MgYXJlCj4gbWFuaXB1bGF0ZWQ/CgpXaWxsIG1vdmUgYWZ0ZXIgY2xrX2J1bGtfZGlz YWJsZSgpIGluIHYyLgoKPgo+PiBAQCAtMjIzMiw2ICsyMjMyLDEyIEBAIHN0YXRpYyBpbnQgX19t YXliZV91bnVzZWQgcW1wX3VzYl9ydW50aW1lX3Jlc3VtZShzdHJ1Y3QgZGV2aWNlICpkZXYpCj4+ ICAJCXJldHVybiAwOwo+PiAgCX0KPj4gIAo+PiArCXJldCA9IHFtcF91c2JfZDFfdG9fZDAocW1w KTsKPj4gKwlpZiAocmV0IDwgMCkgewo+PiArCQlkZXZfZXJyKHFtcC0+ZGV2LCAiRmFpbGVkIHRv IHRyYW5zaXRpb24gdG8gZDAgc3RhdGVcbiIpOwo+PiArCQlyZXR1cm4gcmV0Owo+PiArCX0KPj4g Kwo+PiAgCXJldCA9IGNsa19idWxrX3ByZXBhcmVfZW5hYmxlKHFtcC0+bnVtX2Nsa3MsIHFtcC0+ Y2xrcyk7Cj4+ICAJaWYgKHJldCkKPj4gIAkJcmV0dXJuIHJldDsKPgo+IFtTZXZlcml0eTogSGln aF0KPiBJZiBjbGtfYnVsa19wcmVwYXJlX2VuYWJsZSgpIGZhaWxzLCB0aGUgZnVuY3Rpb24gcmV0 dXJucyByZXQgd2l0aG91dAo+IHVuZG9pbmcgcW1wX3VzYl9kMV90b19kMCgpLiBXaWxsIHRoaXMg bGVhayB0aGUgdHJhbnNmZXIgZG9tYWluJ3MgUE0gdXNhZ2UKPiBjb3VudGVyPwoKSW5kZWVkLCB3 aWxsIGZpeCBpbiB2Mi4KCj4KPiAtLSAKPiBTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nh c2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA3MDgtcGh5LXFjb20tcW1wLXVzYi04MjU1LXYxLTAt OGQ4NTJhOTUzNWRiQGtlcm5lbC5vcmc/cGFydD0yCgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlz dApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK