From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C7D7ECDFA1 for ; Mon, 24 Oct 2022 08:35:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1n7S7bnHP5cMc6BIfdqq8JNC93CCFKBNvhLf0tP/HH4=; b=4BJZiXZoNlYTCY6knaLOOp/Yel GWZLcEhIMGHMqRDyF7l3D3SSFntKl0L7InFUgr3oK2uS19ybVYNawWiRhiLL+IWjipj6zWo/iN5mS IV1rMpNUm4EWhFxXEipFISwb64sr1683fwm3M4rK9rz0b0VI7t/YINKOLv5vRbZRhaMfNm6Kff8Ru CL92gmz0fXzQ5rGI0G4E9FW4OqnEQFG1rzkBUJ4KvU8QZuPbAjattgel2e0SOyvV547x2FOBftf+t CdxBcRF9PByyMgc0Agj1tHa8IKmRRiVe2nArrbqhO+OphsOLoyBqccbvgIr/917uLvTePioHMfAyv JaGm5pUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1omsve-0009KJ-9A; Mon, 24 Oct 2022 08:35:26 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1omsqE-0006e3-OH for linux-phy@lists.infradead.org; Mon, 24 Oct 2022 08:29:52 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6A7CDB80F93; Mon, 24 Oct 2022 08:29:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E641BC433C1; Mon, 24 Oct 2022 08:29:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666600187; bh=3+MFoZ1i8NaN+dGJz+LHBPaBW3YyJRmXeIrLriHr5xQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RiB8m5v2Qo963Y9TM7sqdS/sz90bczwv0sbW+buMGLeLSyYnI26QbFVsJLaUQydpq toXUpsxA3qVv6X7wPImgP3+x/rFpSwPQBScUGG3wDn6uzYN7gYzjbW/uG08Rj/tX/E MTe0AeHB0nEEHw2+z1ZSfpP9ZeO2mKQSo0cAhmYimHGoTtLFpvSOmid1j/8jxgSm3a X4iQyeOwRcKNkI31Og8/0wBf/OG1S9A9stB0Wg/dGiCC7l/EgK75j/PWg/sBOUZZ5w Rut4rbxkyrgLPqyG4Ymuj9Xp1S8eFdQ/X/yMaq3iloiC8O1jolCJ+iDD3TI1EEah96 Sd2JpFcF4JFUg== From: Felipe Balbi To: Heikki Krogerus , Wayne Chang Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, treding@nvidia.com, jonathanh@nvidia.com, thierry.reding@gmail.com, ajayg@nvidia.com, kishon@ti.com, vkoul@kernel.org, p.zabel@pengutronix.de, mathias.nyman@intel.com, jckuo@nvidia.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, singhanc@nvidia.com, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH 06/11] usb: typec: ucsi_ccg: Replace ccgx to well-known regex In-Reply-To: References: <20221024074128.1113554-1-waynec@nvidia.com> <20221024074128.1113554-7-waynec@nvidia.com> Date: Mon, 24 Oct 2022 11:29:27 +0300 Message-ID: <87czaheiag.fsf@balbi.sh> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221024_012951_123229_921CC00F X-CRM114-Status: GOOD ( 15.71 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8511023989210947080==" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org --===============8511023989210947080== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Heikki Krogerus writes: > On Mon, Oct 24, 2022 at 03:41:23PM +0800, Wayne Chang wrote: >> ccgx is refer to the cypress cypd4226 typec controller. >> Replace ccgx to well-known regex "cypress". >>=20 >> Signed-off-by: Wayne Chang >> --- >> drivers/usb/typec/ucsi/ucsi_ccg.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/= ucsi_ccg.c >> index 139707a2f3d6..5d3099e6eb77 100644 >> --- a/drivers/usb/typec/ucsi/ucsi_ccg.c >> +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c >> @@ -1358,7 +1358,7 @@ static int ucsi_ccg_probe(struct i2c_client *clien= t, >> INIT_WORK(&uc->pm_work, ccg_pm_workaround_work); >>=20=20 >> /* Only fail FW flashing when FW build information is not provided */ >> - status =3D device_property_read_u16(dev, "ccgx,firmware-build", >> + status =3D device_property_read_u16(dev, "cypress,firmware-build", >> &uc->fw_build); >> if (status) >> dev_err(uc->dev, "failed to get FW build information\n"); > > This will break bisectability. You need to first add that > "cyppress,firmware-build" identifier without removing the old > "ccgx,firmware-build" identifier, and then introduce a separate > clean-up patch where you remove it when it's safe to remove: > > 1. Add new - This patch. > 2. Modify users - PATCH 7/11. > 3. Remove old - *missing*. will it ever be safe to remove? What about potential products in the market with little to no upgrade path? There are likely to be products with a DTB that will never be updated, no? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJFBAEBCAAvFiEEg3wK/NVnD14JZqsmho6y4DXKpEQFAmNWTOcRHGJhbGJpQGtl cm5lbC5vcmcACgkQho6y4DXKpETKbhAAg5C1ownOUJ82waG7ngsOPNNJyNnWWzed 43ejPV1pnND/jUAdJSOrLNCKaz4yp6n53TCnRlbjKxARL1UF7l2RvpsNdBuJ6w66 xZAuM6N33hL0BC4hwmGb4PLc86qz82FClw15Iz0jHICeMHir2mZ2eOhWVJcnvWLh VTwJ3FJiTPcl2LFOzB7aoyYGAEQAYFfIv7fpDLoEawUilglOGWcs3Ltxhs9LswZI mwzSjzXrs/vs7iOa4fxhbtO2/ET3DoUUGMTQjXbPg4dsIN7Zw8FElayi+Go9wz5p xAoaAVZH8c0U3cKFxjXFRiiZnDIJFnhakyVsju/putdRpqSKYTs7DhmHufbRlFHm q2ivC4/fM0ZB8UbdvmVitfIli/caTyETNIpZaMjAPeBTlmqZYjoI+/+IMP/24k53 GPoGXv0aTGqlcltZdnXw+gK/lSLTv6dNH+uq6WofjMm1f+4eQqnozWhzdC3siVMc euVl6PaYndTJT5ZKusWMQF1TBXiskmgD9Ydi6sMz5nQQZruiGq4RFBGIM/Ip/Bp0 pOwcDgiKiijJ/M88nG6NrEaFEI8HNBRXPO0o11AiehMla/0Qstko5G0fhIlwlFT4 CHUVsacTMLw1GYNXSIkHqGS5drwOP3SEXSSqOHmAsNpVf/h8TZiE0OCR1My9dRLt 49hqCxIw+JE= =OxAo -----END PGP SIGNATURE----- --=-=-=-- --===============8511023989210947080== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy --===============8511023989210947080==--