From: Neil Armstrong <neil.armstrong@linaro.org>
To: Prabhakar <prabhakar.csengg@gmail.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH 5/5] phy: renesas: rcar-gen3-usb2: Move debug print after register value is updated
Date: Wed, 6 Aug 2025 16:08:17 +0200 [thread overview]
Message-ID: <8f1ded5f-430d-4e9d-a328-aecaef1e6d60@linaro.org> (raw)
In-Reply-To: <20250805122529.2566580-6-prabhakar.mahadev-lad.rj@bp.renesas.com>
On 05/08/2025 14:25, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Relocate the debug print in rcar_gen3_enable_vbus_ctrl() to appear after
> the `val` variable is assigned and updated based on the VBUS state. This
> ensures that the debug log reflects the actual register value being
> written, improving debugging accuracy.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> drivers/phy/renesas/phy-rcar-gen3-usb2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
<snip>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2025-08-06 14:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 12:25 [PATCH 0/5] Add USB2 PHY support for RZ/T2H and RZ/N2H SoCs Prabhakar
2025-08-05 12:25 ` [PATCH 1/5] dt-bindings: phy: renesas,usb2-phy: Add RZ/T2H and RZ/N2H support Prabhakar
2025-08-05 17:09 ` Conor Dooley
2025-08-05 12:25 ` [PATCH 2/5] phy: renesas: rcar-gen3-usb2: Store drvdata pointer in channel Prabhakar
2025-08-06 14:06 ` Neil Armstrong
2025-08-06 20:01 ` Lad, Prabhakar
2025-08-05 12:25 ` [PATCH 3/5] phy: renesas: rcar-gen3-usb2: Allow SoC-specific OBINT bits via phy_data Prabhakar
2025-08-06 14:07 ` Neil Armstrong
2025-08-05 12:25 ` [PATCH 4/5] phy: renesas: rcar-gen3-usb2: Add support for RZ/T2H SoC Prabhakar
2025-08-06 14:07 ` Neil Armstrong
2025-08-06 14:51 ` Geert Uytterhoeven
2025-08-06 20:06 ` Lad, Prabhakar
2025-08-06 20:40 ` kernel test robot
2025-08-05 12:25 ` [PATCH 5/5] phy: renesas: rcar-gen3-usb2: Move debug print after register value is updated Prabhakar
2025-08-06 14:08 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f1ded5f-430d-4e9d-a328-aecaef1e6d60@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox