Re: [PATCH] phy: renesas: rzg3e-usb3: Convert to FIELD_MODIFY()

Neil Armstrong
2026-03-06T10:35:36Z

On 3/5/26 11:15, Geert Uytterhoeven wrote:
> Use the FIELD_MODIFY() helper instead of open-coding the same operation.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> No changes in generated code.
> ---
> drivers/phy/renesas/phy-rzg3e-usb3.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/phy/renesas/phy-rzg3e-usb3.c b/drivers/phy/renesas/phy-rzg3e-usb3.c
> index 6b3453ea0004cf59..7f809ef1bb5135ec 100644
> --- a/drivers/phy/renesas/phy-rzg3e-usb3.c
> +++ b/drivers/phy/renesas/phy-rzg3e-usb3.c
> @@ -78,13 +78,11 @@ static void rzg3e_phy_usb2test_phy_init(void __iomem *base)
> writel(val, base + USB3_TEST_UTMICTRL2);
>
> val = readl(base + USB3_TEST_PRMCTRL5_R);
> - val &= ~USB3_TEST_PRMCTRL5_R_TXPREEMPAMPTUNE0_MASK;
> - val |= FIELD_PREP(USB3_TEST_PRMCTRL5_R_TXPREEMPAMPTUNE0_MASK, 2);
> + FIELD_MODIFY(USB3_TEST_PRMCTRL5_R_TXPREEMPAMPTUNE0_MASK, &val, 2);
> writel(val, base + USB3_TEST_PRMCTRL5_R);
>
> val = readl(base + USB3_TEST_PRMCTRL6_R);
> - val &= ~USB3_TEST_PRMCTRL6_R_OTGTUNE0_MASK;
> - val |= FIELD_PREP(USB3_TEST_PRMCTRL6_R_OTGTUNE0_MASK, 7);
> + FIELD_MODIFY(USB3_TEST_PRMCTRL6_R_OTGTUNE0_MASK, &val, 7);
> writel(val, base + USB3_TEST_PRMCTRL6_R);
>
> val = readl(base + USB3_TEST_RESET);

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil

--
linux-phy mailing list
linux-phy@lists.infradead.org