Linux-PHY Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: George Moussalem <george.moussalem@outlook.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: "Vinod Koul" <vkoul@kernel.org>,
	"Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Nitheesh Sekar" <quic_nsekar@quicinc.com>,
	"Varadarajan Narayanan" <quic_varada@quicinc.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org,
	20250317100029.881286-2-quic_varada@quicinc.com,
	"Sricharan Ramabadhran" <quic_srichara@quicinc.com>
Subject: Re: [PATCH v6 6/6] arm64: dts: qcom: ipq5018: Enable PCIe
Date: Mon, 24 Mar 2025 20:38:30 +0100	[thread overview]
Message-ID: <9602e069-71c0-4feb-9c36-f1bf01c15a6f@oss.qualcomm.com> (raw)
In-Reply-To: <DS7PR19MB8883D7102C8A7BE2A87B77009DA42@DS7PR19MB8883.namprd19.prod.outlook.com>

On 3/24/25 9:06 AM, George Moussalem wrote:
> 
> 
> On 3/21/25 18:13, Dmitry Baryshkov wrote:
>> On Fri, Mar 21, 2025 at 04:14:44PM +0400, George Moussalem via B4 Relay wrote:
>>> From: Nitheesh Sekar <quic_nsekar@quicinc.com>
>>>
>>> Enable the PCIe controller and PHY nodes for RDP 432-c2.
>>>
>>> Signed-off-by: Nitheesh Sekar <quic_nsekar@quicinc.com>
>>> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
>>> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
>>> ---
>>>   arch/arm64/boot/dts/qcom/ipq5018-rdp432-c2.dts | 40 ++++++++++++++++++++++++++
>>>   1 file changed, 40 insertions(+)
>>
>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>>
>> Minor question below.
>>
>>> +
>>> +&pcie0_phy {
>>> +    status = "okay";
>>
>> If you have schematics, are you sure that there are no supplies for the
>> PCIe PHY / PCIe PLLs on this board?
> 
> I don't have the schematics, but none of the boards I've personally tested (mostly Linksys devices) require any supply. I've also checked the downstream board files documented on codelinaro for ipq5018, and none mention a supply.

It looks like on the reference board it's connected to an essentially
always-on supply, I'd expect that to be the case on yours as well

Konrad

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2025-03-24 19:56 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-21 12:14 [PATCH v6 0/6] Enable IPQ5018 PCI support George Moussalem via B4 Relay
2025-03-21 12:14 ` [PATCH v6 1/6] dt-bindings: phy: qcom: uniphy-pcie: Add ipq5018 compatible George Moussalem via B4 Relay
2025-03-22 20:16   ` Rob Herring (Arm)
2025-03-21 12:14 ` [PATCH v6 2/6] phy: qualcomm: qcom-uniphy-pcie 28LP add support for IPQ5018 George Moussalem via B4 Relay
2025-03-21 14:10   ` Dmitry Baryshkov
2025-03-21 12:14 ` [PATCH v6 3/6] dt-bindings: PCI: qcom: Add IPQ5018 SoC George Moussalem via B4 Relay
2025-03-24  7:50   ` Krzysztof Kozlowski
2025-03-24  7:52   ` Manivannan Sadhasivam
2025-03-21 12:14 ` [PATCH v6 4/6] PCI: qcom: Add support for IPQ5018 George Moussalem via B4 Relay
2025-03-21 12:14 ` [PATCH v6 5/6] arm64: dts: qcom: ipq5018: Add PCIe related nodes George Moussalem via B4 Relay
2025-03-21 14:10   ` Dmitry Baryshkov
2025-03-24  7:56   ` Manivannan Sadhasivam
2025-03-24 11:18     ` Praveenkumar I
2025-03-24 11:36       ` Dmitry Baryshkov
2025-03-24 19:40         ` Konrad Dybcio
2025-03-25 16:53       ` Manivannan Sadhasivam
2025-03-26  7:41         ` Praveenkumar I
2025-03-27 17:28           ` Manivannan Sadhasivam
2025-03-21 12:14 ` [PATCH v6 6/6] arm64: dts: qcom: ipq5018: Enable PCIe George Moussalem via B4 Relay
2025-03-21 14:13   ` Dmitry Baryshkov
2025-03-24  8:06     ` George Moussalem
2025-03-24 19:38       ` Konrad Dybcio [this message]
2025-03-24  7:58   ` Manivannan Sadhasivam
2025-03-24 19:39   ` Konrad Dybcio
2025-03-21 15:05 ` [PATCH v6 0/6] Enable IPQ5018 PCI support Rob Herring (Arm)
2025-03-24  7:47 ` Krzysztof Kozlowski
2025-03-25  7:55   ` George Moussalem

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9602e069-71c0-4feb-9c36-f1bf01c15a6f@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=20250317100029.881286-2-quic_varada@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=george.moussalem@outlook.com \
    --cc=kishon@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=lpieralisi@kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=quic_nsekar@quicinc.com \
    --cc=quic_srichara@quicinc.com \
    --cc=quic_varada@quicinc.com \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox