From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31A31C6FD1F for ; Tue, 14 Mar 2023 15:35:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZFJffqDeZ4exXlfqoNkkAITe3GsdnW0Vcu1eKN5SgZw=; b=L+n93JkqPIkNafASl4djLRCcP7 4YK5lgDYX7g31/hwIqVkBh/POWxvh/FiV7Jrkf6v/LFPDnqzRellnxz5EWrVoqW/Nm/5uWoR3jJBl +U+VFW47apQX6YtERsWNzrbPPjGN3OiPW6C3biDjSSrqxNSN97KX6iTokn7SzYIY1pRdJhdCZevhu 9O3lhkpri5s/Ay0OSHYaBVNhcSs7gJohihcAkKiNdFGwAVWjdVRHhDv45QvOjs8mNIPix1auO/trA IkHVPVIf+1LD/knqmNcy0hcfmasb18r75C6lsITmRW+mc56tZadwHbP7kw5qJl7CjWykPrQRDVETo lch5MVBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pc6gP-00Acgc-2X; Tue, 14 Mar 2023 15:35:25 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pc6gN-00AcfK-0B for linux-phy@lists.infradead.org; Tue, 14 Mar 2023 15:35:24 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 80E0DB818B9; Tue, 14 Mar 2023 15:35:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E9B1C433EF; Tue, 14 Mar 2023 15:35:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678808120; bh=lDxTSgsnXum9DYPXFxbGHFuMeuz70JNgYVKghxXniaQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PCbHWZWFAJlaHmd0FT7vhDiC4wqizF5BpL3ect84f8v0e1UNTESM3LvnrzbhI2reT 7nxR3gTkrhTS2uMmYZLDo7/oAbLUwrU+I6ajJIoot/l5bJRZabCymLbKPUgAY8qeSN 9UWTeXhHicJV7fU/KCy8hxbBX3ULT1Mn9sPrCy9et4dcxWt604vKEMljxZeNPOpalB BvwLY0rIbr+cdaHOqr4D4Bs3512/5bn/mu0WNJMZp4QbA+QxwUp22TDWAlRnxWaEg1 6gRU4p6ofq61DtVttGeFblrTs6dUFeGEeXbUzlCsdTeZb0U8z1wyje3Ia5Lqg6/jVN E+p+tHrGHwFcw== Date: Tue, 14 Mar 2023 15:35:15 +0000 From: Conor Dooley To: Sakari Ailus , Nicolas Ferre Cc: Eugen Hristev , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, luis.oliveira@synopsys.com, Conor Dooley Subject: Re: [PATCH v5 3/4] media: platform: dwc: Add MIPI CSI-2 controller driver Message-ID: <97746427-c373-4e49-be8d-31a22ece30c7@spud> References: <20221216143717.1002015-1-eugen.hristev@microchip.com> <20221216143717.1002015-4-eugen.hristev@microchip.com> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230314_083523_371528_5786647A X-CRM114-Status: GOOD ( 19.37 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1322572456564244039==" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org --===============1322572456564244039== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8J/HusImJ6ezRElp" Content-Disposition: inline --8J/HusImJ6ezRElp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 14, 2023 at 04:20:09PM +0200, Sakari Ailus wrote: > Hi Eugen, >=20 > On Fri, Dec 16, 2022 at 04:37:16PM +0200, Eugen Hristev wrote: > > From: Luis Oliveira > >=20 > > Add the Synopsys MIPI CSI-2 controller driver. This > > controller driver is divided in platform functions and core functions. > > This way it serves as platform for future DesignWare drivers. > >=20 > > Signed-off-by: Luis Oliveira > > Co-developed-by: Eugen Hristev > > [eugen.hristev@microchip.com: > > Add format SRGGB10 to supported format list. > > Write the data type to the correct register DATA_IDS_1. > > Changed dev_info to dev_dbg to remove extra chatty messages > > Avoid overwriting static array of formats] > > Signed-off-by: Eugen Hristev > > [luis.oliveira@synopsys.com: Add MIPI CSI-2 platform data] > > Signed-off-by: Luis Oliveira > > [eugen.hristev@microchip.com: > > Add support for periph clock and phy clock > > Fix enum_mbus function > > Implement get_mbus_config > > Implement media controller > > Update to use fwnode API > > In s_stream, first start/stop the sensor > > remove chatty 'number of lanes' message] > > Signed-off-by: Eugen Hristev > > [conor.dooley@microchip.com: fix potential uninitialized variable use] > > Signed-off-by: Conor Dooley > > [eugen.hristev@microchip.com: port to kernel 5.16, 5.17] > > Signed-off-by: Eugen Hristev >=20 > Same comment than on the 4th patch, this isn't very readable or relevant. I'd imagine it can just be collapsed into a Co-developed-by & a signoff as we hardly need multiple w/ the same names & companies involved each time. My "contribution" here (initialising some variables) doesn't warrant inclusion IMO. Eugen doesn't work for Microchip anymore though, and I don't know what the plan for continuing the upstreaming of this driver is. @Nicolas, do you have a plan here? Cheers, Conor. --8J/HusImJ6ezRElp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZBCULgAKCRB4tDGHoIJi 0iXuAP43K8ntq9hXNbCfFEVPAXip9/lwYTQwOWcfU6wbxAHrcwD/TZa0zkYCap0q qTYag3lIixUkXWo4nH8aVLD7SH3EngQ= =e0GH -----END PGP SIGNATURE----- --8J/HusImJ6ezRElp-- --===============1322572456564244039== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy --===============1322572456564244039==--