public inbox for linux-phy@lists.infradead.org
 help / color / mirror / Atom feed
From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Rob Herring <robh@kernel.org>
Cc: Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 7/8] dt-bindings: phy: uniphier-ahci: Add bindings for Pro4 SoC
Date: Fri, 29 Oct 2021 19:33:21 +0900	[thread overview]
Message-ID: <9db1cd5a-c4f0-a1d2-2681-e8c58ee540ee@socionext.com> (raw)
In-Reply-To: <YXsSPm1SdvaeDwbq@robh.at.kernel.org>

Hi Rob,

On 2021/10/29 6:12, Rob Herring wrote:
> On Wed, Oct 20, 2021 at 08:58:07AM +0900, Kunihiko Hayashi wrote:
>> Update AHCI-PHY binding document for UniPhier Pro4 SoC. Add a compatible
>> string, clock and reset lines for the SoC to the document.
>>
>> Pro4 AHCI-PHY needs to control additional GIO clock line and reset lines
>> ("pm", "tx", and "rx").
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>>   .../bindings/phy/socionext,uniphier-ahci-phy.yaml    | 20
> ++++++++++++++++----
>>   1 file changed, 16 insertions(+), 4 deletions(-)
>>
>> diff --git
> a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
> b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.yaml
>> index 745c525ce6b9..67415f7ebe8c 100644
>> --- a/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.
> yaml
>> +++ b/Documentation/devicetree/bindings/phy/socionext,uniphier-ahci-phy.
> yaml
>> @@ -16,6 +16,7 @@ maintainers:
>>   properties:
>>     compatible:
>>       enum:
>> +      - socionext,uniphier-pro4-ahci-phy
>>         - socionext,uniphier-pxs2-ahci-phy
>>         - socionext,uniphier-pxs3-ahci-phy
>>   
>> @@ -30,6 +31,9 @@ properties:
>>   
>>     clock-names:
>>       oneOf:
>> +      - items:          # for Pro4
>> +          - const: gio
>> +          - const: link
> 
> Add new entries on the end...
> 
>>         - items:          # for PXs2
>>             - const: link
> 
> So add 'gio' here.
> 
> And add 'minItems: 1' in this entry.
> 
> There's also an error in 'clocks' as it needs 'minItems: 1'

I see.
I'll add "minItems: 1", and fix the item order.

> 
>>         - items:          # for others
>> @@ -37,12 +41,20 @@ properties:
>>             - const: phy
>>   
>>     resets:
>> -    maxItems: 2
>> +    minItems: 2
>> +    maxItems: 5
>>   
>>     reset-names:
>> -    items:
>> -      - const: link
>> -      - const: phy
>> +    oneOf:
>> +      - items:          # for Pro4
>> +          - const: gio
>> +          - const: link
>> +          - const: pm
>> +          - const: tx
>> +          - const: rx
>> +      - items:          # for others
>> +          - const: link
>> +          - const: phy
>>   
>>   required:
>>     - compatible
>> -- 
>> 2.7.4

Thank you,

---
Best Regards
Kunihiko Hayashi

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2021-10-29 10:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19 23:58 [PATCH v2 0/8] phy: socionext: Introduce some features for UniPhier SoCs Kunihiko Hayashi
2021-10-19 23:58 ` [PATCH v2 1/8] dt-bindings: phy: uniphier-usb3: Add bindings for NX1 SoC Kunihiko Hayashi
2021-10-28 21:05   ` Rob Herring
2021-10-19 23:58 ` [PATCH v2 2/8] phy: uniphier-usb3: Add compatible string " Kunihiko Hayashi
2021-10-19 23:58 ` [PATCH v2 3/8] dt-bindings: phy: uniphier-pcie: Add bindings " Kunihiko Hayashi
2021-10-28 21:06   ` Rob Herring
2021-10-19 23:58 ` [PATCH v2 4/8] phy: uniphier-pcie: Add compatible string and SoC-dependent data " Kunihiko Hayashi
2021-10-19 23:58 ` [PATCH v2 5/8] phy: uniphier-pcie: Set VCOPLL clamp mode in PHY register Kunihiko Hayashi
2021-10-19 23:58 ` [PATCH v2 6/8] phy: uniphier-pcie: Add dual-phy support for NX1 SoC Kunihiko Hayashi
2021-10-19 23:58 ` [PATCH v2 7/8] dt-bindings: phy: uniphier-ahci: Add bindings for Pro4 SoC Kunihiko Hayashi
2021-10-28 21:12   ` Rob Herring
2021-10-29 10:33     ` Kunihiko Hayashi [this message]
2021-10-19 23:58 ` [PATCH v2 8/8] phy: uniphier-ahci: Add support " Kunihiko Hayashi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9db1cd5a-c4f0-a1d2-2681-e8c58ee540ee@socionext.com \
    --to=hayashi.kunihiko@socionext.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mhiramat@kernel.org \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox