From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4893CD38FFF for ; Wed, 14 Jan 2026 17:45:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Message-Id:MIME-Version:Subject:Cc :To:From:References:In-Reply-To:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NPwZapfkDZepV964Sx34KXK5gR2IgmZU9+IVVS9HyHo=; b=X20QvFlHB19PUX bWc+TvhJvSBWAV2k0UaGElpWhOBMqDIbUsiXvV9jKzmNI36VbgSESbMi75PiPh1yRboxDPryH6nD9 0sClB0SlVGmfXTAN3wCTZiXTF9x/WAotO1k5kJhML5FqPupTm/PtLIzUvmffTekOVKNlv4pBOyqVr P3tvr72jPJcbx4gY9H0OLLXuTcqxm118gTYylEvafV1285dJrfAsYzbzoBGXauibOm/EdbdHZCjsj uiw/YBFlkfSzMA6yY5fI8TGSxkELG3arnBf4y/8GRgtzZ9B0Q8eshvZi2lBVwNY7A5MHE46nqnEBX piRMgdnRyYgFN+cAR9aA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vg4wD-0000000ABK9-3p1k; Wed, 14 Jan 2026 17:45:45 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vg4w8-0000000ABFn-3EVL; Wed, 14 Jan 2026 17:45:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Date:Sender:Message-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:Subject:Cc:To:From:References: In-Reply-To:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=UKAhlr5OggK7Kiko5hzrUZsY9UdyS+aSQMwobLSy2wU=; b=wswCc7NvOlzQJtS2vFxO3q+Kgc kMHo/dZtkrt79nbhbCqKRx3VoyBWbdiAA9RTdhNyFaQpL+sMa2HNFcHS4K5arCgc/itYE6haMys96 ClJ8yVQ0nN7BeEHJVMQ1wo/xaGoAx1RWEwSdUJqHrG/HHVXL5lZmd94U1rt3gBsCOuWbruSU4HCjH rcG8MMSGeNOWrhNCxnRQ1kKeh2JHuXZUmEw6T0tT8di4Bqrtfk1VUvh9r2cWNDeBGzGS1JHyLmxS6 B2sBGboEvqJhEgz1GAjevcjdZ6KZbgW7jSboiYFGzz8xSLwf8QQOS4H13PKYzy7bBEYKne7ASLYTy jzObsRJg==; Received: from e0022681537dd.dyn.armlinux.org.uk ([fd8f:7570:feb6:1:222:68ff:fe15:37dd]:40208 helo=rmk-PC.armlinux.org.uk) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vg4w0-000000000Tn-1RQy; Wed, 14 Jan 2026 17:45:32 +0000 Received: from rmk by rmk-PC.armlinux.org.uk with local (Exim 4.98.2) (envelope-from ) id 1vg4vx-00000003SFz-1ldy; Wed, 14 Jan 2026 17:45:29 +0000 In-Reply-To: References: From: "Russell King (Oracle)" To: Andrew Lunn , Heiner Kallweit Cc: Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Konrad Dybcio , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , Mohd Ayaan Anwar , Neil Armstrong , netdev@vger.kernel.org, Paolo Abeni , Vinod Koul Subject: [PATCH net-next 04/14] net: stmmac: wrap phylink's rx_clk_stop functions MIME-Version: 1.0 Content-Disposition: inline Message-Id: Date: Wed, 14 Jan 2026 17:45:29 +0000 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260114_094541_466543_10D0B098 X-CRM114-Status: GOOD ( 13.15 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org With generic SerDes support, stmmac will need to do more work to ensure that clk_rx_i is running in all configurations. Rather than turn each site that calls phylink_rx_clk_stop_xxx() into a list of functions, move these to their own pair of functions so that they can be augmented at a single location. Signed-off-by: Russell King (Oracle) --- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 32 ++++++++++++------- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index c2589f02ff7e..24a2555ca329 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -3547,6 +3547,16 @@ static void stmmac_safety_feat_configuration(struct stmmac_priv *priv) } } +static void stmmac_clk_rx_i_require(struct stmmac_priv *priv) +{ + phylink_rx_clk_stop_block(priv->phylink); +} + +static void stmmac_clk_rx_i_release(struct stmmac_priv *priv) +{ + phylink_rx_clk_stop_unblock(priv->phylink); +} + /** * stmmac_hw_setup - setup mac in a usable state. * @dev : pointer to the device structure. @@ -3578,12 +3588,12 @@ static int stmmac_hw_setup(struct net_device *dev) * Block the receive clock stop for LPI mode at the PHY in case * the link is established with EEE mode active. */ - phylink_rx_clk_stop_block(priv->phylink); + stmmac_clk_rx_i_require(priv); /* DMA initialization and SW reset */ ret = stmmac_init_dma_engine(priv); if (ret < 0) { - phylink_rx_clk_stop_unblock(priv->phylink); + stmmac_clk_rx_i_release(priv); netdev_err(priv->dev, "%s: DMA engine initialization failed\n", __func__); return ret; @@ -3591,7 +3601,7 @@ static int stmmac_hw_setup(struct net_device *dev) /* Copy the MAC addr into the HW */ stmmac_set_umac_addr(priv, priv->hw, dev->dev_addr, 0); - phylink_rx_clk_stop_unblock(priv->phylink); + stmmac_clk_rx_i_release(priv); /* Initialize the MAC Core */ stmmac_core_init(priv, priv->hw, dev); @@ -3670,9 +3680,9 @@ static int stmmac_hw_setup(struct net_device *dev) /* Start the ball rolling... */ stmmac_start_all_dma(priv); - phylink_rx_clk_stop_block(priv->phylink); + stmmac_clk_rx_i_require(priv); stmmac_set_hw_vlan_mode(priv, priv->hw); - phylink_rx_clk_stop_unblock(priv->phylink); + stmmac_clk_rx_i_release(priv); return 0; } @@ -6107,9 +6117,9 @@ static int stmmac_set_features(struct net_device *netdev, else priv->hw->hw_vlan_en = false; - phylink_rx_clk_stop_block(priv->phylink); + stmmac_clk_rx_i_require(priv); stmmac_set_hw_vlan_mode(priv, priv->hw); - phylink_rx_clk_stop_unblock(priv->phylink); + stmmac_clk_rx_i_release(priv); return 0; } @@ -6378,9 +6388,9 @@ static int stmmac_set_mac_address(struct net_device *ndev, void *addr) if (ret) goto set_mac_error; - phylink_rx_clk_stop_block(priv->phylink); + stmmac_clk_rx_i_require(priv); stmmac_set_umac_addr(priv, priv->hw, ndev->dev_addr, 0); - phylink_rx_clk_stop_unblock(priv->phylink); + stmmac_clk_rx_i_release(priv); set_mac_error: pm_runtime_put(priv->device); @@ -8192,11 +8202,11 @@ int stmmac_resume(struct device *dev) stmmac_init_timestamping(priv); stmmac_init_coalesce(priv); - phylink_rx_clk_stop_block(priv->phylink); + stmmac_clk_rx_i_require(priv); stmmac_set_rx_mode(ndev); stmmac_restore_hw_vlan_rx_fltr(priv, ndev, priv->hw); - phylink_rx_clk_stop_unblock(priv->phylink); + stmmac_clk_rx_i_release(priv); stmmac_enable_all_queues(priv); stmmac_enable_all_dma_irq(priv); -- 2.47.3 -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy