From: Johan Hovold <johan@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Vinod Koul <vkoul@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/13] phy: qcom-qmp-combo: drop sc8280xp power-down delay
Date: Tue, 11 Oct 2022 16:21:06 +0200 [thread overview]
Message-ID: <Y0V70n11uaztrYHo@hovoldconsulting.com> (raw)
In-Reply-To: <ce6370f9-962c-905b-5188-a9b6ff9e2fd3@linaro.org>
On Tue, Oct 11, 2022 at 05:07:16PM +0300, Dmitry Baryshkov wrote:
> On 11/10/2022 16:14, Johan Hovold wrote:
> > The SC8280XP combo PHY does not need a delay before starting the USB PHY
> > (which is what the has_pwrdn_delay config option really controls) so
> > drop the unnecessary delay.
> >
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > ---
> > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 4 ----
> > 1 file changed, 4 deletions(-)
>
> Just an obvious question: 'does not need a delay' comes from your
> experience or from some vendor flag (in ACPI/DT/kernel/wherever)?
There's no corresponding delay in the vendor driver; the delay as it
is used in the driver (before starting the PHY) makes no sense and
shouldn't be used for new platforms; and I've verified that it isn't
needed on SC8280XP.
I'm confident that this was just another case of copy-pasting. And the
buck stops here (with SC8280XP). ;)
Johan
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-10-11 14:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 13:14 [PATCH 00/13] phy: qcom-qmp: further prep cleanups Johan Hovold
2022-10-11 13:14 ` [PATCH 01/13] phy: qcom-qmp: drop regulator error message Johan Hovold
2022-10-11 13:52 ` Dmitry Baryshkov
2022-10-11 13:14 ` [PATCH 02/13] phy: qcom-qmp: drop superfluous comments Johan Hovold
2022-10-11 13:51 ` Dmitry Baryshkov
2022-10-11 13:14 ` [PATCH 03/13] phy: qcom-qmp-combo: drop unused in-layout configuration Johan Hovold
2022-10-11 13:51 ` Dmitry Baryshkov
2022-10-11 13:14 ` [PATCH 04/13] phy: qcom-qmp-pcie: drop redundant ipq8074 power on Johan Hovold
2022-10-11 13:51 ` Dmitry Baryshkov
2022-10-11 13:14 ` [PATCH 05/13] phy: qcom-qmp-pcie-msm8996: drop unused in-layout configuration Johan Hovold
2022-10-11 13:53 ` Dmitry Baryshkov
2022-10-11 13:14 ` [PATCH 06/13] phy: qcom-qmp-ufs: " Johan Hovold
2022-10-11 13:53 ` Dmitry Baryshkov
2022-10-11 13:14 ` [PATCH 07/13] phy: qcom-qmp-usb: " Johan Hovold
2022-10-11 13:14 ` [PATCH 08/13] phy: qcom-qmp-pcie: drop power-down delay config Johan Hovold
2022-10-11 13:46 ` Dmitry Baryshkov
2022-10-11 13:53 ` Johan Hovold
2022-10-11 14:04 ` Dmitry Baryshkov
2022-10-11 14:17 ` Johan Hovold
2022-10-11 14:41 ` Dmitry Baryshkov
2022-10-12 6:39 ` Johan Hovold
2022-10-11 13:49 ` Dmitry Baryshkov
2022-10-11 13:14 ` [PATCH 09/13] phy: qcom-qmp-pcie-msm8996: " Johan Hovold
2022-10-11 13:49 ` Dmitry Baryshkov
2022-10-11 13:14 ` [PATCH 10/13] phy: qcom-qmp-combo: drop sc8280xp power-down delay Johan Hovold
2022-10-11 14:07 ` Dmitry Baryshkov
2022-10-11 14:21 ` Johan Hovold [this message]
2022-10-11 13:14 ` [PATCH 11/13] phy: qcom-qmp-combo: drop power-down delay config Johan Hovold
2022-10-11 14:05 ` Dmitry Baryshkov
2022-10-11 13:14 ` [PATCH 12/13] phy: qcom-qmp-usb: drop sc8280xp power-down delay Johan Hovold
2022-10-11 13:14 ` [PATCH 13/13] phy: qcom-qmp-usb: drop power-down delay config Johan Hovold
2022-10-11 14:05 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0V70n11uaztrYHo@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=kishon@ti.com \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).