* [PATCH] phy: stm32: fix an error code in probe
@ 2022-10-14 9:25 Dan Carpenter
2022-10-14 11:05 ` Amelie Delaunay
2022-10-17 5:25 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2022-10-14 9:25 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Vinod Koul, Maxime Coquelin, Alexandre Torgue, Amelie Delaunay,
Fabrice Gasnier, linux-phy, linux-stm32, kernel-janitors
If "index > usbphyc->nphys" is true then this returns success but it
should return -EINVAL.
Fixes: 94c358da3a05 ("phy: stm32: add support for STM32 USB PHY Controller (USBPHYC)")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/phy/st/phy-stm32-usbphyc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
index a98c911cc37a..5bb9647b078f 100644
--- a/drivers/phy/st/phy-stm32-usbphyc.c
+++ b/drivers/phy/st/phy-stm32-usbphyc.c
@@ -710,6 +710,8 @@ static int stm32_usbphyc_probe(struct platform_device *pdev)
ret = of_property_read_u32(child, "reg", &index);
if (ret || index > usbphyc->nphys) {
dev_err(&phy->dev, "invalid reg property: %d\n", ret);
+ if (!ret)
+ ret = -EINVAL;
goto put_child;
}
--
2.35.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: stm32: fix an error code in probe
2022-10-14 9:25 [PATCH] phy: stm32: fix an error code in probe Dan Carpenter
@ 2022-10-14 11:05 ` Amelie Delaunay
2022-10-17 5:25 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Amelie Delaunay @ 2022-10-14 11:05 UTC (permalink / raw)
To: Dan Carpenter, Kishon Vijay Abraham I
Cc: Vinod Koul, Maxime Coquelin, Alexandre Torgue, Fabrice Gasnier,
linux-phy, linux-stm32, kernel-janitors
On 10/14/22 11:25, Dan Carpenter wrote:
> If "index > usbphyc->nphys" is true then this returns success but it
> should return -EINVAL.
>
> Fixes: 94c358da3a05 ("phy: stm32: add support for STM32 USB PHY Controller (USBPHYC)")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks Dan,
Reviewed-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
> ---
> drivers/phy/st/phy-stm32-usbphyc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c
> index a98c911cc37a..5bb9647b078f 100644
> --- a/drivers/phy/st/phy-stm32-usbphyc.c
> +++ b/drivers/phy/st/phy-stm32-usbphyc.c
> @@ -710,6 +710,8 @@ static int stm32_usbphyc_probe(struct platform_device *pdev)
> ret = of_property_read_u32(child, "reg", &index);
> if (ret || index > usbphyc->nphys) {
> dev_err(&phy->dev, "invalid reg property: %d\n", ret);
> + if (!ret)
> + ret = -EINVAL;
> goto put_child;
> }
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] phy: stm32: fix an error code in probe
2022-10-14 9:25 [PATCH] phy: stm32: fix an error code in probe Dan Carpenter
2022-10-14 11:05 ` Amelie Delaunay
@ 2022-10-17 5:25 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2022-10-17 5:25 UTC (permalink / raw)
To: Dan Carpenter
Cc: Kishon Vijay Abraham I, Maxime Coquelin, Alexandre Torgue,
Amelie Delaunay, Fabrice Gasnier, linux-phy, linux-stm32,
kernel-janitors
On 14-10-22, 12:25, Dan Carpenter wrote:
> If "index > usbphyc->nphys" is true then this returns success but it
> should return -EINVAL.
Applied, thanks
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-17 5:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-14 9:25 [PATCH] phy: stm32: fix an error code in probe Dan Carpenter
2022-10-14 11:05 ` Amelie Delaunay
2022-10-17 5:25 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).