From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E73A6FA3741 for ; Mon, 24 Oct 2022 08:46:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fNyTp26974s/YpflT+Un8+NMXpV//hjt2w1edSfJ8cI=; b=M7eG3+jSyYY0AD zwEdWLqXSxY0bRCXudMfTaBy+yUB/b1lmjNaFZPY2dKCeF1Yt9sj1ME10kLehsHRLw+VdTJ8fxIn3 fDn5dQk9JqAlPOzq/OL6OYoqdDHYPbh0YECy9jS82Oih7z4sgtRowTifOZIvHF7qDOAJPZnqwXa9x TGaQeQtj6oSkTblZYBQh8u+b9eq934n3uE6ZCGB4Wduj8DLc4mFtUFwHHkD79XiIo08ljtpmHGAQ2 6EiDA3ghsGne0rW7O0f9snWwl+JPBUU2LnwmJ8QTPLpKVI0ZeSctGBprBvjrUb7UTZ0HQRZBSQcW/ vSXxB9vHjTEwgTj3vSCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1omt6P-000E12-AD; Mon, 24 Oct 2022 08:46:33 +0000 Received: from mga07.intel.com ([134.134.136.100]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1omt6M-000DzE-E1 for linux-phy@lists.infradead.org; Mon, 24 Oct 2022 08:46:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666601190; x=1698137190; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=zr3WKsPxb7aaiIO0Wjz4+22fObmXP9eCkj8VHh8e+Zw=; b=c5g5heTWLh5OOSy8anaeK/wzc2/G9dNy7bDmSrXuKWrzh2XZcrBFI4JH 1cKhEJh1sZLuJniAcwWDeM+M3cU8jppD4kPmwYGji3Jsx1UhXQyG1Qwye sPuwiVswfiIAO0JtPdj6eZv0+lbDzUWs5XlLsMtiWF3JHI/JfnpGlBYd6 W9ZhxdRX7SmK/PA+DUyvHh+mQ00SZ9PFjE1v3pOUSU9T9fyOv6q59KW2C 31DR3ZMe0P92DTOgzrH6t+B1rkBEJnf4dactISUq/eL1AnP5gwwJQGkCn MKOmxWzag7nmRKJAlKmzj0ugJTWEKP3BXO07HcNnZyXy3EZmZBiWQailz w==; X-IronPort-AV: E=McAfee;i="6500,9779,10509"; a="371587990" X-IronPort-AV: E=Sophos;i="5.95,207,1661842800"; d="scan'208";a="371587990" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 01:46:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10509"; a="773746804" X-IronPort-AV: E=Sophos;i="5.95,207,1661842800"; d="scan'208";a="773746804" Received: from kuha.fi.intel.com ([10.237.72.185]) by fmsmga001.fm.intel.com with SMTP; 24 Oct 2022 01:46:20 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Mon, 24 Oct 2022 11:46:20 +0300 Date: Mon, 24 Oct 2022 11:46:20 +0300 From: Heikki Krogerus To: Felipe Balbi Cc: Wayne Chang , gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, treding@nvidia.com, jonathanh@nvidia.com, thierry.reding@gmail.com, ajayg@nvidia.com, kishon@ti.com, vkoul@kernel.org, p.zabel@pengutronix.de, mathias.nyman@intel.com, jckuo@nvidia.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, singhanc@nvidia.com, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH 06/11] usb: typec: ucsi_ccg: Replace ccgx to well-known regex Message-ID: References: <20221024074128.1113554-1-waynec@nvidia.com> <20221024074128.1113554-7-waynec@nvidia.com> <87czaheiag.fsf@balbi.sh> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87czaheiag.fsf@balbi.sh> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221024_014630_547458_CB3960CC X-CRM114-Status: GOOD ( 21.68 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Mon, Oct 24, 2022 at 11:29:27AM +0300, Felipe Balbi wrote: > Heikki Krogerus writes: > > > On Mon, Oct 24, 2022 at 03:41:23PM +0800, Wayne Chang wrote: > >> ccgx is refer to the cypress cypd4226 typec controller. > >> Replace ccgx to well-known regex "cypress". > >> > >> Signed-off-by: Wayne Chang > >> --- > >> drivers/usb/typec/ucsi/ucsi_ccg.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c > >> index 139707a2f3d6..5d3099e6eb77 100644 > >> --- a/drivers/usb/typec/ucsi/ucsi_ccg.c > >> +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c > >> @@ -1358,7 +1358,7 @@ static int ucsi_ccg_probe(struct i2c_client *client, > >> INIT_WORK(&uc->pm_work, ccg_pm_workaround_work); > >> > >> /* Only fail FW flashing when FW build information is not provided */ > >> - status = device_property_read_u16(dev, "ccgx,firmware-build", > >> + status = device_property_read_u16(dev, "cypress,firmware-build", > >> &uc->fw_build); > >> if (status) > >> dev_err(uc->dev, "failed to get FW build information\n"); > > > > This will break bisectability. You need to first add that > > "cyppress,firmware-build" identifier without removing the old > > "ccgx,firmware-build" identifier, and then introduce a separate > > clean-up patch where you remove it when it's safe to remove: > > > > 1. Add new - This patch. > > 2. Modify users - PATCH 7/11. > > 3. Remove old - *missing*. > > will it ever be safe to remove? What about potential products in the > market with little to no upgrade path? There are likely to be products > with a DTB that will never be updated, no? Not the case here. OF support is only just added to this driver in this series. That old identifier has been used as a build-in property only. thanks, -- heikki -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy