From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5155AECAAA1 for ; Fri, 28 Oct 2022 11:30:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JWvA7fp28M3FcNWFCb6bBvIVgu3crCF8xhTaj/v0Y5Y=; b=wZgZNxi5A7ukHNcPB9ppMIatDi YQYnPPavrg4Klck2U8oj1LwwC+Ie7cJpprriYttNV9hfGO1wm6XQ+D/jSL3inp64lWBje3wcVu8hb 0hL5EVZi5nmlWU0PjFUZ6OHHPkFAuZ/kHJ6lEaxqyBz2T+ggVdbiJ3MFnp8uEFZ8qX8woFo6VVXIL X+8UBWKtheSb3Ge8P6nGmibVZ1KYjb2xQ0+n5u/cefwLGpK+zKRDGFnwkac3KOGU+NYYTFC2WgDKE pGPnW2MslvMc5XBMIGoBd81PRfCosNMiLx0imghcGA3j07LNq4sW5S+2IAZ7cbvwWbAZppcuhbV2s MxMbPtYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ooNZ9-00Gx0u-LH; Fri, 28 Oct 2022 11:30:23 +0000 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ooNZ7-00Gwzj-Lt for linux-phy@lists.infradead.org; Fri, 28 Oct 2022 11:30:23 +0000 Received: by mail-ed1-x52b.google.com with SMTP id a13so7475993edj.0 for ; Fri, 28 Oct 2022 04:30:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=bUajMV/FZ77vjl9lwbZ6ebll6IaBZ9txNULgu7luk0c=; b=V35aEfXkL4i2nEW39sxqEqLq9c3kFAZbvrkGTLPgapAWy5irosIDiEr1KcSremRZx2 17S/VJPuqjyxG6cMBd2FG1kB/1XbQi8JM8/9lf416FgvIPPz8WNFVCvQi0cIkwB+O9uE FHrd9PllBJk0pEESGQLi/zy49AbX0EXND5f7yfEfHTiPUOxq7GLxBstLrkJ/WoZhESe1 FWjZtpMJj/lx/PcYPYaUcwxxtv0v5pWs+u8u9/X9wQttzCFBPGqE2pi5m2vOfVtoZZs8 wHl6NETeCEIl+lGGNH3K2EkiFmECYa2mCJYv70irNCrdpsXRNi37C4YFIBSPapwaM2kA nlwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bUajMV/FZ77vjl9lwbZ6ebll6IaBZ9txNULgu7luk0c=; b=XRZYVZbhHXkJ3U9+klhyIUh020qGG9+HLYnOINnzV1og1LsaM1ZaCiJzHtYCGL0HJK Mvj8favu3RXEusWGy40kIUJ6I4ZRXYkejGHGzmwXmOa3CYN5TvpT9Ngx7Qc0VCuFUA/N /0E+q1vHlIz0/y09yGHWCn1Rtgayqk/n39Gk0T+vUYHUe1wl4CeHXETqE01cmXUWjHfM BWppBq0nZudLzQ5FLLkOWXQ1sRIlZGqoQ42eo9yfi9XgeW5m03UrLzEV/rrtUaVrGLCz nU1SCs5kY7H2w5/qWuH41IZh7RPcioaFIT0RbfTSKuMzzNw0WLM4Gdijrj5JAOZtV/le VpSg== X-Gm-Message-State: ACrzQf1AOaQnnovY0i/Ifa26meJJIHts/6MGnHw0kF9jJSWqOjVVOkX4 zmPgv0Vc0cuc+itBOBn0XYc= X-Google-Smtp-Source: AMsMyM7hAXpqKzHa0WUK4Hxs9UhGHtgO9AD83G2D+y9hWbTPUXY13S6uplP0CcPryl4w1cWe6VA1Kw== X-Received: by 2002:a05:6402:4006:b0:461:f4e2:82e0 with SMTP id d6-20020a056402400600b00461f4e282e0mr20987189eda.68.1666956616920; Fri, 28 Oct 2022 04:30:16 -0700 (PDT) Received: from orome (p200300e41f201d00f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f20:1d00:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id b15-20020a170906d10f00b007abafe43c3bsm2031144ejz.86.2022.10.28.04.30.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 04:30:15 -0700 (PDT) Date: Fri, 28 Oct 2022 13:30:13 +0200 From: Thierry Reding To: Jon Hunter Cc: Krzysztof Kozlowski , Wayne Chang , Rob Herring , "gregkh@linuxfoundation.org" , "krzysztof.kozlowski+dt@linaro.org" , Thierry Reding , "heikki.krogerus@linux.intel.com" , Ajay Gupta , "kishon@ti.com" , "vkoul@kernel.org" , "p.zabel@pengutronix.de" , "balbi@kernel.org" , "mathias.nyman@intel.com" , Jui Chang Kuo , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sing-Han Chen , "linux-i2c@vger.kernel.org" , "linux-phy@lists.infradead.org" , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH 02/11] dt-bindings: usb: Add NVIDIA Tegra XUSB host controller binding Message-ID: References: <20221024074128.1113554-1-waynec@nvidia.com> <20221024074128.1113554-3-waynec@nvidia.com> <20221024145446.GA1763588-robh@kernel.org> <52ae737e-eb4f-9eb7-8b79-d58251062276@nvidia.com> <8194796b-9845-cd02-a542-0bc0d66b4617@nvidia.com> MIME-Version: 1.0 In-Reply-To: <8194796b-9845-cd02-a542-0bc0d66b4617@nvidia.com> User-Agent: Mutt/2.2.7 (2022-08-07) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221028_043021_749482_DE4BFAE7 X-CRM114-Status: GOOD ( 19.68 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0372056559190746346==" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org --===============0372056559190746346== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7Ij0/INtbn8XA1A3" Content-Disposition: inline --7Ij0/INtbn8XA1A3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 28, 2022 at 12:07:38PM +0100, Jon Hunter wrote: >=20 > On 28/10/2022 10:25, Jon Hunter wrote: > >=20 > > On 28/10/2022 03:19, Krzysztof Kozlowski wrote: > > > On 25/10/2022 04:02, Wayne Chang wrote: > > > >=20 > > > > > > +=C2=A0 power-domain-names: > > > > > > +=C2=A0=C2=A0=C2=A0 items: > > > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - const: xusb_host > > > > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - const: xusb_ss > > > > >=20 > > > > > Drop 'xusb_'. > > > >=20 > > > > The properties are constant and we use the name to get the power do= main. > > > >=20 > > > > =C2=A0=C2=A0=C2=A0=C2=A0tegra->genpd_dev_host =3D dev_pm_domain_att= ach_by_name(dev, > > > > "xusb_host"); > > > >=20 > > > > =C2=A0=C2=A0=C2=A0=C2=A0tegra->genpd_dev_ss =3D dev_pm_domain_attac= h_by_name(dev, "xusb_ss"); > > > >=20 > > > > we might not be able to drop the xusb_ > > >=20 > > > These are new bindings, so why do say they are "constant"? New bindin= gs > > > means you did not use them. If you used them before bindings... what = can > > > we say? Don't? > >=20 > > Not exactly. However, what we should do here is convert the legacy > > binding doc [0] and replace with this one. But yes we are stuck with the > > 'xusb_host' naming. >=20 >=20 > Thierry already has a patch to do this [0]. So we should fix that up and > included in this series. >=20 > Jon >=20 > [0] https://lore.kernel.org/linux-tegra/20211209165339.614498-3-thierry.r= eding@gmail.com/ I have a v2 with at least some of the comments addressed. I'll go through them again and send it out. If we can get that reviewed, it can be included in this series and the Tegra234 addition be applied on top. Thierry --7Ij0/INtbn8XA1A3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmNbvUUACgkQ3SOs138+ s6Fa0Q/9EKJnNz9Xf4kL0Qh2galCEt8TqgYwD0b9wPG2Y0qT48Ruux/nxUQsmqAp NNh9qsA8QDQq7dPeyQu98rnPmeiA4QYXI9VEtqxwdwJS4L3S8M+lQSd1SfrWJh7n RJZXVYmiqddCjoVbNpr9BNNgHwzEBy/QmugeQRQl4PadheM1VpF1CGocd1x7sI30 aIjMmjO8yzVyfj9WHNoiWq+IjiByk9Yrgnrs18JjWR/6vFD9lBxIUqSKEbap9Fck HqiPKdF4Bi8Ha0Xa5Ztp49L86UkWlKa7/162BKPaxS27XpFYBmQaCb8ZA7ZFjLCH v7u7KsxscMEac7riJwV2KEZGQLyqtI6M8eSlBCPR/7Ra6utKCxQeCqd4EIR52bij pYiFQgFJCwK5gLfLUoFarfhcmZ2TMpiAPU8bt4Erp6qrC3GA/gV66LLAXuDGkR64 n8u5ARPNC+WztYokhWpctiujRBOa8VWrK8wPQhM+Ng3lJbKWEJwG0/4/ZWQFTljQ GVErNKlx9f0sBgbh/qWTa9geGJI9hhFp77es5u4r0rymFr8vd7+EnZjwBp1BzQqJ yFyL8rWkJ6j8tPZBqC63+QTBuTHS5XludSuSvzuGS3fAIgvcNuhAS6mAoQuL5ZI9 7Q8voktDR5a94kkLK0qQYjFewCCcjqrk+BoZNWbBbP/wxpsSaBE= =pOcc -----END PGP SIGNATURE----- --7Ij0/INtbn8XA1A3-- --===============0372056559190746346== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy --===============0372056559190746346==--