From: Johan Hovold <johan@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org
Subject: Re: [PATCH v6] phy: qcom-qmp-ufs: provide symbol clocks
Date: Sat, 29 Oct 2022 11:24:58 +0200 [thread overview]
Message-ID: <Y1zxamwp7HP03SUx@hovoldconsulting.com> (raw)
In-Reply-To: <Y1zsQN33joDlJRAP@hovoldconsulting.com>
On Sat, Oct 29, 2022 at 11:02:56AM +0200, Johan Hovold wrote:
> On Fri, Oct 28, 2022 at 07:48:47PM +0300, Dmitry Baryshkov wrote:
> > Register three UFS symbol clocks (ufs_rx_symbol_0_clk_src,
> > ufs_rx_symbol_1_clk_src ufs_tx_symbol_0_clk_src). Register OF clock
> > provider to let other devices link these clocks through the DT.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > static int qmp_ufs_parse_dt_legacy(struct qmp_ufs *qmp, struct device_node *np)
> > {
> > struct platform_device *pdev = to_platform_device(qmp->dev);
> > @@ -1135,6 +1195,13 @@ static int qmp_ufs_probe(struct platform_device *pdev)
> > if (ret)
> > goto err_node_put;
> >
> > + ret = phy_symbols_clk_register(qmp, np);
>
> Looks like this should go in probe() instead, or was there a reason for
> not registering these clocks when using the new bindings?
Oops, misread the diff. Please ignore this bit.
> And don't they need to be described in both the old and new bindings
> first either way?
This still applies though (i.e. you need to add #clock-cells to
the bindings).
> > + if (ret) {
> > + dev_err(dev, "failed to create symbol clocks, %d\n",
> > + ret);
>
> Please use the "...: %d\n" form for consistency.
>
> But you can probably just drop this error message instead.
>
> > + goto err_node_put;
> > + }
> > +
> > qmp->phy = devm_phy_create(dev, np, &qcom_qmp_ufs_phy_ops);
> > if (IS_ERR(qmp->phy)) {
> > ret = PTR_ERR(qmp->phy);
Johan
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2022-10-29 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 16:48 [PATCH v6] phy: qcom-qmp-ufs: provide symbol clocks Dmitry Baryshkov
2022-10-29 9:02 ` Johan Hovold
2022-10-29 9:24 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1zxamwp7HP03SUx@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).