From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 280BDC54EBD for ; Fri, 13 Jan 2023 15:21:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uRHJ2MpksMnTavBpJBuNx4rBW8FDAH8Tn+RWLUPbvMY=; b=m40BR13eU//ByH 6M354CYMNoT1lT7ab7aiw+Bwk9ex520Fqs1U713Wbca6YecRcuCn4Hx/QN0w1T53kQUJkUbuO4xiM vzz92Bdh9275iOBY94pCBkGc4veC6xHM+Ebc/b4NrVfbDmKAWaA2KUJttrZOr58+crZzo7v+PvHfC N8eIQJsPfoudyaxc6KUeVDw2BP7QeM9kBRXwl2B1yzpH2o9tFiLhUdb+19KckNse+265xfdPKU5FK /AJAUzsOFJTOlwSWbwRF7id0jZtvBwcD6/BAJhfOSIodFqGCEzdbGXy9HEYa4Fp87CMMxl4gWJOjA Ds8RsUQZCIWJiutkLvWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGLsO-003Apm-JJ; Fri, 13 Jan 2023 15:21:52 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGLsM-003Aog-1N for linux-phy@lists.infradead.org; Fri, 13 Jan 2023 15:21:51 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4AAA1B820CC; Fri, 13 Jan 2023 15:21:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABBBBC433D2; Fri, 13 Jan 2023 15:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673623306; bh=SY8pBPoQTNbHRLf2rJIor5xp42/a0AI7mV21kU2mDAM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tr0kONao44o0PAxUUqzdkC7Xdl9HnbfzeGE0G8LbsgDuEc1wnhtuc/82b4efJZo0H DxstI4zxh7FECHxv+PACaJlhSYUDuHnihXxVvzvserY8g+qIpUH8qroR5y7hWCub3E VD1JYg+eI8FAVC14bYPo/VJ3yrxJaGvkX0v6WcomuxMM/Q7KxNXAZie88cA8spD4et f9AQ1yx0zlXMs1YjGzeQGZktJtA5PlVR45iL1lP3Muqw68Un/KgL634GLaVF6gGeLI XY3cvWi3AzzbIxHug7qtdvob4gsVcUUBfRzNijseS/Lfl5nyTLxV4Z7ByvULedAksQ HuSM7bBpLqAqg== Date: Fri, 13 Jan 2023 16:21:38 +0100 From: Lorenzo Pieralisi To: Vidya Sagar Cc: robh@kernel.org, kw@linux.com, bhelgaas@google.com, thierry.reding@gmail.com, jonathanh@nvidia.com, kishon@ti.com, vkoul@kernel.org, mani@kernel.org, Sergey.Semin@baikalelectronics.ru, ffclaire1224@gmail.com, linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com Subject: Re: [PATCH V3 11/21] PCI: tegra194: Remove IRQF_ONESHOT flag during Endpoint interrupt registration Message-ID: References: <20221013183854.21087-1-vidyas@nvidia.com> <20221013183854.21087-12-vidyas@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221013183854.21087-12-vidyas@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230113_072150_248418_2F636F94 X-CRM114-Status: GOOD ( 19.15 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Fri, Oct 14, 2022 at 12:08:44AM +0530, Vidya Sagar wrote: > Tegra PCIe endpoint has a common interrupt that notifies hardware events > like link up, LTR send, etc. DMA completion event is also notified over > this interrupt. Remove IRQF_ONESHOT flag from interrupt registration and > allow DMA driver to share this interrupt. I don't understand the rationale behind this change, please elaborate on it. Thanks, Lorenzo > Signed-off-by: Vidya Sagar > --- > V3: > * This is a new patch in this series > > drivers/pci/controller/dwc/pcie-tegra194.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c > index 7820bf4b9786..786e5d5f43b9 100644 > --- a/drivers/pci/controller/dwc/pcie-tegra194.c > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c > @@ -2354,7 +2354,7 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev) > ret = devm_request_threaded_irq(dev, pp->irq, > tegra_pcie_ep_hard_irq, > tegra_pcie_ep_irq_thread, > - IRQF_SHARED | IRQF_ONESHOT, > + IRQF_SHARED, > "tegra-pcie-ep-intr", pcie); > if (ret) { > dev_err(dev, "Failed to request IRQ %d: %d\n", pp->irq, > -- > 2.17.1 > > > -- > linux-phy mailing list > linux-phy@lists.infradead.org > https://lists.infradead.org/mailman/listinfo/linux-phy -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy