From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00D05C433B4 for ; Wed, 31 Mar 2021 16:52:11 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 983D46101A for ; Wed, 31 Mar 2021 16:52:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 983D46101A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L65FsNSsPDTQZR5Rl8deau2q50Swm5+njLuC1jxzQmU=; b=HiPUuqpvh8Ap48Lqd/uwV9Q15 Ehta/PXgljXARAhM7nqJGjkqe+YLlzf67rs9+s924hQWUcJtyxHCWzkjLp6kffAtU0C1EBnYEOK9X qnoNaI/tpX2GRkgDEVc6cJXbxYwow0ufUoSnnq1pfOl5B5tD8zoTcE8q05Wl7VJlsFM0c+uOvGh6M ZnWBtnaXWV9pnb5hsJq+wGoZbXMRtfiuClxHvJMKw5lImIixPIiEAKrQAFc1bn4ost1vg/BH8xtqF nLPEMr6RTQx6c/kHeqgClzYIGZsPUicu9A418WpYHicTAaOXrzcyi0Lk6vB3vpMA/AAq+kJvHL/wE qEceHg8HA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRe4f-0078Zh-1t; Wed, 31 Mar 2021 16:52:09 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRe4b-0078ZC-9a for linux-phy@lists.infradead.org; Wed, 31 Mar 2021 16:52:07 +0000 Received: by mail-ed1-x531.google.com with SMTP id y6so23140320eds.1 for ; Wed, 31 Mar 2021 09:52:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QI61i+YGQZg/rOGur7W2OQBCKZffoB8fKnSvTJNTWio=; b=dEbfrdtC/bd2hbGbCet/rWeOhyg9c8Bq7nocWWyIMwNFj4EwLM32nC/gRkwidH5mYq Vz5xe8LJTKFCMd0zwYwbn6UorQxl8ZgGBNowd8e8xHEU1XfU0JvSiPhAqUkcLah/qv1h z2DgKEJFXI1+QxtVWzP9v1keN9dUCJGV1xFMQ/RZZDcMP1Wp34KhWeqWlaDjVUpJBADk 6gUUIkmq5YJgAKT9Dp9exGWEiWEvIYFHTGvPg+fygScTtjTMDNveJA3NDOhfARYEz1Wh Oy18CY5HeW38M4k4nKb5jiVtBSWslARGSVnC8+jmjq+qE/2Y6KXDeJoSYBrDejoP3MEO cenQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QI61i+YGQZg/rOGur7W2OQBCKZffoB8fKnSvTJNTWio=; b=CaEsL0DGET737ni7XWntdOoDLT0Jqyn21vkNhNL1r4+ye/m/0hQLoMiyQHuBEk2f/5 vuiQ6ZQoUk9Q5diI/20VwX0loG5U/S0n82Nb4T4PeWnIU7q9hFIEIxoHi0jvbbkeQho0 UCY+ryq8O6vZPuJqPbZfRms0MYDFrZwpbwtNlLS5muTVyeRyQBmGtW8bzLviJhydtxgw B5EwtCpHPtcVapmpXqt2/Rf97lL/pax1odIBJImAJIVXASbetmr0Umc646LbtZqViA4Q LVHy3VsmB2iu+BkbY3TGySDNuTTUmExTbr7bhPpbfFMQBssHJv1X/qF2/L8TxIrmEZnF sdeA== X-Gm-Message-State: AOAM530SOJFcwOK5+rj/dy2shEosLhNqyIy0GIHA7FOuYTsZ2NhMqxHq 03D37zrN3Sf4ZD87tZgpzEk= X-Google-Smtp-Source: ABdhPJy1SfH3I7WnDBejP2YIkk5cIL8Hn5SZ3RJXK7eYsvFJiY/7k87Ee6t9pbfHnaSVVB2VLp1vKw== X-Received: by 2002:a05:6402:3075:: with SMTP id bs21mr4937264edb.274.1617209524762; Wed, 31 Mar 2021 09:52:04 -0700 (PDT) Received: from localhost ([62.96.65.119]) by smtp.gmail.com with ESMTPSA id m9sm1501878ejo.65.2021.03.31.09.52.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Mar 2021 09:52:03 -0700 (PDT) Date: Wed, 31 Mar 2021 18:52:30 +0200 From: Thierry Reding To: Vinod Koul Cc: Greg Kroah-Hartman , Kishon Vijay Abraham I , Mathias Nyman , JC Kuo , Jon Hunter , linux-tegra@vger.kernel.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v8 06/13] phy: tegra: xusb: Add sleepwalk and suspend/resume Message-ID: References: <20210325164057.793954-1-thierry.reding@gmail.com> <20210325164057.793954-7-thierry.reding@gmail.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.6 (98f8cb83) (2021-03-06) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210331_175205_471712_3A7836CF X-CRM114-Status: GOOD ( 25.96 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6213715341011613860==" Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org --===============6213715341011613860== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oz7Uv6hgLjOVeWjW" Content-Disposition: inline --oz7Uv6hgLjOVeWjW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 31, 2021 at 06:45:25PM +0200, Thierry Reding wrote: > On Wed, Mar 31, 2021 at 06:38:39PM +0200, Thierry Reding wrote: > > On Tue, Mar 30, 2021 at 07:53:32PM +0530, Vinod Koul wrote: > > > On 25-03-21, 17:40, Thierry Reding wrote: > > > > From: JC Kuo > > > >=20 > > > > This commit adds sleepwalk/wake and suspend/resume interfaces > > > > to Tegra XUSB PHY driver. > > > >=20 > > > > Tegra XUSB host controller driver makes use of sleepwalk functions > > > > to enable/disable sleepwalk circuit which is in always-on partition > > > > and can respond to USB resume signals when controller is not powere= d. > > > > Sleepwalk can be enabled/disabled for any USB UPHY individually. > > > >=20 > > > > - tegra_xusb_padctl_enable_phy_sleepwalk() > > > > - tegra_xusb_padctl_disable_phy_sleepwalk() > > > >=20 > > > > Tegra XUSB host controller driver makes use of wake functions to > > > > enable/disable/query wake circuit which is in always-on partition > > > > can wake system up when USB resume happens. > > > > Wake circuit can be enabled/disabled for any USB PHY individually. > > > >=20 > > > > - tegra_xusb_padctl_enable_phy_wake() > > > > - tegra_xusb_padctl_disable_phy_wake() > > > > - tegra_xusb_padctl_remote_wake_detected() > > > >=20 > > > > This commit also adds two system suspend stubs that can be used to > > > > save and restore XUSB PADCTL context during system suspend and > > > > resume. > > > > - tegra_xusb_padctl_suspend_noirq() > > > > - tegra_xusb_padctl_resume_noirq() > > >=20 > > > Acked-By: Vinod Koul > >=20 > > Thanks. I didn't see an Acked-by on patches 7-9. Did I miss them or did > > you not get around to that yet? >=20 > Patch 10 is also missing an Acked-by, I think. Hang on, I've mixed these up. Patches 7 and 8 were for soc/tegra and dt-bindings, respectively. Patches 9-11 were for the PHY subsystem, so you may have missed them because they were not contiguous within the series. The reason is that patch 9 depends on patch 7, though in retrospect it might have been clearer to put 7 and 8 before the whole set of the PHY patches. Apologies for that. Could you take a look at 9 through 11? 9 and 11 are pretty big, but it's really just the Tegra210 and Tegra186 specific implementations of the functionality introduced in this patch. I've also fixed up the modular build error that Nathan had pointed out on patch 9. Let me know if you want me to resend that. Thierry --oz7Uv6hgLjOVeWjW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmBkqM4ACgkQ3SOs138+ s6Ggcg/+PEk5uTnt53AIaPASPXvcYZBQnuTclyF2LZMMtT/EHpJyH171HQFICwlg xvsBhbe9jvzIEf4zS03Kodgb4PsvyvY0yY44RRW+GMOG4WcWkxgSO+aWWfL0cOhI Rf/3EJ9uBVhUzxWNymKVG4D2mCwv5Q31j/HTXv3OLqJq5j/xUcrQruv2QqENiYEE kyAKeCekPGuipAIzJZKv6o82BA2b3hGxjEjbpFt94uXMfOy6JoDPhBzP0W+kYOY+ LN7qpB1PIS4SIv6OFhGNyNpQWijL+LQkQPpAnWbmEZj1UHKAvJLpBpAgmeh6MhSt QQS8Q8TSijqcXLvYFdaKgWXl2hC6wVOGA9CX0QU4w4Rke0Y2YGhEKb7NjyEnMUfN K6nAz/oJno8VAeeKGdOuJefpDE8ztClMgxrBBP7zAtVfQHtEXS2vcJa+sF8HoPkH hm0go0rhrDbQX4qJJDTrsS0xvl57keuhUjsxLXCgczUz/NIeHqFJNvX691lf99RO V/vUvmK0gdg3MJRoVruWZb/4PbLhnaGb2opvptgmSJqpLL5FGD76ONLE/74CS+Kw b1qyHPwWF7tQBzHJXRl1buIdaAdKn7GQmPI5hiaHB9dF+Q/2lNnO6vGZlNw8U/z5 Y6hqGCF4ytslmlsyM9X7nZGQU1AC13XIL0g+KVKdCkn+K5qhGME= =A3Pf -----END PGP SIGNATURE----- --oz7Uv6hgLjOVeWjW-- --===============6213715341011613860== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy --===============6213715341011613860==--