From: Vinod Koul <vkoul@kernel.org>
To: Shixin Liu <liushixin2@huawei.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] phy: ti: j721e-wiz: Add missing include linux/slab.h
Date: Mon, 12 Apr 2021 10:35:34 +0530 [thread overview]
Message-ID: <YHPVHkayrZFAsq+X@vkoul-mobl.Dlink> (raw)
In-Reply-To: <20210408012829.432938-1-liushixin2@huawei.com>
On 08-04-21, 09:28, Shixin Liu wrote:
> When compiling with CONFIG_PHY_J721E_WIZ, Hulk Robot reported:
>
> drivers/phy/ti/phy-j721e-wiz.c: In function ‘wiz_mux_clk_register’:
> drivers/phy/ti/phy-j721e-wiz.c:659:17: error: implicit declaration of function ‘kzalloc’; did you mean ‘vzalloc’? [-Werror=implicit-function-declaration]
> 659 | parent_names = kzalloc((sizeof(char *) * num_parents), GFP_KERNEL);
> | ^~~~~~~
> | vzalloc
> drivers/phy/ti/phy-j721e-wiz.c:659:15: warning: assignment to ‘const char **’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
> 659 | parent_names = kzalloc((sizeof(char *) * num_parents), GFP_KERNEL);
> | ^
> drivers/phy/ti/phy-j721e-wiz.c:697:2: error: implicit declaration of function ‘kfree’; did you mean ‘vfree’? [-Werror=implicit-function-declaration]
> 697 | kfree(parent_names);
> | ^~~~~
> | vfre
Applied, thanks
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2021-04-12 5:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 1:28 [PATCH -next] phy: ti: j721e-wiz: Add missing include linux/slab.h Shixin Liu
2021-04-12 5:05 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHPVHkayrZFAsq+X@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=liushixin2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox