Re: [PATCH v2 0/6] arm64: IPQ6018 PCIe support

Lorenzo Pieralisi
2021-08-05T09:43:51Z

On Thu, Aug 05, 2021 at 09:58:57AM +0300, Baruch Siach wrote:
> Hi Lorenzo, Rob, Krzysztof,
>
> On Wed, May 05 2021, Baruch Siach wrote:
> > This series adds support for the single PCIe lane on IPQ6018 SoCs. The code is
> > ported from downstream Codeaurora v5.4 kernel. The main difference from
> > downstream code is the split of PCIe registers configuration from .init to
> > .post_init, since it requires phy_power_on().
> >
> > Tested on IPQ6010 based hardware.
>
> It's been 3 months with no comment. Would you consider applying the dwc
> part (patches #1 and #2) for the v5.15 merge window?
>
> I tested the patches here successfully on top of v5.14-rc4.

You need an ACK from the respective drivers maintainers. We look into
overall pci/controller drivers structure and common code, it is up
to drivers maintainers to review and ACK your patches, I will certainly
pick them up when that's done.

Thanks,
Lorenzo

> Thanks,
> baruch
>
> >
> > Changes in v2:
> >
> > * Add patch moving GEN3_RELATED macros to a common header
> >
> > * Drop ATU configuration from pcie-qcom
> >
> > * Remove local definition of common registers
> >
> > * Use bulk clk and reset APIs
> >
> > * Remove msi-parent from device-tree
> >
> > Baruch Siach (3):
> > PCI: dwc: tegra: move GEN3_RELATED DBI register to common header
> > dt-bindings: phy: qcom,qmp: Add IPQ60xx PCIe PHY bindings
> > dt-bindings: pci: qcom: Document PCIe bindings for IPQ6018 SoC
> >
> > Selvam Sathappan Periakaruppan (3):
> > PCI: qcom: add support for IPQ60xx PCIe controller
> > phy: qcom-qmp: add QMP V2 PCIe PHY support for ipq60xx
> > arm64: dts: ipq6018: Add pcie support
> >
> > .../devicetree/bindings/pci/qcom,pcie.txt | 24 +++
> > .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 25 +++
> > arch/arm64/boot/dts/qcom/ipq6018.dtsi | 99 ++++++++++++
> > drivers/pci/controller/dwc/pcie-designware.h | 7 +
> > drivers/pci/controller/dwc/pcie-qcom.c | 150 ++++++++++++++++++
> > drivers/pci/controller/dwc/pcie-tegra194.c | 6 -
> > drivers/phy/qualcomm/phy-qcom-qmp.c | 147 +++++++++++++++++
> > drivers/phy/qualcomm/phy-qcom-qmp.h | 132 +++++++++++++++
> > 8 files changed, 584 insertions(+), 6 deletions(-)
>
>
> --
> ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -