Re: [PATCH 19/22] soc: sunxi: mbus: Add A31 ISP compatibles to the list

Samuel Holland
2021-09-11T02:37:06Z

On 9/10/21 1:41 PM, Paul Kocialkowski wrote:
> The A31 ISP sits on the mbus and requires the usual bus address
> adaptation. Add its compatibles to the list.

My understanding is that this driver only exists to work around old DT
bindings where the interconnects/interconnect-names = "dma-mem"
properties are not required (and so they are historically missing from
the device trees).

For new bindings, it would be better to use those properties and not add
to this list.

Regards,
Samuel

> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> ---
> drivers/soc/sunxi/sunxi_mbus.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/soc/sunxi/sunxi_mbus.c b/drivers/soc/sunxi/sunxi_mbus.c
> index d90e4a264b6f..7f0079ea30b1 100644
> --- a/drivers/soc/sunxi/sunxi_mbus.c
> +++ b/drivers/soc/sunxi/sunxi_mbus.c
> @@ -37,6 +37,7 @@ static const char * const sunxi_mbus_devices[] = {
> "allwinner,sun5i-a13-video-engine",
> "allwinner,sun6i-a31-csi",
> "allwinner,sun6i-a31-display-backend",
> + "allwinner,sun6i-a31-isp",
> "allwinner,sun7i-a20-csi0",
> "allwinner,sun7i-a20-display-backend",
> "allwinner,sun7i-a20-display-frontend",
> @@ -50,6 +51,7 @@ static const char * const sunxi_mbus_devices[] = {
> "allwinner,sun8i-h3-csi",
> "allwinner,sun8i-h3-video-engine",
> "allwinner,sun8i-v3s-csi",
> + "allwinner,sun8i-v3s-isp",
> "allwinner,sun9i-a80-display-backend",
> "allwinner,sun50i-a64-csi",
> "allwinner,sun50i-a64-video-engine",