From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org
Subject: Re: [PATCH] phy: qcom-qmp: another fix for the sc8180x PCIe definition
Date: Wed, 20 Oct 2021 10:38:59 -0700 [thread overview]
Message-ID: <YXBUM/SrGHWonh48@ripper> (raw)
In-Reply-To: <20211020155604.1374530-1-dmitry.baryshkov@linaro.org>
On Wed 20 Oct 08:56 PDT 2021, Dmitry Baryshkov wrote:
> Commit f839f14e24f2 ("phy: qcom-qmp: Add sc8180x PCIe support") added
> SC8180X PCIe tables, but used sm8250_qmp_pcie_serdes_tbl as a serdes
> table because of the copy paste error. Commit bfccd9a71a08 ("phy:
> qcom-qmp: Fix sc8180x PCIe definition") corrected part of this mistake
> by pointing serdes_tbl to sc8180x_qmp_pcie_serdes_tbl, however the
> serdes_tbl_num field was not updated to use sc8180x table. So let's now
> fix the serdes_tbl_num field too.
>
> Fixes: bfccd9a71a08 ("phy: qcom-qmp: Fix sc8180x PCIe definition")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Damn it...my eyes doesn't like these solid chunks of text.
Thanks Dmitry.
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/phy/qualcomm/phy-qcom-qmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
> index f14032170b1c..06b04606dd7e 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -3632,7 +3632,7 @@ static const struct qmp_phy_cfg sc8180x_pciephy_cfg = {
> .nlanes = 1,
>
> .serdes_tbl = sc8180x_qmp_pcie_serdes_tbl,
> - .serdes_tbl_num = ARRAY_SIZE(sm8250_qmp_pcie_serdes_tbl),
> + .serdes_tbl_num = ARRAY_SIZE(sc8180x_qmp_pcie_serdes_tbl),
> .tx_tbl = sc8180x_qmp_pcie_tx_tbl,
> .tx_tbl_num = ARRAY_SIZE(sc8180x_qmp_pcie_tx_tbl),
> .rx_tbl = sc8180x_qmp_pcie_rx_tbl,
> --
> 2.33.0
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-10-20 17:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 15:56 [PATCH] phy: qcom-qmp: another fix for the sc8180x PCIe definition Dmitry Baryshkov
2021-10-20 17:38 ` Bjorn Andersson [this message]
2021-10-21 6:09 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXBUM/SrGHWonh48@ripper \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).