From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-phy@lists.infradead.org, Andy Gross <agross@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] phy: qualcomm: qmp: Add missing struct documentation
Date: Wed, 17 Nov 2021 18:19:28 -0600 [thread overview]
Message-ID: <YZWcEBcJ9/ghbgTP@yoga> (raw)
In-Reply-To: <20211116103951.34482-3-vkoul@kernel.org>
On Tue 16 Nov 04:39 CST 2021, Vinod Koul wrote:
> dp-* members were added to qmp_phy_combo_cfg but documentation was
> missed, so add that.
>
> drivers/phy/qualcomm/phy-qcom-qmp.c:2995: warning: Function parameter or member 'dp_aux_cfg' not described in 'qmp_phy'
> drivers/phy/qualcomm/phy-qcom-qmp.c:2995: warning: Function parameter or member 'dp_opts' not described in 'qmp_phy'
> drivers/phy/qualcomm/phy-qcom-qmp.c:2995: warning: Function parameter or member 'dp_clks' not described in 'qmp_phy'
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
> index 456a59d8c7d0..c96639d5f581 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -2973,6 +2973,9 @@ struct qmp_phy_combo_cfg {
> * @qmp: QMP phy to which this lane belongs
> * @lane_rst: lane's reset controller
> * @mode: current PHY mode
> + * @dp_aux_cfg: Display port aux config
> + * @dp_opts: Display port optional config
> + * @dp_clks: Display port clocks
> */
> struct qmp_phy {
> struct phy *phy;
> --
> 2.31.1
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-11-18 0:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 10:39 [PATCH 1/6] phy: mvebu-cp110-utmi: Fix kernel-doc warns Vinod Koul
2021-11-16 10:39 ` [PATCH 2/6] phy: qualcomm: ipq806x-usb: Fix kernel-doc style Vinod Koul
2021-11-16 23:38 ` Randy Dunlap
2021-11-18 0:18 ` Bjorn Andersson
2021-11-20 6:00 ` Vinod Koul
2021-11-16 10:39 ` [PATCH 3/6] phy: qualcomm: qmp: Add missing struct documentation Vinod Koul
2021-11-18 0:19 ` Bjorn Andersson [this message]
2021-11-16 10:39 ` [PATCH 4/6] phy: qualcomm: usb-hsic: Fix the kernel-doc warn Vinod Koul
2021-11-18 0:20 ` Bjorn Andersson
2021-11-16 10:39 ` [PATCH 5/6] phy: ti: omap-usb2: Fix the kernel-doc style Vinod Koul
2021-11-16 16:43 ` Liam Beguin
2021-11-20 17:10 ` Liam Beguin
2021-11-16 10:39 ` [PATCH 6/6] phy: ti: tusb1210: Fix the kernel-doc warn Vinod Koul
2021-11-16 16:39 ` Liam Beguin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZWcEBcJ9/ghbgTP@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).