From: Rob Herring <robh@kernel.org>
To: Aswath Govindraju <a-govindraju@ti.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
linux-can@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: phy: ti,tcan104x-can: Document mux-states property
Date: Mon, 13 Dec 2021 14:19:49 -0600 [thread overview]
Message-ID: <Ybeq5dNYjN4GOzdV@robh.at.kernel.org> (raw)
In-Reply-To: <20211202131002.12217-2-a-govindraju@ti.com>
On Thu, Dec 02, 2021 at 06:40:01PM +0530, Aswath Govindraju wrote:
> On some boards, for routing CAN signals from controller to transceivers,
> muxes might need to be set. This can be implemented using mux-states
> property. Therefore, document the same in the respective bindings.
>
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
> ---
> .../devicetree/bindings/phy/ti,tcan104x-can.yaml | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> index 6107880e5246..5b2b08016635 100644
> --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> @@ -37,6 +37,18 @@ properties:
> max bit rate supported in bps
> minimum: 1
>
> + mux-states:
> + description:
> + mux controller node to route the signals from controller to
> + transceiver. Depending on the mux chip and the control lines
> + in it, the first and second parameters can be used for
> + representing control line and state. The number of arguments
> + is to be used based on '#mux-state-cells' property in the
> + mux-controller node. If '#mux-state-cells' is equal to
> + one then, then the argument to be used would be the state.
> + If it is set to two, then the first argument is the control
> + line and the second argument would be its corresponding state.
No need to redefine how a common property works here. What you do need
to define is how many entries and what they are for if more than 1.
Rob
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-12-13 20:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 13:10 [PATCH 0/2] CAN: Add support for setting mux Aswath Govindraju
2021-12-02 13:10 ` [PATCH 1/2] dt-bindings: phy: ti, tcan104x-can: Document mux-states property Aswath Govindraju
2021-12-13 20:19 ` Rob Herring [this message]
2021-12-14 3:46 ` [PATCH 1/2] dt-bindings: phy: ti,tcan104x-can: " Aswath Govindraju
2021-12-02 13:10 ` [PATCH 2/2] phy: phy-can-transceiver: Add support for setting mux Aswath Govindraju
2021-12-14 7:32 ` Vinod Koul
2021-12-14 14:31 ` [PATCH 0/2] CAN: " Aswath Govindraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybeq5dNYjN4GOzdV@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=a-govindraju@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mkl@pengutronix.de \
--cc=vkoul@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).