From: Vinod Koul <vkoul@kernel.org>
To: Hongxing Zhu <hongxing.zhu@nxp.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] phy: freescale: pcie: explictly add bitfield.h
Date: Wed, 15 Dec 2021 20:51:39 +0530 [thread overview]
Message-ID: <YboIAzhMrUYS09As@matsya> (raw)
In-Reply-To: <AS8PR04MB86765D95A0E42CED2C5D9B4D8C769@AS8PR04MB8676.eurprd04.prod.outlook.com>
On 15-12-21, 06:29, Hongxing Zhu wrote:
> > -----Original Message-----
> > From: Vinod Koul <vkoul@kernel.org>
> > Sent: Wednesday, December 15, 2021 2:09 PM
> > To: Kishon Vijay Abraham I <kishon@ti.com>; Hongxing Zhu
> > <hongxing.zhu@nxp.com>
> > Cc: linux-phy@lists.infradead.org; Vinod Koul <vkoul@kernel.org>;
> > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> > kernel test robot <lkp@intel.com>
> > Subject: [PATCH] phy: freescale: pcie: explictly add bitfield.h
> >
> > kernel test robot complains about missing FIELD_PREP, so include
> > bitfield.h for that
> >
> > drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit
> > declaration of function 'FIELD_PREP'
> > [-Werror=implicit-function-declaration]
> > drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit
> > declaration of function 'FIELD_PREP'
> > [-Werror=implicit-function-declaration]
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie
> > standalone phy driver")
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
Thanks for quick review, I have pushed this
> Thanks a lot for your help to fix it.
> And I'm sorry about that I didn't capture this error in my local build and tests.
No worries, Do test on different arch's other than yours
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2021-12-15 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 6:08 [PATCH] phy: freescale: pcie: explictly add bitfield.h Vinod Koul
2021-12-15 6:29 ` Hongxing Zhu
2021-12-15 15:21 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YboIAzhMrUYS09As@matsya \
--to=vkoul@kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).