From: Rob Herring <robh@kernel.org>
To: Peter Geis <pgwipeout@gmail.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Johan Jonker <jbx6244@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org, Heiko Stuebner <heiko@sntech.de>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v3 2/8] dt-bindings: phy: phy-rockchip-inno-usb2: add rk3568 documentation
Date: Thu, 16 Dec 2021 14:31:25 -0600 [thread overview]
Message-ID: <YbuiHfUPezvB01CH@robh.at.kernel.org> (raw)
In-Reply-To: <20211215210252.120923-3-pgwipeout@gmail.com>
On Wed, 15 Dec 2021 16:02:46 -0500, Peter Geis wrote:
> The rk3568 usb2phy node is a standalone node with a single muxed
> interrupt.
> Add documentation for it to phy-rockchip-inno-usb2.
>
> Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> ---
>
> This was the best solution I've come up with for this.
> I avoided creating another binding since this is such a simple change to
> the actual driver and would likely require renaming the existing
> binding.
> I've tested that this correctly flags if the interrupts are missing or
> incorrectly assigned on both rk356x and rk3399.
>
> Thank you Johan and Rob for your constructive feedback.
>
> .../bindings/phy/phy-rockchip-inno-usb2.yaml | 44 +++++++++++++++++--
> 1 file changed, 40 insertions(+), 4 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2021-12-16 20:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 21:02 [PATCH v3 0/8] phy-rockchip-inno-usb2: support rk356x usb2phy Peter Geis
2021-12-15 21:02 ` [PATCH v3 2/8] dt-bindings: phy: phy-rockchip-inno-usb2: add rk3568 documentation Peter Geis
2021-12-16 20:31 ` Rob Herring [this message]
2021-12-15 21:02 ` [PATCH v3 3/8] phy: phy-rockchip-inno-usb2: support #address_cells = 2 Peter Geis
2021-12-15 21:02 ` [PATCH v3 4/8] phy: phy-rockchip-inno-usb2: support standalone phy nodes Peter Geis
2021-12-15 21:02 ` [PATCH v3 5/8] phy: phy-rockchip-inno-usb2: support muxed interrupts Peter Geis
2021-12-15 21:02 ` [PATCH v3 6/8] phy: phy-rockchip-inno-usb2: add rk3568 support Peter Geis
2021-12-23 11:25 ` [PATCH v3 0/8] phy-rockchip-inno-usb2: support rk356x usb2phy Vinod Koul
2021-12-28 0:48 ` (subset) " Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbuiHfUPezvB01CH@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).