From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com,
agross@kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, shawn.guo@linaro.org,
vkoul@kernel.org, linux-phy@lists.infradead.org,
robh+dt@kernel.org, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2 8/8] dt-bindings: phy: qcom,qmp: Mark 'vdda-pll-supply' & 'vdda-phy-supply' as optional
Date: Mon, 28 Feb 2022 21:47:26 -0600 [thread overview]
Message-ID: <Yh2XTjyBICVkn0Jy@yoga> (raw)
In-Reply-To: <20220228123019.382037-9-bhupesh.sharma@linaro.org>
On Mon 28 Feb 06:30 CST 2022, Bhupesh Sharma wrote:
> Fix the following 'make dtbs_check' warnings, by marking the
> 'vdda-pll-supply' & 'vdda-phy-supply' properties as 'optional' in
> 'qcom,qmp-phy' dt-binding:
>
> arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx215.dt.yaml:
> phy-wrapper@88e9000: 'vdda-phy-supply' is a required property
>
> arch/arm64/boot/dts/qcom/sm8350-sony-xperia-sagami-pdx215.dt.yaml:
> phy-wrapper@88e9000: 'vdda-pll-supply' is a required property
>
These two supplies denotes the power for the bus and the clock of the
UFS PHY. As such I think we can expect that if pdx215 has functional UFS
then it has these supplies, and the "bug" is in the dts.
It's probably safe to assume that the two regulators are the same as on
the MTP. So my suggestion is that you just wire them up in the same way
as the MTP; and please Cc Konrad.
PS. This change is unrelated to the rest of the series, please send such
changes alone, because it could have been merged independently of the
rest of the series...
Regards,
Bjorn
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Rob Herring <robh@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
> Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> index f8a43acd229a..82b102b7d42c 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> @@ -436,9 +436,6 @@ allOf:
> items:
> - const: phy
> - const: common
> - required:
> - - vdda-phy-supply
> - - vdda-pll-supply
> - if:
> properties:
> compatible:
> --
> 2.35.1
>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2022-03-01 3:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 12:30 [PATCH v2 0/8] Fix dtbs_check warning(s) for Qualcomm QMP PHY Bhupesh Sharma
2022-02-28 12:30 ` [PATCH v2 1/8] dt-bindings: phy: qcom, qmp: Mark '#clock-cells' as a 'optional' property Bhupesh Sharma
2022-03-01 3:55 ` [PATCH v2 1/8] dt-bindings: phy: qcom,qmp: " Shawn Guo
2022-02-28 12:30 ` [PATCH v2 2/8] dt-bindings: phy: qcom, qmp: Describe 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties Bhupesh Sharma
2022-03-01 4:15 ` [PATCH v2 2/8] dt-bindings: phy: qcom,qmp: " Shawn Guo
2022-03-04 23:58 ` Rob Herring
2022-02-28 12:30 ` [PATCH v2 3/8] arm64: dts: qcom: msm8996-xiaomi: Drop max-microamp and vddp-ref-clk properties from QMP PHY Bhupesh Sharma
2022-03-01 4:22 ` Shawn Guo
2022-02-28 12:30 ` [PATCH v2 4/8] arm64: dts: qcom: sc7280: Fix qmp phy node (use phy@ instead of lanes@) Bhupesh Sharma
2022-03-01 4:09 ` Shawn Guo
2022-02-28 12:30 ` [PATCH v2 5/8] arm64: dts: qcom: sm8450: Fix qmp ufs " Bhupesh Sharma
2022-03-01 4:10 ` Shawn Guo
2022-02-28 12:30 ` [PATCH v2 6/8] arm64: dts: qcom: ipq6018: Fix qmp usb3 phy node Bhupesh Sharma
2022-03-01 4:11 ` Shawn Guo
2022-02-28 12:30 ` [PATCH v2 7/8] dt-bindings: phy: qcom, qmp: Describe phy@ subnode properly Bhupesh Sharma
2022-03-01 4:07 ` Shawn Guo
2022-03-04 23:58 ` Rob Herring
2022-02-28 12:30 ` [PATCH v2 8/8] dt-bindings: phy: qcom, qmp: Mark 'vdda-pll-supply' & 'vdda-phy-supply' as optional Bhupesh Sharma
2022-03-01 3:39 ` [PATCH v2 8/8] dt-bindings: phy: qcom,qmp: " Shawn Guo
2022-03-01 3:47 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh2XTjyBICVkn0Jy@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=bhupesh.sharma@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).