From: Lorenzo Pieralisi <lpieralisi@kernel.org>
To: Hongxing Zhu <hongxing.zhu@nxp.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
"robh@kernel.org" <robh@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"vkoul@kernel.org" <vkoul@kernel.org>,
"alexander.stein@ew.tq-group.com"
<alexander.stein@ew.tq-group.com>,
"marex@denx.de" <marex@denx.de>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v3 1/6] reset: imx7: Add the iMX8MP PCIe PHY PERST support
Date: Mon, 29 Aug 2022 10:10:02 +0200 [thread overview]
Message-ID: <Ywx0WorLvPrXGVt9@lpieralisi> (raw)
In-Reply-To: <AS8PR04MB867626BC5C32AA75466BB9E78C6D9@AS8PR04MB8676.eurprd04.prod.outlook.com>
On Thu, Aug 18, 2022 at 10:53:24AM +0000, Hongxing Zhu wrote:
> > -----Original Message-----
> > From: Philipp Zabel <p.zabel@pengutronix.de>
> > Sent: 2022年8月18日 16:51
> > To: Hongxing Zhu <hongxing.zhu@nxp.com>; l.stach@pengutronix.de;
> > bhelgaas@google.com; lorenzo.pieralisi@arm.com; robh@kernel.org;
> > shawnguo@kernel.org; vkoul@kernel.org; alexander.stein@ew.tq-group.com;
> > marex@denx.de
> > Cc: linux-phy@lists.infradead.org; devicetree@vger.kernel.org;
> > linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > linux-kernel@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx
> > <linux-imx@nxp.com>
> > Subject: Re: [PATCH v3 1/6] reset: imx7: Add the iMX8MP PCIe PHY PERST
> > support
> >
> > Hi Richard,
> >
> > On Do, 2022-08-18 at 15:02 +0800, Richard Zhu wrote:
> > > On i.MX7/iMX8MM/iMX8MQ, the initialized default value of PERST
> > > bit(BIT3) of SRC_PCIEPHY_RCR is 1b'1.
> > > But i.MX8MP has one inversed default value 1b'0 of PERST bit.
> > >
> > > And the PERST bit should be kept 1b'1 after power and clocks are stable.
> > > So add the i.MX8MP PCIe PHY PERST support here.
> >
> > the description is good now. It would be nice if this could also be mentioned in
> > the Reference Manual.
> >
> > Please replace "add" with "fix" in the subject, as I requested earlier:
> > "reset: imx7: Fix i.MX8MP PCIe PHY PERST support".
> >
> > And add a fixes line:
> >
> > Fixes: e08672c03981 ("reset: imx7: Add support for i.MX8MP SoC")
> >
> > With those two changes,
> > Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
> >
> Hi Philipp:
> Okay, would be changed in next version.
AFAICS there is still a pending comment on patch (2) but I will
mark this as "Changes requested" and wait for the next version.
Lorenzo
> Thanks for your review.
>
> Best Regards
> Richard Zhu
>
> > regards
> > Philipp
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-08-29 8:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 7:02 [PATCH v3 0/6] Add the iMX8MP PCIe support Richard Zhu
2022-08-18 7:02 ` [PATCH v3 1/6] reset: imx7: Add the iMX8MP PCIe PHY PERST support Richard Zhu
2022-08-18 8:50 ` Philipp Zabel
2022-08-18 10:53 ` Hongxing Zhu
2022-08-29 8:10 ` Lorenzo Pieralisi [this message]
2022-08-29 8:14 ` Hongxing Zhu
2022-08-18 7:02 ` [PATCH v3 2/6] dt-binding: phy: Add iMX8MP PCIe PHY binding Richard Zhu
2022-08-22 18:07 ` Rob Herring
2022-08-23 2:11 ` Hongxing Zhu
2022-08-24 9:15 ` Hongxing Zhu
2022-08-18 7:02 ` [PATCH v3 3/6] phy: freescale: imx8m-pcie: Add iMX8MP PCIe PHY support Richard Zhu
2022-08-18 7:02 ` [PATCH v3 4/6] arm64: dts: imx8mp: add the iMX8MP PCIe support Richard Zhu
2022-08-18 7:02 ` [PATCH v3 5/6] arm64: dts: imx8mp-evk: Add " Richard Zhu
2022-08-18 7:02 ` [PATCH v3 6/6] PCI: imx6: Add the iMX8MP " Richard Zhu
2022-08-18 9:20 ` [PATCH v3 0/6] " Marek Vasut
2022-08-18 10:53 ` Hongxing Zhu
2022-08-18 11:49 ` Marek Vasut
2022-08-25 12:23 ` Richard Leitner
2022-08-26 1:29 ` Hongxing Zhu
2022-08-26 6:22 ` Alexander Stein
2022-08-26 6:56 ` Hongxing Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ywx0WorLvPrXGVt9@lpieralisi \
--to=lpieralisi@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marex@denx.de \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).