From: Vinod Koul <vkoul@kernel.org>
To: Liang He <windhl@126.com>
Cc: kishon@ti.com, narmstrong@baylibre.com, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
linux-phy@lists.infradead.org
Subject: Re: [PATCH] phy: amlogic: phy-meson-axg-mipi-pcie-analog: Hold reference returned by of_get_parent()
Date: Fri, 2 Sep 2022 21:11:14 +0530 [thread overview]
Message-ID: <YxIkGocG/WuwtI7d@matsya> (raw)
In-Reply-To: <20220705021526.281441-1-windhl@126.com>
On 05-07-22, 10:15, Liang He wrote:
> We should hold the reference returned by of_get_parent() and use it
> to call of_node_put() for reference balance.
And why should we hold and drop reference?
>
> Fixes: 8eff8b4e22d9 ("phy: amlogic: phy-meson-axg-mipi-pcie-analog: add support for MIPI DSI analog")
> Signed-off-by: Liang He <windhl@126.com>
> ---
> drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c b/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c
> index 1027ece6ca12..a3e1108b736d 100644
> --- a/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c
> +++ b/drivers/phy/amlogic/phy-meson-axg-mipi-pcie-analog.c
> @@ -197,7 +197,7 @@ static int phy_axg_mipi_pcie_analog_probe(struct platform_device *pdev)
> struct phy_provider *phy;
> struct device *dev = &pdev->dev;
> struct phy_axg_mipi_pcie_analog_priv *priv;
> - struct device_node *np = dev->of_node;
> + struct device_node *np = dev->of_node, *parent_np;
> struct regmap *map;
> int ret;
>
> @@ -206,7 +206,9 @@ static int phy_axg_mipi_pcie_analog_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> /* Get the hhi system controller node */
> - map = syscon_node_to_regmap(of_get_parent(dev->of_node));
> + parent_np = of_get_parent(dev->of_node);
> + map = syscon_node_to_regmap(parent_np);
> + of_node_put(parent_np);
> if (IS_ERR(map)) {
> dev_err(dev,
> "failed to get HHI regmap\n");
> --
> 2.25.1
>
>
> --
> linux-phy mailing list
> linux-phy@lists.infradead.org
> https://lists.infradead.org/mailman/listinfo/linux-phy
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-09-02 15:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 2:15 [PATCH] phy: amlogic: phy-meson-axg-mipi-pcie-analog: Hold reference returned by of_get_parent() Liang He
2022-07-05 7:21 ` Neil Armstrong
2022-07-25 19:41 ` Martin Blumenstingl
2022-09-02 15:41 ` Vinod Koul [this message]
2022-09-05 7:21 ` Liang He
2022-09-13 13:55 ` Vinod Koul
2022-09-13 15:15 ` Liang He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxIkGocG/WuwtI7d@matsya \
--to=vkoul@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=kishon@ti.com \
--cc=linux-phy@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).