From: Vinod Koul <vkoul@kernel.org>
To: Liang He <windhl@126.com>
Cc: kishon@ti.com, narmstrong@baylibre.com, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
linux-phy@lists.infradead.org
Subject: Re: Re: [PATCH] phy: amlogic: phy-meson-axg-mipi-pcie-analog: Hold reference returned by of_get_parent()
Date: Tue, 13 Sep 2022 19:25:53 +0530 [thread overview]
Message-ID: <YyCL6ajchUlX8q/x@matsya> (raw)
In-Reply-To: <6e6f3989.4cf5.1830c86ff8b.Coremail.windhl@126.com>
On 05-09-22, 15:21, Liang He wrote:
>
>
>
> At 2022-09-02 23:41:14, "Vinod Koul" <vkoul@kernel.org> wrote:
> >On 05-07-22, 10:15, Liang He wrote:
> >> We should hold the reference returned by of_get_parent() and use it
> >> to call of_node_put() for reference balance.
> >
> >And why should we hold and drop reference?
>
> >
> Hi, Vinod Koul,
>
>
> Thanks very much for your review.
>
>
> As the of_get_parent() will increase the refcount of the node->parent and the reference will be discarded
> so we should hold the reference , with which we can decrease the refcount.
Right, that is correct explanation
>
>
> If there is any misunderstanding about the of_get_parent() API, please correct me.
Nope, just that this explanation is missing from the log...
Please add...
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-09-13 13:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 2:15 [PATCH] phy: amlogic: phy-meson-axg-mipi-pcie-analog: Hold reference returned by of_get_parent() Liang He
2022-07-05 7:21 ` Neil Armstrong
2022-07-25 19:41 ` Martin Blumenstingl
2022-09-02 15:41 ` Vinod Koul
2022-09-05 7:21 ` Liang He
2022-09-13 13:55 ` Vinod Koul [this message]
2022-09-13 15:15 ` Re:Re: " Liang He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyCL6ajchUlX8q/x@matsya \
--to=vkoul@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=kishon@ti.com \
--cc=linux-phy@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox