From: Johan Hovold <johan@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: "Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@somainline.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@ti.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
linux-phy@lists.infradead.org,
"Johan Hovold" <johan+linaro@kernel.org>
Subject: Re: [PATCH v6 1/5] phy: qcom-qmp-pcie: split register tables into common and extra parts
Date: Tue, 27 Sep 2022 11:45:40 +0200 [thread overview]
Message-ID: <YzLGRJTQv1/7zPLJ@hovoldconsulting.com> (raw)
In-Reply-To: <20220927092207.161501-2-dmitry.baryshkov@linaro.org>
On Tue, Sep 27, 2022 at 12:22:02PM +0300, Dmitry Baryshkov wrote:
> SM8250 configuration tables are split into two parts: the common one and
> the PHY-specific tables. Make this split more formal. Rather than having
> a blind renamed copy of all QMP table fields, add separate struct
> qmp_phy_cfg_tables and add two instances of this structure to the struct
> qmp_phy_cfg. Later on this will be used to support different PHY modes
> (RC vs EP).
>
> Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> +static void qmp_pcie_pcs_init(struct qmp_phy *qphy, const struct qmp_phy_cfg_tables *tables)
> +{
> + const struct qmp_phy_cfg *cfg = qphy->cfg;
> + void __iomem *pcs = qphy->pcs;
> + void __iomem *pcs_misc = qphy->pcs_misc;
> +
> + if (!tables)
> + return;
> +
> + qmp_pcie_configure(pcs, cfg->regs,
> + tables->pcs, tables->pcs_num);
> + qmp_pcie_configure(pcs_misc, cfg->regs,
> + tables->pcs_misc, tables->pcs_misc_num);
nit: You missed the above unnecessary line breaks.
Johan
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-09-27 9:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 9:22 [PATCH v6 0/5] PCI: qcom: Support using the same PHY for both RC and EP Dmitry Baryshkov
2022-09-27 9:22 ` [PATCH v6 1/5] phy: qcom-qmp-pcie: split register tables into common and extra parts Dmitry Baryshkov
2022-09-27 9:45 ` Johan Hovold [this message]
2022-09-27 9:22 ` [PATCH v6 2/5] phy: qcom-qmp-pcie: support separate tables for EP mode Dmitry Baryshkov
2022-09-27 9:22 ` [PATCH v6 3/5] phy: qcom-qmp-pcie: Support SM8450 PCIe1 PHY in " Dmitry Baryshkov
2022-09-27 9:22 ` [PATCH v6 4/5] PCI: qcom: Setup PHY to work in RC mode Dmitry Baryshkov
2022-09-27 9:37 ` Lorenzo Pieralisi
2022-09-27 9:22 ` [PATCH v6 5/5] PCI: qcom-ep: Setup PHY to work in EP mode Dmitry Baryshkov
2022-09-27 9:37 ` Lorenzo Pieralisi
2022-10-17 7:44 ` [PATCH v6 0/5] PCI: qcom: Support using the same PHY for both RC and EP Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzLGRJTQv1/7zPLJ@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=johan+linaro@kernel.org \
--cc=kishon@ti.com \
--cc=konrad.dybcio@somainline.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).