From: Vinod Koul <vkoul@kernel.org>
To: markus.stockhausen@gmx.de
Cc: kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, chris.packham@alliedtelesis.co.nz
Subject: Re: [PATCH v5 2/2] phy: Realtek Otto SerDes driver
Date: Thu, 10 Apr 2025 19:16:54 +0530 [thread overview]
Message-ID: <Z/fLzpuj13WRe1/0@vaman> (raw)
In-Reply-To: <138401dba84e$04bc0cf0$0e3426d0$@gmx.de>
On 08-04-25, 08:18, markus.stockhausen@gmx.de wrote:
> > Von: Vinod Koul <vkoul@kernel.org>
> > Gesendet: Sonntag, 8. Dezember 2024 17:38
> > An: Markus Stockhausen <markus.stockhausen@gmx.de>
> > Cc: kishon@kernel.org; robh@kernel.org; krzk+dt@kernel.org;
> conor+dt@kernel.org; linux-phy@lists.infradead.org;
> devicetree@vger.kernel.org; chris.packham@alliedtelesis.co.nz
> > Betreff: Re: [PATCH v5 2/2] phy: Realtek Otto SerDes driver
> >
> > On 17-10-24, 12:24, Markus Stockhausen wrote:
> > > The Realtek Otto platform is a series of 4 different MIPS32 based
> > > network switch SoCs. They consist of:
> > >
> > > ....
> > > +DEFINE_SHOW_ATTRIBUTE(rtsds_dbg_polarity);
> > > +
> > > +static void rtsds_dbg_init(struct rtsds_ctrl *ctrl, u32 sid) {
> > > + debugfs_create_file("mode", 0600, ctrl->sds[sid].phy->debugfs,
> > > + &ctrl->sds[sid].phy->dev, &rtsds_dbg_mode_fops);
> > > +
> > > + debugfs_create_file("reset", 0200, ctrl->sds[sid].phy->debugfs,
> > > + &ctrl->sds[sid].phy->dev,
> &rtsds_dbg_reset_fops);
> > > +
> > > + debugfs_create_file("polarity", 0400, ctrl->sds[sid].phy->debugfs,
> > > + &ctrl->sds[sid].phy->dev,
> &rtsds_dbg_polarity_fops);
> > > +
> > > + debugfs_create_file("registers", 0600, ctrl->sds[sid].phy->debugfs,
> > > + &ctrl->sds[sid].phy->dev,
> &rtsds_dbg_registers_fops); }
> >
> > Please create a driver directory and add files to that please
>
> Sorry for the late response as I have been busy otherwise. I will take care
> about the things you noted. Regarding this advise: Do you want me to create
> a separate directory in the debugfs or for the driver source code?
Debugfs please
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2025-04-10 13:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 16:23 [PATCH v5 0/2] phy: Realtek Otto SerDes: add new driver Markus Stockhausen
2024-10-17 16:23 ` [PATCH v5 1/2] dt-bindings: phy: add realtek,rtl8380m-serdes Markus Stockhausen
2024-10-18 6:10 ` Krzysztof Kozlowski
2024-11-19 1:02 ` Chris Packham
2024-10-17 16:24 ` [PATCH v5 2/2] phy: Realtek Otto SerDes driver Markus Stockhausen
2024-11-19 1:02 ` Chris Packham
2024-12-08 16:38 ` Vinod Koul
2025-04-08 6:18 ` AW: " markus.stockhausen
2025-04-10 13:46 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z/fLzpuj13WRe1/0@vaman \
--to=vkoul@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=markus.stockhausen@gmx.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).