linux-phy.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 0/3] Add support for USB controllers on QCS615
@ 2024-12-24  8:46 Krishna Kurapati
  2024-12-24  8:46 ` [PATCH v3 1/3] dt-bindings: usb: qcom,dwc3: Add QCS615 to USB DWC3 bindings Krishna Kurapati
                   ` (3 more replies)
  0 siblings, 4 replies; 15+ messages in thread
From: Krishna Kurapati @ 2024-12-24  8:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Vinod Koul, Kishon Vijay Abraham I, Konrad Dybcio,
	Dmitry Baryshkov, Johan Hovold, Manivannan Sadhasivam,
	Varadarajan Narayanan, Wesley Cheng
  Cc: linux-kernel, linux-arm-msm, linux-phy, linux-usb, devicetree,
	quic_ppratap, quic_jackp, Krishna Kurapati

This series aims at enabling USB on QCS615 which has 2 USB controllers.
The primary controller is SuperSpeed capable and secondary one is
High Speed only capable. The High Speed Phy is a QUSB2 phy and the
SuperSpeed Phy is a QMP Uni Phy which supports non-concurrent DP.

Link to v1:
https://lore.kernel.org/all/20241014084432.3310114-1-quic_kriskura@quicinc.com/

Link to v2:
https://lore.kernel.org/all/20241017130701.3301785-1-quic_kriskura@quicinc.com/

All the patches are acked. But some are merged and some don't apply clean.

Phy bindings have been acked on v1 and have been merged from v1.

The v2 DWC3 binding patch has been acked but conflicts with sar2130 code
and hence v2-patch-1 doesn't apply cleanly.

The QUSB2 phy driver changes in v2 conflict with IPQ changes that went in
recently and hence v2-patch-4 doesn't apply cleanly.

Changes in v3:
Rebase on top of latest linux next to avoid conflicts.
Updated mail ID from quicinc to OSS. So changed the SOBs and retained the
ACKs since the author is still the same.
Updated cover letter heading since the changes are for both ports and DT
for first port is merged and second port is ACKed.

Changes in v2:
Addressed comments in v1 by using lowercase for reg values.
Removed explicitly setting of struct params to false (as they are
already false).

Krishna Kurapati (3):
  dt-bindings: usb: qcom,dwc3: Add QCS615 to USB DWC3 bindings
  phy: qcom-qusb2: Add support for QCS615
  phy: qcom: qmp-usbc: Add qmp configuration for QCS615

 .../devicetree/bindings/usb/qcom,dwc3.yaml    |  3 +++
 drivers/phy/qualcomm/phy-qcom-qmp-usbc.c      |  3 +++
 drivers/phy/qualcomm/phy-qcom-qusb2.c         | 27 +++++++++++++++++++
 3 files changed, 33 insertions(+)

-- 
2.34.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH v3 1/3] dt-bindings: usb: qcom,dwc3: Add QCS615 to USB DWC3 bindings
  2024-12-24  8:46 [PATCH v3 0/3] Add support for USB controllers on QCS615 Krishna Kurapati
@ 2024-12-24  8:46 ` Krishna Kurapati
  2024-12-24  8:46 ` [PATCH v3 2/3] phy: qcom-qusb2: Add support for QCS615 Krishna Kurapati
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 15+ messages in thread
From: Krishna Kurapati @ 2024-12-24  8:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Vinod Koul, Kishon Vijay Abraham I, Konrad Dybcio,
	Dmitry Baryshkov, Johan Hovold, Manivannan Sadhasivam,
	Varadarajan Narayanan, Wesley Cheng
  Cc: linux-kernel, linux-arm-msm, linux-phy, linux-usb, devicetree,
	quic_ppratap, quic_jackp, Krishna Kurapati, Krzysztof Kozlowski

Update dt-bindings to add primary controller of QCS615 to USB
DWC3 controller list.

Although this controller has a QUSB2 Phy, it belongs to a
generation of SoCs like SDM670/SDM845/SM6350 where DP/DM is
used for wakeup instead of qusb2_phy interrupt.

Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
index 98bb82c795d4..8fd02e8aaaa5 100644
--- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
@@ -26,6 +26,7 @@ properties:
           - qcom,msm8998-dwc3
           - qcom,qcm2290-dwc3
           - qcom,qcs404-dwc3
+          - qcom,qcs615-dwc3
           - qcom,qcs8300-dwc3
           - qcom,qdu1000-dwc3
           - qcom,sa8775p-dwc3
@@ -341,6 +342,7 @@ allOf:
           contains:
             enum:
               - qcom,qcm2290-dwc3
+              - qcom,qcs615-dwc3
               - qcom,sar2130p-dwc3
               - qcom,sc8180x-dwc3
               - qcom,sc8180x-dwc3-mp
@@ -471,6 +473,7 @@ allOf:
               - qcom,ipq4019-dwc3
               - qcom,ipq8064-dwc3
               - qcom,msm8994-dwc3
+              - qcom,qcs615-dwc3
               - qcom,qcs8300-dwc3
               - qcom,qdu1000-dwc3
               - qcom,sa8775p-dwc3
-- 
2.34.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH v3 2/3] phy: qcom-qusb2: Add support for QCS615
  2024-12-24  8:46 [PATCH v3 0/3] Add support for USB controllers on QCS615 Krishna Kurapati
  2024-12-24  8:46 ` [PATCH v3 1/3] dt-bindings: usb: qcom,dwc3: Add QCS615 to USB DWC3 bindings Krishna Kurapati
@ 2024-12-24  8:46 ` Krishna Kurapati
  2024-12-24  8:46 ` [PATCH v3 3/3] phy: qcom: qmp-usbc: Add qmp configuration " Krishna Kurapati
  2024-12-24 15:25 ` (subset) [PATCH v3 0/3] Add support for USB controllers on QCS615 Vinod Koul
  3 siblings, 0 replies; 15+ messages in thread
From: Krishna Kurapati @ 2024-12-24  8:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Vinod Koul, Kishon Vijay Abraham I, Konrad Dybcio,
	Dmitry Baryshkov, Johan Hovold, Manivannan Sadhasivam,
	Varadarajan Narayanan, Wesley Cheng
  Cc: linux-kernel, linux-arm-msm, linux-phy, linux-usb, devicetree,
	quic_ppratap, quic_jackp, Krishna Kurapati

Add init sequence and phy configuration for QCS615.

Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 drivers/phy/qualcomm/phy-qcom-qusb2.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c
index 2d8fe9bc40f9..1f5f7df14d5a 100644
--- a/drivers/phy/qualcomm/phy-qcom-qusb2.c
+++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c
@@ -166,6 +166,19 @@ static const struct qusb2_phy_init_tbl ipq5424_init_tbl[] = {
 	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_AUTOPGM_CTL1, 0x9f),
 };
 
+static const struct qusb2_phy_init_tbl qcs615_init_tbl[] = {
+	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE1, 0xc8),
+	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE2, 0xb3),
+	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE3, 0x83),
+	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE4, 0xc0),
+	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_TUNE, 0x30),
+	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_USER_CTL1, 0x79),
+	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_USER_CTL2, 0x21),
+	QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TEST2, 0x14),
+	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_AUTOPGM_CTL1, 0x9f),
+	QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_PWR_CTRL, 0x00),
+};
+
 static const unsigned int ipq6018_regs_layout[] = {
 	[QUSB2PHY_PLL_STATUS]              = 0x38,
 	[QUSB2PHY_PORT_TUNE1]              = 0x80,
@@ -356,6 +369,17 @@ static const struct qusb2_phy_cfg ipq5424_phy_cfg = {
 	.autoresume_en   = BIT(0),
 };
 
+static const struct qusb2_phy_cfg qcs615_phy_cfg = {
+	.tbl            = qcs615_init_tbl,
+	.tbl_num        = ARRAY_SIZE(qcs615_init_tbl),
+	.regs           = ipq6018_regs_layout,
+
+	.disable_ctrl   = (CLAMP_N_EN | FREEZIO_N | POWER_DOWN),
+	.mask_core_ready = PLL_LOCKED,
+	/* autoresume not used */
+	.autoresume_en   = BIT(0),
+};
+
 static const struct qusb2_phy_cfg qusb2_v2_phy_cfg = {
 	.tbl		= qusb2_v2_init_tbl,
 	.tbl_num	= ARRAY_SIZE(qusb2_v2_init_tbl),
@@ -950,6 +974,9 @@ static const struct of_device_id qusb2_phy_of_match_table[] = {
 	}, {
 		.compatible	= "qcom,msm8998-qusb2-phy",
 		.data		= &msm8998_phy_cfg,
+	}, {
+		.compatible	= "qcom,qcs615-qusb2-phy",
+		.data		= &qcs615_phy_cfg,
 	}, {
 		.compatible	= "qcom,qcm2290-qusb2-phy",
 		.data		= &sm6115_phy_cfg,
-- 
2.34.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH v3 3/3] phy: qcom: qmp-usbc: Add qmp configuration for QCS615
  2024-12-24  8:46 [PATCH v3 0/3] Add support for USB controllers on QCS615 Krishna Kurapati
  2024-12-24  8:46 ` [PATCH v3 1/3] dt-bindings: usb: qcom,dwc3: Add QCS615 to USB DWC3 bindings Krishna Kurapati
  2024-12-24  8:46 ` [PATCH v3 2/3] phy: qcom-qusb2: Add support for QCS615 Krishna Kurapati
@ 2024-12-24  8:46 ` Krishna Kurapati
  2024-12-24 15:25 ` (subset) [PATCH v3 0/3] Add support for USB controllers on QCS615 Vinod Koul
  3 siblings, 0 replies; 15+ messages in thread
From: Krishna Kurapati @ 2024-12-24  8:46 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Vinod Koul, Kishon Vijay Abraham I, Konrad Dybcio,
	Dmitry Baryshkov, Johan Hovold, Manivannan Sadhasivam,
	Varadarajan Narayanan, Wesley Cheng
  Cc: linux-kernel, linux-arm-msm, linux-phy, linux-usb, devicetree,
	quic_ppratap, quic_jackp, Krishna Kurapati

From: Krishna Kurapati <quic_kriskura@quicinc.com>

Provide PHY configuration for the USB QMP PHY for QCS615 Platform.

Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c b/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c
index cf12a6f12134..5e7fcb26744a 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-usbc.c
@@ -1124,6 +1124,9 @@ static const struct of_device_id qmp_usbc_of_match_table[] = {
 	}, {
 		.compatible = "qcom,qcm2290-qmp-usb3-phy",
 		.data = &qcm2290_usb3phy_cfg,
+	}, {
+		.compatible = "qcom,qcs615-qmp-usb3-phy",
+		.data = &qcm2290_usb3phy_cfg,
 	}, {
 		.compatible = "qcom,sdm660-qmp-usb3-phy",
 		.data = &sdm660_usb3phy_cfg,
-- 
2.34.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: (subset) [PATCH v3 0/3] Add support for USB controllers on QCS615
  2024-12-24  8:46 [PATCH v3 0/3] Add support for USB controllers on QCS615 Krishna Kurapati
                   ` (2 preceding siblings ...)
  2024-12-24  8:46 ` [PATCH v3 3/3] phy: qcom: qmp-usbc: Add qmp configuration " Krishna Kurapati
@ 2024-12-24 15:25 ` Vinod Koul
  2024-12-24 15:38   ` Dmitry Baryshkov
  3 siblings, 1 reply; 15+ messages in thread
From: Vinod Koul @ 2024-12-24 15:25 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Kishon Vijay Abraham I, Konrad Dybcio,
	Dmitry Baryshkov, Johan Hovold, Manivannan Sadhasivam,
	Varadarajan Narayanan, Wesley Cheng, Krishna Kurapati
  Cc: linux-kernel, linux-arm-msm, linux-phy, linux-usb, devicetree,
	quic_ppratap, quic_jackp


On Tue, 24 Dec 2024 14:16:18 +0530, Krishna Kurapati wrote:
> This series aims at enabling USB on QCS615 which has 2 USB controllers.
> The primary controller is SuperSpeed capable and secondary one is
> High Speed only capable. The High Speed Phy is a QUSB2 phy and the
> SuperSpeed Phy is a QMP Uni Phy which supports non-concurrent DP.
> 
> Link to v1:
> https://lore.kernel.org/all/20241014084432.3310114-1-quic_kriskura@quicinc.com/
> 
> [...]

Applied, thanks!

[2/3] phy: qcom-qusb2: Add support for QCS615
      commit: 8adbf20e05025f588d68fb5b0fbbdab4e9a6f97e

Best regards,
-- 
~Vinod



-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: (subset) [PATCH v3 0/3] Add support for USB controllers on QCS615
  2024-12-24 15:25 ` (subset) [PATCH v3 0/3] Add support for USB controllers on QCS615 Vinod Koul
@ 2024-12-24 15:38   ` Dmitry Baryshkov
  2024-12-24 19:19     ` Vinod Koul
  0 siblings, 1 reply; 15+ messages in thread
From: Dmitry Baryshkov @ 2024-12-24 15:38 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Kishon Vijay Abraham I, Konrad Dybcio, Johan Hovold,
	Manivannan Sadhasivam, Varadarajan Narayanan, Wesley Cheng,
	Krishna Kurapati, linux-kernel, linux-arm-msm, linux-phy,
	linux-usb, devicetree, quic_ppratap, quic_jackp

On Tue, Dec 24, 2024 at 08:55:18PM +0530, Vinod Koul wrote:
> 
> On Tue, 24 Dec 2024 14:16:18 +0530, Krishna Kurapati wrote:
> > This series aims at enabling USB on QCS615 which has 2 USB controllers.
> > The primary controller is SuperSpeed capable and secondary one is
> > High Speed only capable. The High Speed Phy is a QUSB2 phy and the
> > SuperSpeed Phy is a QMP Uni Phy which supports non-concurrent DP.
> > 
> > Link to v1:
> > https://lore.kernel.org/all/20241014084432.3310114-1-quic_kriskura@quicinc.com/
> > 
> > [...]
> 
> Applied, thanks!
> 
> [2/3] phy: qcom-qusb2: Add support for QCS615
>       commit: 8adbf20e05025f588d68fb5b0fbbdab4e9a6f97e

Is there any issue with the two remaining patches?

-- 
With best wishes
Dmitry

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: (subset) [PATCH v3 0/3] Add support for USB controllers on QCS615
  2024-12-24 15:38   ` Dmitry Baryshkov
@ 2024-12-24 19:19     ` Vinod Koul
  2024-12-24 19:33       ` Dmitry Baryshkov
  0 siblings, 1 reply; 15+ messages in thread
From: Vinod Koul @ 2024-12-24 19:19 UTC (permalink / raw)
  To: Dmitry Baryshkov
  Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Kishon Vijay Abraham I, Konrad Dybcio, Johan Hovold,
	Manivannan Sadhasivam, Varadarajan Narayanan, Wesley Cheng,
	Krishna Kurapati, linux-kernel, linux-arm-msm, linux-phy,
	linux-usb, devicetree, quic_ppratap, quic_jackp

On 24-12-24, 17:38, Dmitry Baryshkov wrote:
> On Tue, Dec 24, 2024 at 08:55:18PM +0530, Vinod Koul wrote:
> > 
> > On Tue, 24 Dec 2024 14:16:18 +0530, Krishna Kurapati wrote:
> > > This series aims at enabling USB on QCS615 which has 2 USB controllers.
> > > The primary controller is SuperSpeed capable and secondary one is
> > > High Speed only capable. The High Speed Phy is a QUSB2 phy and the
> > > SuperSpeed Phy is a QMP Uni Phy which supports non-concurrent DP.
> > > 
> > > Link to v1:
> > > https://lore.kernel.org/all/20241014084432.3310114-1-quic_kriskura@quicinc.com/
> > > 
> > > [...]
> > 
> > Applied, thanks!
> > 
> > [2/3] phy: qcom-qusb2: Add support for QCS615
> >       commit: 8adbf20e05025f588d68fb5b0fbbdab4e9a6f97e
> 
> Is there any issue with the two remaining patches?

Something wrong with b4... I have applied 2 & 3
Patch 1 should go thru USB tree

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: (subset) [PATCH v3 0/3] Add support for USB controllers on QCS615
  2024-12-24 19:19     ` Vinod Koul
@ 2024-12-24 19:33       ` Dmitry Baryshkov
  2024-12-24 19:42         ` Vinod Koul
  0 siblings, 1 reply; 15+ messages in thread
From: Dmitry Baryshkov @ 2024-12-24 19:33 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Kishon Vijay Abraham I, Konrad Dybcio, Johan Hovold,
	Manivannan Sadhasivam, Varadarajan Narayanan, Wesley Cheng,
	Krishna Kurapati, linux-kernel, linux-arm-msm, linux-phy,
	linux-usb, devicetree, quic_ppratap, quic_jackp

On Wed, Dec 25, 2024 at 12:49:07AM +0530, Vinod Koul wrote:
> On 24-12-24, 17:38, Dmitry Baryshkov wrote:
> > On Tue, Dec 24, 2024 at 08:55:18PM +0530, Vinod Koul wrote:
> > > 
> > > On Tue, 24 Dec 2024 14:16:18 +0530, Krishna Kurapati wrote:
> > > > This series aims at enabling USB on QCS615 which has 2 USB controllers.
> > > > The primary controller is SuperSpeed capable and secondary one is
> > > > High Speed only capable. The High Speed Phy is a QUSB2 phy and the
> > > > SuperSpeed Phy is a QMP Uni Phy which supports non-concurrent DP.
> > > > 
> > > > Link to v1:
> > > > https://lore.kernel.org/all/20241014084432.3310114-1-quic_kriskura@quicinc.com/
> > > > 
> > > > [...]
> > > 
> > > Applied, thanks!
> > > 
> > > [2/3] phy: qcom-qusb2: Add support for QCS615
> > >       commit: 8adbf20e05025f588d68fb5b0fbbdab4e9a6f97e
> > 
> > Is there any issue with the two remaining patches?
> 
> Something wrong with b4... I have applied 2 & 3
> Patch 1 should go thru USB tree

Hmm, strange. But then, please excuse my ignorance, do we have bindings
for these two patches?

-- 
With best wishes
Dmitry

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: (subset) [PATCH v3 0/3] Add support for USB controllers on QCS615
  2024-12-24 19:33       ` Dmitry Baryshkov
@ 2024-12-24 19:42         ` Vinod Koul
  2024-12-25  8:31           ` Krishna Kurapati
  0 siblings, 1 reply; 15+ messages in thread
From: Vinod Koul @ 2024-12-24 19:42 UTC (permalink / raw)
  To: Dmitry Baryshkov
  Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Kishon Vijay Abraham I, Konrad Dybcio, Johan Hovold,
	Manivannan Sadhasivam, Varadarajan Narayanan, Wesley Cheng,
	Krishna Kurapati, linux-kernel, linux-arm-msm, linux-phy,
	linux-usb, devicetree, quic_ppratap, quic_jackp

On 24-12-24, 21:33, Dmitry Baryshkov wrote:
> On Wed, Dec 25, 2024 at 12:49:07AM +0530, Vinod Koul wrote:
> > On 24-12-24, 17:38, Dmitry Baryshkov wrote:
> > > On Tue, Dec 24, 2024 at 08:55:18PM +0530, Vinod Koul wrote:
> > > > 
> > > > On Tue, 24 Dec 2024 14:16:18 +0530, Krishna Kurapati wrote:
> > > > > This series aims at enabling USB on QCS615 which has 2 USB controllers.
> > > > > The primary controller is SuperSpeed capable and secondary one is
> > > > > High Speed only capable. The High Speed Phy is a QUSB2 phy and the
> > > > > SuperSpeed Phy is a QMP Uni Phy which supports non-concurrent DP.
> > > > > 
> > > > > Link to v1:
> > > > > https://lore.kernel.org/all/20241014084432.3310114-1-quic_kriskura@quicinc.com/
> > > > > 
> > > > > [...]
> > > > 
> > > > Applied, thanks!
> > > > 
> > > > [2/3] phy: qcom-qusb2: Add support for QCS615
> > > >       commit: 8adbf20e05025f588d68fb5b0fbbdab4e9a6f97e
> > > 
> > > Is there any issue with the two remaining patches?
> > 
> > Something wrong with b4... I have applied 2 & 3
> > Patch 1 should go thru USB tree
> 
> Hmm, strange. But then, please excuse my ignorance, do we have bindings
> for these two patches?

I see to have missed one!

This one is documented see:
d146d384222e dt-bindings: phy: qcom,qusb2: Add bindings for QCS615

but, the third patch is sadly not... I am dropping the third patch

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: (subset) [PATCH v3 0/3] Add support for USB controllers on QCS615
  2024-12-24 19:42         ` Vinod Koul
@ 2024-12-25  8:31           ` Krishna Kurapati
  2025-01-23  7:00             ` Krishna Kurapati
  0 siblings, 1 reply; 15+ messages in thread
From: Krishna Kurapati @ 2024-12-25  8:31 UTC (permalink / raw)
  To: Vinod Koul, Dmitry Baryshkov
  Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Kishon Vijay Abraham I, Konrad Dybcio, Johan Hovold,
	Manivannan Sadhasivam, Varadarajan Narayanan, Wesley Cheng,
	linux-kernel, linux-arm-msm, linux-phy, linux-usb, devicetree,
	quic_ppratap, quic_jackp



On 12/25/2024 1:12 AM, Vinod Koul wrote:
> On 24-12-24, 21:33, Dmitry Baryshkov wrote:
>> On Wed, Dec 25, 2024 at 12:49:07AM +0530, Vinod Koul wrote:
>>> On 24-12-24, 17:38, Dmitry Baryshkov wrote:
>>>> On Tue, Dec 24, 2024 at 08:55:18PM +0530, Vinod Koul wrote:
>>>>>
>>>>> On Tue, 24 Dec 2024 14:16:18 +0530, Krishna Kurapati wrote:
>>>>>> This series aims at enabling USB on QCS615 which has 2 USB controllers.
>>>>>> The primary controller is SuperSpeed capable and secondary one is
>>>>>> High Speed only capable. The High Speed Phy is a QUSB2 phy and the
>>>>>> SuperSpeed Phy is a QMP Uni Phy which supports non-concurrent DP.
>>>>>>
>>>>>> Link to v1:
>>>>>> https://lore.kernel.org/all/20241014084432.3310114-1-quic_kriskura@quicinc.com/
>>>>>>
>>>>>> [...]
>>>>>
>>>>> Applied, thanks!
>>>>>
>>>>> [2/3] phy: qcom-qusb2: Add support for QCS615
>>>>>        commit: 8adbf20e05025f588d68fb5b0fbbdab4e9a6f97ecommit e1b2772ea957c91694aa91b90e4c0a1d7b0fb144
Author: Krishna Kurapati <quic_kriskura@quicinc.com>
Date:   Mon Oct 14 14:14:30 2024 +0530

     dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for QCS615


>>>>
>>>> Is there any issue with the two remaining patches?
>>>
>>> Something wrong with b4... I have applied 2 & 3
>>> Patch 1 should go thru USB tree
>>
>> Hmm, strange. But then, please excuse my ignorance, do we have bindings
>> for these two patches?
> 
> I see to have missed one!
> 
> This one is documented see:
> d146d384222e dt-bindings: phy: qcom,qusb2: Add bindings for QCS615
> 
> but, the third patch is sadly not... I am dropping the third patch
> 

Hi Dmitry, Vinod,

  I see the bindings for QMP PHY in linux next as follows:

commit e1b2772ea957c91694aa91b90e4c0a1d7b0fb144
Author: Krishna Kurapati <quic_kriskura@quicinc.com>
Date:   Mon Oct 14 14:14:30 2024 +0530

     dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for QCS615

As mentioned in the cover letter, the bindings of phy have been merged 
from v1.

Regards,
Krishna,

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: (subset) [PATCH v3 0/3] Add support for USB controllers on QCS615
  2024-12-25  8:31           ` Krishna Kurapati
@ 2025-01-23  7:00             ` Krishna Kurapati
  2025-01-23  7:23               ` Dmitry Baryshkov
  0 siblings, 1 reply; 15+ messages in thread
From: Krishna Kurapati @ 2025-01-23  7:00 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Kishon Vijay Abraham I, Konrad Dybcio, Johan Hovold,
	Manivannan Sadhasivam, linux-kernel, linux-arm-msm, linux-phy,
	Dmitry Baryshkov



On 12/25/2024 2:01 PM, Krishna Kurapati wrote:
> 
> 
> On 12/25/2024 1:12 AM, Vinod Koul wrote:
>> On 24-12-24, 21:33, Dmitry Baryshkov wrote:
>>> On Wed, Dec 25, 2024 at 12:49:07AM +0530, Vinod Koul wrote:
>>>> On 24-12-24, 17:38, Dmitry Baryshkov wrote:
>>>>> On Tue, Dec 24, 2024 at 08:55:18PM +0530, Vinod Koul wrote:
>>>>>>
>>>>>> On Tue, 24 Dec 2024 14:16:18 +0530, Krishna Kurapati wrote:
>>>>>>> This series aims at enabling USB on QCS615 which has 2 USB 
>>>>>>> controllers.
>>>>>>> The primary controller is SuperSpeed capable and secondary one is
>>>>>>> High Speed only capable. The High Speed Phy is a QUSB2 phy and the
>>>>>>> SuperSpeed Phy is a QMP Uni Phy which supports non-concurrent DP.
>>>>>>>
>>>>>>> Link to v1:
>>>>>>> https://lore.kernel.org/all/20241014084432.3310114-1-quic_kriskura@quicinc.com/
>>>>>>>
>>>>>>> [...]
>>>>>>
>>>>>> Applied, thanks!
>>>>>>
>>>>>> [2/3] phy: qcom-qusb2: Add support for QCS615
>>>>>>        commit: 8adbf20e05025f588d68fb5b0fbbdab4e9a6f97ecommit 
>>>>>> e1b2772ea957c91694aa91b90e4c0a1d7b0fb144
> Author: Krishna Kurapati <quic_kriskura@quicinc.com>
> Date:   Mon Oct 14 14:14:30 2024 +0530
> 
>      dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for QCS615
> 
> 
>>>>>
>>>>> Is there any issue with the two remaining patches?
>>>>
>>>> Something wrong with b4... I have applied 2 & 3
>>>> Patch 1 should go thru USB tree
>>>
>>> Hmm, strange. But then, please excuse my ignorance, do we have bindings
>>> for these two patches?
>>
>> I see to have missed one!
>>
>> This one is documented see:
>> d146d384222e dt-bindings: phy: qcom,qusb2: Add bindings for QCS615
>>
>> but, the third patch is sadly not... I am dropping the third patch
>>
> 
> Hi Dmitry, Vinod,
> 
>   I see the bindings for QMP PHY in linux next as follows:
> 
> commit e1b2772ea957c91694aa91b90e4c0a1d7b0fb144
> Author: Krishna Kurapati <quic_kriskura@quicinc.com>
> Date:   Mon Oct 14 14:14:30 2024 +0530
> 
>      dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for QCS615
> 
> As mentioned in the cover letter, the bindings of phy have been merged 
> from v1.

Hi Vinod,

  Can you help in taking in the patch-3. As mentioned in previous mail, 
the bindings are merged and present in linux-next.

Regards,
Krishna,

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: (subset) [PATCH v3 0/3] Add support for USB controllers on QCS615
  2025-01-23  7:00             ` Krishna Kurapati
@ 2025-01-23  7:23               ` Dmitry Baryshkov
  2025-02-14 12:30                 ` Vinod Koul
  0 siblings, 1 reply; 15+ messages in thread
From: Dmitry Baryshkov @ 2025-01-23  7:23 UTC (permalink / raw)
  To: Krishna Kurapati
  Cc: Vinod Koul, Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Kishon Vijay Abraham I, Konrad Dybcio, Johan Hovold,
	Manivannan Sadhasivam, linux-kernel, linux-arm-msm, linux-phy

On Thu, 23 Jan 2025 at 09:00, Krishna Kurapati
<krishna.kurapati@oss.qualcomm.com> wrote:
>
>
>
> On 12/25/2024 2:01 PM, Krishna Kurapati wrote:
> >
> >
> > On 12/25/2024 1:12 AM, Vinod Koul wrote:
> >> On 24-12-24, 21:33, Dmitry Baryshkov wrote:
> >>> On Wed, Dec 25, 2024 at 12:49:07AM +0530, Vinod Koul wrote:
> >>>> On 24-12-24, 17:38, Dmitry Baryshkov wrote:
> >>>>> On Tue, Dec 24, 2024 at 08:55:18PM +0530, Vinod Koul wrote:
> >>>>>>
> >>>>>> On Tue, 24 Dec 2024 14:16:18 +0530, Krishna Kurapati wrote:
> >>>>>>> This series aims at enabling USB on QCS615 which has 2 USB
> >>>>>>> controllers.
> >>>>>>> The primary controller is SuperSpeed capable and secondary one is
> >>>>>>> High Speed only capable. The High Speed Phy is a QUSB2 phy and the
> >>>>>>> SuperSpeed Phy is a QMP Uni Phy which supports non-concurrent DP.
> >>>>>>>
> >>>>>>> Link to v1:
> >>>>>>> https://lore.kernel.org/all/20241014084432.3310114-1-quic_kriskura@quicinc.com/
> >>>>>>>
> >>>>>>> [...]
> >>>>>>
> >>>>>> Applied, thanks!
> >>>>>>
> >>>>>> [2/3] phy: qcom-qusb2: Add support for QCS615
> >>>>>>        commit: 8adbf20e05025f588d68fb5b0fbbdab4e9a6f97ecommit
> >>>>>> e1b2772ea957c91694aa91b90e4c0a1d7b0fb144
> > Author: Krishna Kurapati <quic_kriskura@quicinc.com>
> > Date:   Mon Oct 14 14:14:30 2024 +0530
> >
> >      dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for QCS615
> >
> >
> >>>>>
> >>>>> Is there any issue with the two remaining patches?
> >>>>
> >>>> Something wrong with b4... I have applied 2 & 3
> >>>> Patch 1 should go thru USB tree
> >>>
> >>> Hmm, strange. But then, please excuse my ignorance, do we have bindings
> >>> for these two patches?
> >>
> >> I see to have missed one!
> >>
> >> This one is documented see:
> >> d146d384222e dt-bindings: phy: qcom,qusb2: Add bindings for QCS615
> >>
> >> but, the third patch is sadly not... I am dropping the third patch
> >>
> >
> > Hi Dmitry, Vinod,
> >
> >   I see the bindings for QMP PHY in linux next as follows:
> >
> > commit e1b2772ea957c91694aa91b90e4c0a1d7b0fb144
> > Author: Krishna Kurapati <quic_kriskura@quicinc.com>
> > Date:   Mon Oct 14 14:14:30 2024 +0530
> >
> >      dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for QCS615
> >
> > As mentioned in the cover letter, the bindings of phy have been merged
> > from v1.
>
> Hi Vinod,
>
>   Can you help in taking in the patch-3. As mentioned in previous mail,
> the bindings are merged and present in linux-next.

We are currently in the merge window, no new patches can be accepted.

-- 
With best wishes
Dmitry

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: (subset) [PATCH v3 0/3] Add support for USB controllers on QCS615
  2025-01-23  7:23               ` Dmitry Baryshkov
@ 2025-02-14 12:30                 ` Vinod Koul
  2025-03-06 13:23                   ` Krishna Kurapati
  0 siblings, 1 reply; 15+ messages in thread
From: Vinod Koul @ 2025-02-14 12:30 UTC (permalink / raw)
  To: Dmitry Baryshkov
  Cc: Krishna Kurapati, Greg Kroah-Hartman, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Kishon Vijay Abraham I,
	Konrad Dybcio, Johan Hovold, Manivannan Sadhasivam, linux-kernel,
	linux-arm-msm, linux-phy

On 23-01-25, 09:23, Dmitry Baryshkov wrote:
> On Thu, 23 Jan 2025 at 09:00, Krishna Kurapati
> <krishna.kurapati@oss.qualcomm.com> wrote:

> > > As mentioned in the cover letter, the bindings of phy have been merged
> > > from v1.
> >
> > Hi Vinod,
> >
> >   Can you help in taking in the patch-3. As mentioned in previous mail,
> > the bindings are merged and present in linux-next.

Can you pls post it after rebasing

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: (subset) [PATCH v3 0/3] Add support for USB controllers on QCS615
  2025-02-14 12:30                 ` Vinod Koul
@ 2025-03-06 13:23                   ` Krishna Kurapati
  2025-03-10  7:15                     ` Vinod Koul
  0 siblings, 1 reply; 15+ messages in thread
From: Krishna Kurapati @ 2025-03-06 13:23 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Kishon Vijay Abraham I, Konrad Dybcio,
	Dmitry Baryshkov, Johan Hovold, Manivannan Sadhasivam,
	linux-kernel, linux-arm-msm, linux-phy



On 2/14/2025 6:00 PM, Vinod Koul wrote:
> On 23-01-25, 09:23, Dmitry Baryshkov wrote:
>> On Thu, 23 Jan 2025 at 09:00, Krishna Kurapati
>> <krishna.kurapati@oss.qualcomm.com> wrote:
> 
>>>> As mentioned in the cover letter, the bindings of phy have been merged
>>>> from v1.
>>>
>>> Hi Vinod,
>>>
>>>    Can you help in taking in the patch-3. As mentioned in previous mail,
>>> the bindings are merged and present in linux-next.
> 
> Can you pls post it after rebasing
> 

Hi Vinod,

  I see the patch-3 is applying cleanly on top of latest linux next. Do 
you suggest sending a rebase or v3 is fine ?

Regards,
Krishna,

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: (subset) [PATCH v3 0/3] Add support for USB controllers on QCS615
  2025-03-06 13:23                   ` Krishna Kurapati
@ 2025-03-10  7:15                     ` Vinod Koul
  0 siblings, 0 replies; 15+ messages in thread
From: Vinod Koul @ 2025-03-10  7:15 UTC (permalink / raw)
  To: Krishna Kurapati
  Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Kishon Vijay Abraham I, Konrad Dybcio,
	Dmitry Baryshkov, Johan Hovold, Manivannan Sadhasivam,
	linux-kernel, linux-arm-msm, linux-phy

On 06-03-25, 18:53, Krishna Kurapati wrote:
> 
> 
> On 2/14/2025 6:00 PM, Vinod Koul wrote:
> > On 23-01-25, 09:23, Dmitry Baryshkov wrote:
> > > On Thu, 23 Jan 2025 at 09:00, Krishna Kurapati
> > > <krishna.kurapati@oss.qualcomm.com> wrote:
> > 
> > > > > As mentioned in the cover letter, the bindings of phy have been merged
> > > > > from v1.
> > > > 
> > > > Hi Vinod,
> > > > 
> > > >    Can you help in taking in the patch-3. As mentioned in previous mail,
> > > > the bindings are merged and present in linux-next.
> > 
> > Can you pls post it after rebasing
> > 
> 
> Hi Vinod,
> 
>  I see the patch-3 is applying cleanly on top of latest linux next. Do you
> suggest sending a rebase or v3 is fine ?

Please rebase on phy/next and resend

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2025-03-10  7:17 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-24  8:46 [PATCH v3 0/3] Add support for USB controllers on QCS615 Krishna Kurapati
2024-12-24  8:46 ` [PATCH v3 1/3] dt-bindings: usb: qcom,dwc3: Add QCS615 to USB DWC3 bindings Krishna Kurapati
2024-12-24  8:46 ` [PATCH v3 2/3] phy: qcom-qusb2: Add support for QCS615 Krishna Kurapati
2024-12-24  8:46 ` [PATCH v3 3/3] phy: qcom: qmp-usbc: Add qmp configuration " Krishna Kurapati
2024-12-24 15:25 ` (subset) [PATCH v3 0/3] Add support for USB controllers on QCS615 Vinod Koul
2024-12-24 15:38   ` Dmitry Baryshkov
2024-12-24 19:19     ` Vinod Koul
2024-12-24 19:33       ` Dmitry Baryshkov
2024-12-24 19:42         ` Vinod Koul
2024-12-25  8:31           ` Krishna Kurapati
2025-01-23  7:00             ` Krishna Kurapati
2025-01-23  7:23               ` Dmitry Baryshkov
2025-02-14 12:30                 ` Vinod Koul
2025-03-06 13:23                   ` Krishna Kurapati
2025-03-10  7:15                     ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).