Re: [PATCH v8 5/7] dt-bindings: PCI: qcom: Document the IPQ5332 PCIe controller

From: Varadarajan Narayanan <quic_varada@quicinc.com>
To: Rob Herring <robh@kernel.org>
Cc: <lpieralisi@kernel.org>, <kw@linux.com>,
	<manivannan.sadhasivam@linaro.org>, <bhelgaas@google.com>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>, <vkoul@kernel.org>,
	<kishon@kernel.org>, <andersson@kernel.org>,
	<konradybcio@kernel.org>, <p.zabel@pengutronix.de>,
	<dmitry.baryshkov@linaro.org>, <quic_nsekar@quicinc.com>,
	<linux-arm-msm@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-phy@lists.infradead.org>
Subject: Re: [PATCH v8 5/7] dt-bindings: PCI: qcom: Document the IPQ5332 PCIe controller
Date: Tue, 28 Jan 2025 11:08:57 +0530	[thread overview]
Message-ID: <Z5htccTM8BKoAbJH@hu-varada-blr.qualcomm.com> (raw)
In-Reply-To: <20250127191906.GA704182-robh@kernel.org>

On Mon, Jan 27, 2025 at 01:19:06PM -0600, Rob Herring wrote:
> On Mon, Jan 27, 2025 at 12:58:48PM +0530, Varadarajan Narayanan wrote:
> > Document the PCIe controller on IPQ5332 platform. IPQ5332 will
> > use IPQ9574 as the fall back compatible.
> >
> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> > ---
> > v8: Use ipq9574 as fallback compatible for ipq5332 along with ipq5424
> >
> > v7: Moved ipq9574 related changes to a separate patch
> >     Add 'global' interrupt
> >
> > v6: Commit message update only. Add info regarding the moving of
> >     ipq9574 from 5 "reg" definition to 5 or 6 reg definition.
> >
> > v5: Re-arrange 5332 and 9574 compatibles to handle fallback usage in dts
> >
> > v4: * v3 reused ipq9574 bindings for ipq5332. Instead add one for ipq5332
> >     * DTS uses ipq9574 compatible as fallback. Hence move ipq9574 to be able
> >       to use the 'reg' section for both ipq5332 and ipq9574. Else, dtbs_check
> >       and dt_binding_check flag errors.
> > ---
> >  Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > index 4b4927178abc..2ffa8480a665 100644
> > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> > @@ -33,6 +33,7 @@ properties:
> >            - qcom,pcie-sdx55
> >        - items:
> >            - enum:
> > +              - qcom,pcie-ipq5332
> >                - qcom,pcie-ipq5424
> >            - const: qcom,pcie-ipq9574
> >        - items:
> > @@ -49,11 +50,11 @@ properties:
> >
> >    interrupts:
> >      minItems: 1
> > -    maxItems: 8
> > +    maxItems: 9
> >
> >    interrupt-names:
> >      minItems: 1
> > -    maxItems: 8
> > +    maxItems: 9
> >
> >    iommu-map:
> >      minItems: 1
> > @@ -209,6 +210,7 @@ allOf:
> >          compatible:
> >            contains:
> >              enum:
> > +              - qcom,pcie-ipq5332
> >                - qcom,pcie-ipq9574
>
> As both of these compatibles will be present, you don't need to add
> ipq5332 here.

Ok.

> >                - qcom,pcie-sdx55
> >      then:
> > @@ -411,6 +413,7 @@ allOf:
> >          compatible:
> >            contains:
> >              enum:
> > +              - qcom,pcie-ipq5332
> >                - qcom,pcie-ipq9574
>
> Same here.

Ok.

Thanks
Varada

> >      then:
> >        properties:
> > @@ -443,6 +446,7 @@ allOf:
> >          interrupts:
> >            minItems: 8
> >          interrupt-names:
> > +          minItems: 8
> >            items:
> >              - const: msi0
> >              - const: msi1
> > @@ -452,6 +456,7 @@ allOf:
> >              - const: msi5
> >              - const: msi6
> >              - const: msi7
> > +            - const: global
> >
> >    - if:
> >        properties:
> > @@ -559,6 +564,7 @@ allOf:
> >                enum:
> >                  - qcom,pcie-apq8064
> >                  - qcom,pcie-ipq4019
> > +                - qcom,pcie-ipq5332
> >                  - qcom,pcie-ipq8064
> >                  - qcom,pcie-ipq8064v2
> >                  - qcom,pcie-ipq8074
> > --
> > 2.34.1
> >

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy