From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8BF74C0219B for ; Tue, 11 Feb 2025 09:41:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WdZKajfvMOnPPE8nD9qKOvsUaEKrwWB/WLXyD0xZL2M=; b=jU6XaM75oHHaa8 EqhfTGSAYoUzfd4oH+HdlUlBjfbvJXjL/ifxO9JTmlnA0KO3mgLgB6x5kUiiWoRPPH/jp5cm0vmsy ozyjCy/3crX8t31C9xKdUxSKr1oJJ5mhpiXJGwofVMld90NQfMPqXzB2rok82yxs9pkyP2+3t2wIg nZ54slHdcKRpyHt4oL+ZdlmkHPaQgPjQyy83vX0rXKk1QBrk3hW6LeFGRfxlzUH8NCwhXTsj34Apq pBjt7h2yZB7CoTvRSiy3QCpPi5V+Y1RFqmu8vQOHItsA5QgIADZAP+L4g9CeF+Yp6QTEdfS2t7PUJ 1i20DqEjp+PUOiRuQ0Ew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thmlb-00000003E0U-0KAx; Tue, 11 Feb 2025 09:41:19 +0000 Received: from mgamail.intel.com ([192.198.163.11]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thmlY-00000003Dzc-2cTZ for linux-phy@lists.infradead.org; Tue, 11 Feb 2025 09:41:17 +0000 X-CSE-ConnectionGUID: 1HlgeI1ERtCMeFAo9A3iyA== X-CSE-MsgGUID: 9moNGQ1XQUScj/3Mrrz5zw== X-IronPort-AV: E=McAfee;i="6700,10204,11341"; a="50510267" X-IronPort-AV: E=Sophos;i="6.13,277,1732608000"; d="scan'208";a="50510267" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2025 01:41:10 -0800 X-CSE-ConnectionGUID: M4q0L3FITbuvBztdQMvbJg== X-CSE-MsgGUID: Cg7Uozc6SoWKjkvUHvaTwQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="143364716" Received: from smile.fi.intel.com ([10.237.72.58]) by fmviesa001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2025 01:41:03 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1thmlH-0000000ASZ3-2ikX; Tue, 11 Feb 2025 11:40:59 +0200 Date: Tue, 11 Feb 2025 11:40:59 +0200 From: Andy Shevchenko To: David Lechner Cc: Linus Walleij , Bartosz Golaszewski , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , Nuno =?iso-8859-1?Q?S=E1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org Subject: Re: [PATCH v3 05/15] bus: ts-nbus: use bitmap_get_value8() Message-ID: References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> <20250210-gpio-set-array-helper-v3-5-d6a673674da8@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250210-gpio-set-array-helper-v3-5-d6a673674da8@baylibre.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250211_014116_678692_7615FCFD X-CRM114-Status: GOOD ( 10.60 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Mon, Feb 10, 2025 at 04:33:31PM -0600, David Lechner wrote: > Use bitmap_get_value8() instead of accessing the bitmap directly. > > Accessing the bitmap directly is not considered good practice. We now > have a helper function that can be used instead, so let's use it. Thank you, LGTM (one minor thing you may address, or keep it as in the current variant of the patch), Reviewed-by: Andy Shevchenko ... > +#include > #include bitmap.h implies bitops.h -- With Best Regards, Andy Shevchenko -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy