From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A658C0219D for ; Tue, 11 Feb 2025 10:55:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WPVAN79a0nljQ8ZVDO2obOm3OKRZj4MaQy2nN7C42Qo=; b=rd2BeMY/u/mSSd 4RiDpxwxhLgVrSegWyL1oaI6EfQjPNRH3x+lW3I6Lf0mCW/qUXb4gW1arX2/kaj8+S8z+6lFYOR3i 64341raAt9W/nMgXoC0YkiIqLBUePtkKFVJmPKudu8UON5xdokw6WDh6mzkn3DtGqevsmc95qWWn+ GvhhqA566DkpHlkhDepWvt8WfkViFcNUy/bnVURyFbXtjpaFaGc96nL03+wvmqRBH1sVZJZwqSaVz QT+hBujDRjXm+OwKGxLVw8H6Aimt+8uDiKSMluSOxYv/g+G8+89k2V6Zia/Qx+d9qplkWhcuqXCg7 Kljelbva/xgps/Qd5ffA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thnvo-00000003RBZ-407C; Tue, 11 Feb 2025 10:55:56 +0000 Received: from mgamail.intel.com ([192.198.163.9]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thmnA-00000003EDU-1nKt for linux-phy@lists.infradead.org; Tue, 11 Feb 2025 09:42:57 +0000 X-CSE-ConnectionGUID: syYgJqXrRuC1IQ71PS3MKg== X-CSE-MsgGUID: BQvnij/2T1eqQMgIGXEKWA== X-IronPort-AV: E=McAfee;i="6700,10204,11341"; a="50512951" X-IronPort-AV: E=Sophos;i="6.13,277,1732608000"; d="scan'208";a="50512951" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2025 01:42:56 -0800 X-CSE-ConnectionGUID: aYZy757oTGGgjCvr/1BDnw== X-CSE-MsgGUID: 05tIZ9H+StaAmIWpBPA8UQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,277,1732608000"; d="scan'208";a="112427591" Received: from smile.fi.intel.com ([10.237.72.58]) by fmviesa007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2025 01:42:50 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1thmmz-0000000ASai-3bzO; Tue, 11 Feb 2025 11:42:45 +0200 Date: Tue, 11 Feb 2025 11:42:45 +0200 From: Andy Shevchenko To: David Lechner Cc: Linus Walleij , Bartosz Golaszewski , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , Nuno =?iso-8859-1?Q?S=E1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org Subject: Re: [PATCH v3 06/15] gpio: max3191x: use gpiod_multi_set_value_cansleep Message-ID: References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> <20250210-gpio-set-array-helper-v3-6-d6a673674da8@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250210-gpio-set-array-helper-v3-6-d6a673674da8@baylibre.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250211_014256_505667_FDDF1950 X-CRM114-Status: UNSURE ( 9.20 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Mon, Feb 10, 2025 at 04:33:32PM -0600, David Lechner wrote: > Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of > gpiod_set_array_value_cansleep(). > > Also add max3191x_ namespace prefix to the driver's helper function > since we are changing the function signature anyway. With renamed function looks much better, thanks, Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy