[PATCH] phy: tegra: xusb: Add missing tegra_xusb_port_unregister for usb2_port and ulpi_port

[PATCH] phy: tegra: xusb: Add missing tegra_xusb_port_unregister for usb2_port and ulpi_port

[Gaosheng Cui]

The tegra_xusb_port_unregister should be called when usb2_port
and ulpi_port map fails in tegra_xusb_add_usb2_port() or in
tegra_xusb_add_ulpi_port(), fix it.

Fixes: 53d2a715c240 ("phy: Add Tegra XUSB pad controller support")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 drivers/phy/tegra/xusb.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index ff4b930879f3..58eeda573b67 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -782,6 +782,7 @@ static int tegra_xusb_add_usb2_port(struct tegra_xusb_padctl *padctl,
 	usb2->base.lane = usb2->base.ops->map(&usb2->base);
 	if (IS_ERR(usb2->base.lane)) {
 		err = PTR_ERR(usb2->base.lane);
+		tegra_xusb_port_unregister(&usb2->base);
 		goto out;
 	}
 
@@ -848,6 +849,7 @@ static int tegra_xusb_add_ulpi_port(struct tegra_xusb_padctl *padctl,
 	ulpi->base.lane = ulpi->base.ops->map(&ulpi->base);
 	if (IS_ERR(ulpi->base.lane)) {
 		err = PTR_ERR(ulpi->base.lane);
+		tegra_xusb_port_unregister(&ulpi->base);
 		goto out;
 	}
 
-- 
2.25.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH] phy: tegra: xusb: Add missing tegra_xusb_port_unregister for usb2_port and ulpi_port

[Thierry Reding]

[-- Attachment #1.1: Type: text/plain, Size: 561 bytes --]

On Tue, Nov 29, 2022 at 07:16:34PM +0800, Gaosheng Cui wrote:
> The tegra_xusb_port_unregister should be called when usb2_port
> and ulpi_port map fails in tegra_xusb_add_usb2_port() or in
> tegra_xusb_add_ulpi_port(), fix it.
> 
> Fixes: 53d2a715c240 ("phy: Add Tegra XUSB pad controller support")
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
>  drivers/phy/tegra/xusb.c | 2 ++
>  1 file changed, 2 insertions(+)

Looks like this fell through the cracks. Looks correct, though, so:

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 112 bytes --]

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

Re: [PATCH] phy: tegra: xusb: Add missing tegra_xusb_port_unregister for usb2_port and ulpi_port

[Vinod Koul]

On 29-11-22, 19:16, Gaosheng Cui wrote:
> The tegra_xusb_port_unregister should be called when usb2_port
> and ulpi_port map fails in tegra_xusb_add_usb2_port() or in
> tegra_xusb_add_ulpi_port(), fix it.

Applied, thanks

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy