* Re: [PATCH 1/5] dmaengine: qcom: gpi: Use devm_platform_get_and_ioremap_resource() [not found] ` <168909383153.208679.15343948792914219046.b4-ty@kernel.org> @ 2023-07-12 9:33 ` Geert Uytterhoeven 2023-07-12 11:30 ` Vinod Koul 0 siblings, 1 reply; 4+ messages in thread From: Geert Uytterhoeven @ 2023-07-12 9:33 UTC (permalink / raw) To: Vinod Koul Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Yangtao Li, linux-arm-msm, dmaengine, linux-kernel, linux-phy Hi Vinod, On Tue, 11 Jul 2023, Vinod Koul wrote: > On Wed, 05 Jul 2023 16:18:52 +0800, Yangtao Li wrote: >> Convert platform_get_resource(), devm_ioremap_resource() to a single >> call to devm_platform_get_and_ioremap_resource(), as this is exactly >> what this function does. >> >> > > Applied, thanks! > > [1/5] dmaengine: qcom: gpi: Use devm_platform_get_and_ioremap_resource() > commit: d9313d9f1fbc14cae5147c5130bea54aa76ad65f > [2/5] dmaengine: qcom_hidma: Use devm_platform_get_and_ioremap_resource() > commit: a189107deb574fd08018bbf2fe5cd86450a54b13 > [3/5] dmaengine: qcom: hidma_mgmt: Use devm_platform_get_and_ioremap_resource() > commit: fe6c2622473f3756a09bd6c42cffca6fbdce391c > [4/5] dmaengine: shdmac: Convert to devm_platform_ioremap_resource() > commit: 0976421c5a339b1b1a89cfba4471a6de761130ed > [5/5] dmaengine: stm32-dma: Use devm_platform_get_and_ioremap_resource() > commit: b402a7eeaa35aaa3300a4ba6bd5b381112ae183c I noticed all your new dmaengine[1] and phy[2] commits contain a "Message-ID:" tag. Presumable you added a git hook for that? However, the standard way is to add a Link: tag pointing to lore instead, cfr. [3]. Thanks! [1] https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git/commit/?h=next [2] https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git/commit/?h=next [3] https://docs.kernel.org/maintainer/configure-git.html#creating-commit-links-to-lore-kernel-org Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/5] dmaengine: qcom: gpi: Use devm_platform_get_and_ioremap_resource() 2023-07-12 9:33 ` [PATCH 1/5] dmaengine: qcom: gpi: Use devm_platform_get_and_ioremap_resource() Geert Uytterhoeven @ 2023-07-12 11:30 ` Vinod Koul 2023-07-13 8:00 ` Geert Uytterhoeven 0 siblings, 1 reply; 4+ messages in thread From: Vinod Koul @ 2023-07-12 11:30 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Yangtao Li, linux-arm-msm, dmaengine, linux-kernel, linux-phy On 12-07-23, 11:33, Geert Uytterhoeven wrote: > Hi Vinod, > > On Tue, 11 Jul 2023, Vinod Koul wrote: > > On Wed, 05 Jul 2023 16:18:52 +0800, Yangtao Li wrote: > > > Convert platform_get_resource(), devm_ioremap_resource() to a single > > > call to devm_platform_get_and_ioremap_resource(), as this is exactly > > > what this function does. > > > > > > > > > > Applied, thanks! > > > > [1/5] dmaengine: qcom: gpi: Use devm_platform_get_and_ioremap_resource() > > commit: d9313d9f1fbc14cae5147c5130bea54aa76ad65f > > [2/5] dmaengine: qcom_hidma: Use devm_platform_get_and_ioremap_resource() > > commit: a189107deb574fd08018bbf2fe5cd86450a54b13 > > [3/5] dmaengine: qcom: hidma_mgmt: Use devm_platform_get_and_ioremap_resource() > > commit: fe6c2622473f3756a09bd6c42cffca6fbdce391c > > [4/5] dmaengine: shdmac: Convert to devm_platform_ioremap_resource() > > commit: 0976421c5a339b1b1a89cfba4471a6de761130ed > > [5/5] dmaengine: stm32-dma: Use devm_platform_get_and_ioremap_resource() > > commit: b402a7eeaa35aaa3300a4ba6bd5b381112ae183c > > I noticed all your new dmaengine[1] and phy[2] commits contain a > "Message-ID:" tag. Presumable you added a git hook for that? Thanks for pointing that out, yes something is messed up for me. > > However, the standard way is to add a Link: tag pointing to lore > instead, cfr. [3]. Yep and if you look at the dmaengine and phy commits for 6.4 they have "Link" in them, so something is not working, let me fix that up. -- ~Vinod -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/5] dmaengine: qcom: gpi: Use devm_platform_get_and_ioremap_resource() 2023-07-12 11:30 ` Vinod Koul @ 2023-07-13 8:00 ` Geert Uytterhoeven 2023-07-13 17:52 ` Vinod Koul 0 siblings, 1 reply; 4+ messages in thread From: Geert Uytterhoeven @ 2023-07-13 8:00 UTC (permalink / raw) To: Vinod Koul Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Yangtao Li, linux-arm-msm, dmaengine, linux-kernel, linux-phy Hi Vinod, On Wed, Jul 12, 2023 at 1:30 PM Vinod Koul <vkoul@kernel.org> wrote: > On 12-07-23, 11:33, Geert Uytterhoeven wrote: > > On Tue, 11 Jul 2023, Vinod Koul wrote: > > > On Wed, 05 Jul 2023 16:18:52 +0800, Yangtao Li wrote: > > > > Convert platform_get_resource(), devm_ioremap_resource() to a single > > > > call to devm_platform_get_and_ioremap_resource(), as this is exactly > > > > what this function does. > > > > > > Applied, thanks! > > > > > > [1/5] dmaengine: qcom: gpi: Use devm_platform_get_and_ioremap_resource() > > > commit: d9313d9f1fbc14cae5147c5130bea54aa76ad65f > > > [2/5] dmaengine: qcom_hidma: Use devm_platform_get_and_ioremap_resource() > > > commit: a189107deb574fd08018bbf2fe5cd86450a54b13 > > > [3/5] dmaengine: qcom: hidma_mgmt: Use devm_platform_get_and_ioremap_resource() > > > commit: fe6c2622473f3756a09bd6c42cffca6fbdce391c > > > [4/5] dmaengine: shdmac: Convert to devm_platform_ioremap_resource() > > > commit: 0976421c5a339b1b1a89cfba4471a6de761130ed > > > [5/5] dmaengine: stm32-dma: Use devm_platform_get_and_ioremap_resource() > > > commit: b402a7eeaa35aaa3300a4ba6bd5b381112ae183c > > > > I noticed all your new dmaengine[1] and phy[2] commits contain a > > "Message-ID:" tag. Presumable you added a git hook for that? > > Thanks for pointing that out, yes something is messed up for me. > > > However, the standard way is to add a Link: tag pointing to lore > > instead, cfr. [3]. > > Yep and if you look at the dmaengine and phy commits for 6.4 they have > "Link" in them, so something is not working, let me fix that up. Sorry, hadn't noticed that, so I assumed you were a new user ;-) I saw you have already updated your branches, but FTR, the issue was caused by a new version of git, which broke the hook, cfr. commit 2bb19e740e9b3eb4 ("Documentation: update git configuration for Link: tag") in v6.5-rc1. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/5] dmaengine: qcom: gpi: Use devm_platform_get_and_ioremap_resource() 2023-07-13 8:00 ` Geert Uytterhoeven @ 2023-07-13 17:52 ` Vinod Koul 0 siblings, 0 replies; 4+ messages in thread From: Vinod Koul @ 2023-07-13 17:52 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Yangtao Li, linux-arm-msm, dmaengine, linux-kernel, linux-phy Hi Geert, On 13-07-23, 10:00, Geert Uytterhoeven wrote: > On Wed, Jul 12, 2023 at 1:30 PM Vinod Koul <vkoul@kernel.org> wrote: > > On 12-07-23, 11:33, Geert Uytterhoeven wrote: > > > > Thanks for pointing that out, yes something is messed up for me. > > > > > However, the standard way is to add a Link: tag pointing to lore > > > instead, cfr. [3]. > > > > Yep and if you look at the dmaengine and phy commits for 6.4 they have > > "Link" in them, so something is not working, let me fix that up. > > Sorry, hadn't noticed that, so I assumed you were a new user ;-) > > I saw you have already updated your branches, but FTR, the issue > was caused by a new version of git, which broke the hook, cfr. commit > 2bb19e740e9b3eb4 ("Documentation: update git configuration for Link: > tag") in v6.5-rc1. Yes that was exactly the cause, updating my hook fixed it up. Had to fix all the commits in the trees though, thanks -- ~Vinod -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-13 17:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230705081856.13734-1-frank.li@vivo.com>
[not found] ` <168909383153.208679.15343948792914219046.b4-ty@kernel.org>
2023-07-12 9:33 ` [PATCH 1/5] dmaengine: qcom: gpi: Use devm_platform_get_and_ioremap_resource() Geert Uytterhoeven
2023-07-12 11:30 ` Vinod Koul
2023-07-13 8:00 ` Geert Uytterhoeven
2023-07-13 17:52 ` Vinod Koul
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).