From: Thierry Reding <thierry.reding@gmail.com>
To: Yang Li <yang.lee@linux.alibaba.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>
Cc: jckuo@nvidia.com, jonathanh@nvidia.com,
linux-phy@lists.infradead.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] phy: Remove duplicated include in xusb.c
Date: Fri, 21 Jul 2023 15:55:35 +0200 [thread overview]
Message-ID: <ZLqOV-ShmOKcldcZ@orome> (raw)
In-Reply-To: <20230719003614.5506-1-yang.lee@linux.alibaba.com>
[-- Attachment #1.1: Type: text/plain, Size: 1058 bytes --]
On Wed, Jul 19, 2023 at 08:36:14AM +0800, Yang Li wrote:
> ./drivers/phy/tegra/xusb.c: linux/platform_device.h is included more than once.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5930
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/phy/tegra/xusb.c | 1 -
> 1 file changed, 1 deletion(-)
It's typical to list the maintainers on the "To:" line to increase the
chances of them noticing. This is obviously correct, so:
Acked-by: Thierry Reding <treding@nvidia.com>
>
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index ed30866e7647..142ebe0247cc 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -12,7 +12,6 @@
> #include <linux/phy/phy.h>
> #include <linux/phy/tegra/xusb.h>
> #include <linux/platform_device.h>
> -#include <linux/platform_device.h>
> #include <linux/regulator/consumer.h>
> #include <linux/reset.h>
> #include <linux/slab.h>
> --
> 2.20.1.7.g153144c
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 112 bytes --]
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-07-21 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 0:36 [PATCH -next] phy: Remove duplicated include in xusb.c Yang Li
2023-07-21 13:55 ` Thierry Reding [this message]
2023-07-24 10:56 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLqOV-ShmOKcldcZ@orome \
--to=thierry.reding@gmail.com \
--cc=abaci@linux.alibaba.com \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=vkoul@kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).