linux-phy.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] phy: Remove duplicated include in xusb.c
@ 2023-07-19  0:36 Yang Li
  2023-07-21 13:55 ` Thierry Reding
  2023-07-24 10:56 ` Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Yang Li @ 2023-07-19  0:36 UTC (permalink / raw)
  To: jckuo
  Cc: vkoul, kishon, thierry.reding, jonathanh, linux-phy, linux-tegra,
	linux-kernel, Yang Li, Abaci Robot

./drivers/phy/tegra/xusb.c: linux/platform_device.h is included more than once.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5930
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/phy/tegra/xusb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index ed30866e7647..142ebe0247cc 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -12,7 +12,6 @@
 #include <linux/phy/phy.h>
 #include <linux/phy/tegra/xusb.h>
 #include <linux/platform_device.h>
-#include <linux/platform_device.h>
 #include <linux/regulator/consumer.h>
 #include <linux/reset.h>
 #include <linux/slab.h>
-- 
2.20.1.7.g153144c


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] phy: Remove duplicated include in xusb.c
  2023-07-19  0:36 [PATCH -next] phy: Remove duplicated include in xusb.c Yang Li
@ 2023-07-21 13:55 ` Thierry Reding
  2023-07-24 10:56 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2023-07-21 13:55 UTC (permalink / raw)
  To: Yang Li, Vinod Koul, Kishon Vijay Abraham I
  Cc: jckuo, jonathanh, linux-phy, linux-tegra, linux-kernel,
	Abaci Robot


[-- Attachment #1.1: Type: text/plain, Size: 1058 bytes --]

On Wed, Jul 19, 2023 at 08:36:14AM +0800, Yang Li wrote:
> ./drivers/phy/tegra/xusb.c: linux/platform_device.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5930
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/phy/tegra/xusb.c | 1 -
>  1 file changed, 1 deletion(-)

It's typical to list the maintainers on the "To:" line to increase the
chances of them noticing. This is obviously correct, so:

Acked-by: Thierry Reding <treding@nvidia.com>

> 
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index ed30866e7647..142ebe0247cc 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -12,7 +12,6 @@
>  #include <linux/phy/phy.h>
>  #include <linux/phy/tegra/xusb.h>
>  #include <linux/platform_device.h>
> -#include <linux/platform_device.h>
>  #include <linux/regulator/consumer.h>
>  #include <linux/reset.h>
>  #include <linux/slab.h>
> -- 
> 2.20.1.7.g153144c
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 112 bytes --]

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] phy: Remove duplicated include in xusb.c
  2023-07-19  0:36 [PATCH -next] phy: Remove duplicated include in xusb.c Yang Li
  2023-07-21 13:55 ` Thierry Reding
@ 2023-07-24 10:56 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2023-07-24 10:56 UTC (permalink / raw)
  To: jckuo, Yang Li
  Cc: kishon, thierry.reding, jonathanh, linux-phy, linux-tegra,
	linux-kernel, Abaci Robot


On Wed, 19 Jul 2023 08:36:14 +0800, Yang Li wrote:
> ./drivers/phy/tegra/xusb.c: linux/platform_device.h is included more than once.
> 
> 

Applied, thanks!

[1/1] phy: Remove duplicated include in xusb.c
      commit: f5a8ecef3c6b840673d08342045c3014d674555f

Best regards,
-- 
~Vinod



-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-07-24 10:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-19  0:36 [PATCH -next] phy: Remove duplicated include in xusb.c Yang Li
2023-07-21 13:55 ` Thierry Reding
2023-07-24 10:56 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).