From: Adrien Thierry <athierry@redhat.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Shazad Hussain <quic_shazhuss@quicinc.com>,
Vinod Koul <vkoul@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org
Subject: Re: [PATCH 0/2] phy: qcom-qmp-usb: fix initialization of PCS_USB
Date: Thu, 24 Aug 2023 15:32:16 -0400 [thread overview]
Message-ID: <ZOewQCtdAv8LYhww@fedora> (raw)
In-Reply-To: <bd0c9cba-41e2-b449-f383-9970d00cb723@linaro.org>
Hi Bryan,
On Thu, Aug 24, 2023 at 10:15:32AM +0100, Bryan O'Donoghue wrote:
> On 23/08/2023 18:12, Adrien Thierry wrote:
> > This series attempts at making sure PCS_USB registers are properly
> > initialized. Please note I don't have access to the qmp phy datasheet and
> > only reasoned from the code, so I appreciate a double check to make sure
> > I'm not messing with the registers.
> >
> > Adrien Thierry (2):
> > phy: qcom-qmp-usb: initialize PCS_USB registers
> > phy: qcom-qmp-usb: split PCS_USB init table for sc8280xp and sa8775p
> >
> > drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 22 +++++++++++++++++-----
> > 1 file changed, 17 insertions(+), 5 deletions(-)
> >
>
> How is this series tested ? What are the before/after results/effects ?
>
I tested this series on the sa8775p. AFAICT there's no noticeable change
before/after the patch series: lsusb and dmesg output are the same. USB is
still working properly. I don't know what those PCS_USB registers do
exactly on the qmp PHY and I don't have access to docs, so it's hard for
me to tell the impact of them being initialized vs not.
> ---
> bod
Best,
Adrien
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2023-08-24 19:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 17:12 [PATCH 0/2] phy: qcom-qmp-usb: fix initialization of PCS_USB Adrien Thierry
2023-08-23 17:12 ` [PATCH 1/2] phy: qcom-qmp-usb: initialize PCS_USB registers Adrien Thierry
2023-08-24 20:58 ` Dmitry Baryshkov
2023-08-23 17:12 ` [PATCH 2/2] phy: qcom-qmp-usb: split PCS_USB init table for sc8280xp and sa8775p Adrien Thierry
2023-08-24 20:52 ` Dmitry Baryshkov
2023-08-24 9:15 ` [PATCH 0/2] phy: qcom-qmp-usb: fix initialization of PCS_USB Bryan O'Donoghue
2023-08-24 19:32 ` Adrien Thierry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOewQCtdAv8LYhww@fedora \
--to=athierry@redhat.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=quic_shazhuss@quicinc.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).