From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87D3EC4332F for ; Thu, 9 Nov 2023 23:11:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0FZji6fhT3uqncmLfcSLt65/qVIuzFSrCaB0hjjMciA=; b=eaeLNrwfTVUHco hXlAo7AqKyH3VoeUm44tF3yXN8yJ2s+uwEkUO4nIZUKf1U39GQFQcRK27AE4insiQfrB9AQoeaX5n ml2RlZxkcYx634UHsDcp2rMkvds1e9f5PQdV6ONfzCiVH0M4/31hJU+ocana8szE/9hsakTAMA5sd jmp0jZYDHV131/4Dz9GUke0hDzNEvChatE1Jv6yE/uqIlRky8Z/Olqvqq2reAUQy4N8EaHh0K53IR 9CUb/7Uqgm34N6X/GbFPUR4adT7eNdvNXrweOk9/tnrN4CYp7dTUsmOndt9UN1yE3PgNdA5zGTtd9 7xHja9bDSHM+MrhW8ZlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r1EBX-007PG6-0b; Thu, 09 Nov 2023 23:11:39 +0000 Received: from pidgin.makrotopia.org ([185.142.180.65]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r1EBT-007PF5-1g; Thu, 09 Nov 2023 23:11:36 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1r1EB5-0003nC-0D; Thu, 09 Nov 2023 23:11:11 +0000 Date: Thu, 9 Nov 2023 23:11:02 +0000 From: Daniel Golle To: Andrew Lunn Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chunfeng Yun , Vinod Koul , Kishon Vijay Abraham I , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , Heiner Kallweit , Russell King , Alexander Couzens , Philipp Zabel , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org Subject: Re: [RFC PATCH 1/8] dt-bindings: phy: mediatek,xfi-pextp: add new bindings Message-ID: References: <924c2c6316e6d51a17423eded3a2c5c5bbf349d2.1699565880.git.daniel@makrotopia.org> <797ea94b-9c26-43a2-85d7-633990ed8c57@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <797ea94b-9c26-43a2-85d7-633990ed8c57@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231109_151135_556004_630F320A X-CRM114-Status: GOOD ( 14.52 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi Andrew, On Thu, Nov 09, 2023 at 10:55:55PM +0100, Andrew Lunn wrote: > > + mediatek,usxgmii-performance-errata: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + USXGMII0 on MT7988 suffers from a performance problem in 10GBase-R > > + mode which needs a work-around in the driver. The work-around is > > + enabled using this flag. > > Is there more details about this? I'm just wondering if this should be > based on the compatible, rather than a bool property. The vendor sources where this is coming from are here: https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-feeds/+/a500d94cd47e279015ce22947e1ce396a7516598%5E%21/#F0 And I'm afraid this is as much detail as it gets. And yes, we could also base this on the compatible and just have two different ones for the two PEXTP instances found in MT7988. Let me know your conclusion in that regard. Cheers Daniel -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy