From: Vinod Koul <vkoul@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Stanley Chang <stanley_chang@realtek.com>,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 0/3] Revert "usb: phy: add usb phy notify port status API"
Date: Mon, 6 Nov 2023 16:54:45 +0530 [thread overview]
Message-ID: <ZUjM/VEliT5c8H4C@matsya> (raw)
In-Reply-To: <2023110623-pointing-stump-643d@gregkh>
On 06-11-23, 12:15, Greg Kroah-Hartman wrote:
> On Mon, Nov 06, 2023 at 12:06:51PM +0100, Johan Hovold wrote:
> > The recently added Realtek PHY drivers depend on the new port status
> > notification mechanism which was built on the deprecated USB PHY
> > implementation and devicetree binding.
> >
> > Specifically, using these PHYs would require describing the very same
> > PHY using both the generic "phy" property and the deprecated "usb-phy"
> > property which is clearly wrong.
> >
> > We should not be building new functionality on top of the legacy USB PHY
> > implementation even if it is currently stuck in some kind of
> > transitional limbo.
> >
> > Revert the new Realtek PHY drivers for now so that the port status
> > notification interface can be reverted and replaced before we dig
> > ourselves into an even deeper hole with this PHY mess.
> >
> > Note that there are no upstream users of these PHYs and the drivers were
> > only included in 6.6 so there should still be time to undo this.
>
> No users of these phy drivers yet? Why were they added?
Not sure why, they didnt go thru phy ss!
>
> > Preferably these should go in through Greg's tree for 6.7-rc1.
>
> I'll be glad to take this if I can get an ack for it.
Pls do drop this:
Acked-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-11-06 11:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 11:06 [PATCH 0/3] Revert "usb: phy: add usb phy notify port status API" Johan Hovold
2023-11-06 11:06 ` [PATCH 1/3] Revert "phy: realtek: usb: Add driver for the Realtek SoC USB 3.0 PHY" Johan Hovold
2023-11-06 11:06 ` [PATCH 2/3] Revert "phy: realtek: usb: Add driver for the Realtek SoC USB 2.0 PHY" Johan Hovold
2023-11-06 11:06 ` [PATCH 3/3] Revert "usb: phy: add usb phy notify port status API" Johan Hovold
2023-11-06 11:15 ` [PATCH 0/3] " Greg Kroah-Hartman
2023-11-06 11:24 ` Vinod Koul [this message]
2023-11-06 13:48 ` Greg Kroah-Hartman
[not found] ` <28e77cbc531248bf913ceedba6425cf6@realtek.com>
2023-11-07 7:02 ` Greg Kroah-Hartman
2023-11-06 11:25 ` Johan Hovold
2023-11-06 13:48 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZUjM/VEliT5c8H4C@matsya \
--to=vkoul@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan+linaro@kernel.org \
--cc=kishon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=stanley_chang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox