From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5AACC4829E for ; Thu, 15 Feb 2024 15:33:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P95pmZ/hZSBPckG6xPfpSsM2tqDuhEHWcRiRIAEnt1Q=; b=3prGAKYTeMz6Wt oGaKUp0afRkCTkvM8f0H3aV1FmiqLAihbLowVADXDmOfCpfQCYbuWjJQJSN4Am/xZFo4kAa661e3j QVdtUX7RSuHABJRDkPix9NYXDSg+OBME30ZZBjumYMPI2BKxUxfS6C9/PvptyMxV6lT6g6VQ/QzJT wkF+a6DTc48lUjURsoHbEbOoG63jXa+r5Itnpoii6pyj5flOETEQiJyZXrYUa7XagxxHi9rrHKRGu QAaGYqjwLJPxeAx89IZf0gDjEHB/eKwPOfgLNhLchk1rePihjOECMOQxlvrVRbrBGz/pegzllrq4h qM8XavTtckVeG4VhUCaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1radkA-0000000GlpV-1Vbp; Thu, 15 Feb 2024 15:33:46 +0000 Received: from mgamail.intel.com ([192.198.163.15]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1radk6-0000000Glo2-2tNT; Thu, 15 Feb 2024 15:33:44 +0000 X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="2230194" X-IronPort-AV: E=Sophos;i="6.06,162,1705392000"; d="scan'208";a="2230194" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2024 07:33:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="912181253" X-IronPort-AV: E=Sophos;i="6.06,162,1705392000"; d="scan'208";a="912181253" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2024 07:33:36 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1radjw-00000004pTJ-2xfL; Thu, 15 Feb 2024 17:33:32 +0200 Date: Thu, 15 Feb 2024 17:33:32 +0200 From: Andy Shevchenko To: Thomas Richard Cc: Linus Walleij , Bartosz Golaszewski , Tony Lindgren , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com Subject: Re: [PATCH v3 07/18] phy: ti: phy-j721e-wiz: use dev_err_probe() instead of dev_err() Message-ID: References: <20240102-j7200-pcie-s2r-v3-0-5c2e4a3fac1f@bootlin.com> <20240102-j7200-pcie-s2r-v3-7-5c2e4a3fac1f@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240102-j7200-pcie-s2r-v3-7-5c2e4a3fac1f@bootlin.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240215_073342_760583_244BF242 X-CRM114-Status: GOOD ( 13.19 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Thu, Feb 15, 2024 at 04:17:52PM +0100, Thomas Richard wrote: > Use dev_err_probe() instead of dev_err() in wiz_clock_init() to simplify > the code and standardize the error output. ... > ret = wiz_clock_register(wiz); > if (ret) > - dev_err(dev, "Failed to register wiz clocks\n"); > + dev_err_probe(dev, ret, "Failed to register wiz clocks\n"); > return ret; Maybe if (ret) return dev_err_probe(dev, ret, "Failed to register wiz clocks\n"); return 0; ? ... > if (!clk_node) { > - dev_err(dev, "Unable to get %s node\n", node_name); > ret = -EINVAL; > + dev_err_probe(dev, ret, "Unable to get %s node\n", node_name); > goto err; ret = dev_err_probe(..., -EINVAL, ...); > } -- With Best Regards, Andy Shevchenko -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy