From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4A58C4829E for ; Thu, 15 Feb 2024 15:45:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MvHu0XUqJqNLBuYu8+TzaCsXvaQO4gLQtpm7wGH9Ibo=; b=pspCOjbE1NyH1Z yrWkf62+Hy4JNlJTdn84FxxMFv85NhKweU2ehZXLMuLeNg9sUnDREFeOnU8u7cBfQlVZNv5HexPMb znzsyLSmR7Wr/IYo/NG449QSC1NrK5tT9N3O3+3a4IKsex3i61WD1DtrM0fmOPpSUrTLIu0wTQMzF RqF5T6DW9yTSkl21StPip+NbSVl5o33d/r/Lxd6mUhatssWGASKluab54JEmn1NaJcrycV11d7hiK 1MI4uSZUXGvhVgqMulUD692nRatzHgxDTGBTzeG56elIjvuiWFE07rq6Y4NACAcKOYzy2TE7x8O/I w4NC/TsPKo35iG9yzBIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1radvh-0000000Gomj-1uH0; Thu, 15 Feb 2024 15:45:41 +0000 Received: from mgamail.intel.com ([192.198.163.15]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1radve-0000000Gokx-3XG5; Thu, 15 Feb 2024 15:45:40 +0000 X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="2231623" X-IronPort-AV: E=Sophos;i="6.06,162,1705392000"; d="scan'208";a="2231623" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2024 07:45:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10984"; a="912182511" X-IronPort-AV: E=Sophos;i="6.06,162,1705392000"; d="scan'208";a="912182511" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2024 07:45:32 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1radvU-00000004pco-36lU; Thu, 15 Feb 2024 17:45:28 +0200 Date: Thu, 15 Feb 2024 17:45:28 +0200 From: Andy Shevchenko To: Thomas Richard Cc: Linus Walleij , Bartosz Golaszewski , Tony Lindgren , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com Subject: Re: [PATCH v3 13/18] phy: cadence-torrent: remove noop_ops phy operations Message-ID: References: <20240102-j7200-pcie-s2r-v3-0-5c2e4a3fac1f@bootlin.com> <20240102-j7200-pcie-s2r-v3-13-5c2e4a3fac1f@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240102-j7200-pcie-s2r-v3-13-5c2e4a3fac1f@bootlin.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240215_074538_908192_2C4CDED0 X-CRM114-Status: GOOD ( 14.73 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Thu, Feb 15, 2024 at 04:17:58PM +0100, Thomas Richard wrote: > Even if a PHY is already configured, the PHY operations are needed during > resume stage, as the PHY is in reset state. > The noop_ops PHY operations is removed to always have PHY operations. > The already_configured flag is checked at the begening of init, configure > and poweron operations to keep the already_configured behaviour. ... > + if (cdns_phy->already_configured) { > + /* Give 5ms to 10ms delay for the PIPE clock to be stable */ > + usleep_range(5000, 10000); fsleep() ? (Yes, I see this is the original code, perhaps later in a separate change) > + return 0; > + } -- With Best Regards, Andy Shevchenko -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy