From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3AF1C48260 for ; Fri, 16 Feb 2024 15:08:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WTr+J0uLZUE2ZK/tjb7eacPzgCi/48vd2hvSDpxfq7E=; b=dLSsMNyOQAT9s1 bNmGUdycWF78M4ZZbi+S3ARI7zbQRdRpXRP1jZiaCP9JVuMgc7yvRvNzCOE8ZWzMXwBuSjxzxwdbZ CuRnbShxy7UtrB2J4Ejw0NTYXcrLUWJeBLc+1lak408eqfUhCFO5pOi0j9ltB0gB+ve9tdt+6YKcp euqnwGbjRUfw7daW1905+4BDWtVxlUwSOzhiQyip/i9FncOA9FchEzwWaiMENQGBFkhhbp3hwuMsr +c2NM4wloHMWXcyEwfziDIAxZHKfievuC8eyqSNkWrvVfKyEFIW8WGuSgygQtlBz9oLTuUiu+cpN9 4aQJ66TOsklAy2d+vkkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1razpa-00000002hdd-2Gjq; Fri, 16 Feb 2024 15:08:50 +0000 Received: from mgamail.intel.com ([198.175.65.18]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1razpX-00000002hcY-2ovW; Fri, 16 Feb 2024 15:08:48 +0000 X-IronPort-AV: E=McAfee;i="6600,9927,10985"; a="2338374" X-IronPort-AV: E=Sophos;i="6.06,164,1705392000"; d="scan'208";a="2338374" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2024 07:08:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10985"; a="912374432" X-IronPort-AV: E=Sophos;i="6.06,164,1705392000"; d="scan'208";a="912374432" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2024 07:08:40 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1razpN-000000054tL-1WLs; Fri, 16 Feb 2024 17:08:37 +0200 Date: Fri, 16 Feb 2024 17:08:37 +0200 From: Andy Shevchenko To: Thomas Richard Cc: Linus Walleij , Bartosz Golaszewski , Tony Lindgren , Haojian Zhuang , Vignesh R , Aaro Koskinen , Janusz Krzysztofik , Andi Shyti , Peter Rosin , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org, linux-pci@vger.kernel.org, gregory.clement@bootlin.com, theo.lebrun@bootlin.com, thomas.petazzoni@bootlin.com, u-kumar1@ti.com Subject: Re: [PATCH v3 02/18] pinctrl: pinctrl-single: remove dead code in suspend() and resume() callbacks Message-ID: References: <20240102-j7200-pcie-s2r-v3-0-5c2e4a3fac1f@bootlin.com> <20240102-j7200-pcie-s2r-v3-2-5c2e4a3fac1f@bootlin.com> <78add459-a96a-46c6-83ff-e2657d4d3db4@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <78add459-a96a-46c6-83ff-e2657d4d3db4@bootlin.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240216_070847_765796_452A0284 X-CRM114-Status: GOOD ( 19.04 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Fri, Feb 16, 2024 at 08:59:47AM +0100, Thomas Richard wrote: > On 2/15/24 16:27, Andy Shevchenko wrote: > > On Thu, Feb 15, 2024 at 04:17:47PM +0100, Thomas Richard wrote: > >> No need to check the pointer returned by platform_get_drvdata(), as > >> platform_set_drvdata() is called during the probe. > > > > This patch should go _after_ the next one, otherwise the commit message doesn't > > tell full story and the code change bring a potential regression. > > Hello Andy, > > I'm ok to move this patch after the next one. > But for my understanding, could you explain me why changing the order is > important in this case ? Old PM calls obviously can be called in different circumstances and these checks are important. Just squash these two patches to avoid additional churn and we are done. -- With Best Regards, Andy Shevchenko -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy