From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5B8DD6DDD2 for ; Fri, 15 Nov 2024 05:16:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=60kBxdf6ngraVxRB99MYbej5cWpYT7QzQYBq7ft9i8k=; b=4oGKpiGPLlZ/Xo HUUiaKWa6UiKkHZhuu8YFk+6c8tMH8zIXiRv8HG7JGqWK7MxoOncoyEqn1rzFkYyy9C8cB2OKkyc8 1rtF6H9h4xVOiiYcrHjU1QvjSxQd+gGM7E1Jz84Gn475thh9sY2ki8B2HEDHtVJfgUEjMiAu2zrzz w3Nqpl96k2P1qV+KeKAAfbMgFTmXdM3III4IRuXGCc7h1N5KbldGb198mpamJfB/cV+12HjO8GuKP 5+qtwhcs5it/dUPLkDmZ67oKZTxqkI1MQswqXTA/ThRjnGOuXyPsAuXNeiBS9aWlxgI19sjLmGYFO wsUHt96dd9DevLKVPKOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tBoh3-00000001eO7-1WT7; Fri, 15 Nov 2024 05:16:29 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tBogz-00000001eNY-3gW2 for linux-phy@lists.infradead.org; Fri, 15 Nov 2024 05:16:27 +0000 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AEHIN0k000320; Fri, 15 Nov 2024 05:16:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=XeOXBRvKYlKEFsGjau4VWSu7 nM6D4GRhts+u2M09/vo=; b=i7IHY/kFkhkkRemfOjO+aZbBQJ50FOWGAee5eXFZ jCqPPOwKFp2sEUhFA6yMqFHH7kvNyBlPQ8m499mj6M17NpfBB2nP9+dCmEIYc6c5 lQ9bxJBymaGXYypE0gSqtjXEYuAnShfcGentchhW6lrwJLZkAQyBtt2qGZ+o/TEP Km0d6pk48JvtWTMEXYsTtbOsma2F9OP9AoRrxt9YqVELwJF8s3rzHw6PRjUmto0s gSm0j4WDlpMievbuvbjAUgZSVFhnVMIQGdEZ+Tz1c+LOZx/S7FvMc4bB7ItIZX8/ vI7aKRpOIrBtSTuqjZTrmhEcptltjKqGccbbsz8ONeRpyQ== Received: from nasanppmta02.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42wjqaj5r9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Nov 2024 05:16:20 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4AF5GJsh026368 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Nov 2024 05:16:19 GMT Received: from hu-varada-blr.qualcomm.com (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 14 Nov 2024 21:16:13 -0800 Date: Fri, 15 Nov 2024 10:46:10 +0530 From: Varadarajan Narayanan To: Dmitry Baryshkov CC: , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 6/6] arm64: dts: qcom: Add USB controller and phy nodes for IPQ5424 Message-ID: References: <20241114074722.4085319-1-quic_varada@quicinc.com> <20241114074722.4085319-7-quic_varada@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: d_wIorl82C0yLf1h6fCzcXveyRezvnJK X-Proofpoint-ORIG-GUID: d_wIorl82C0yLf1h6fCzcXveyRezvnJK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 adultscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 mlxscore=0 mlxlogscore=679 bulkscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411150042 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241114_211626_066712_2127F9F6 X-CRM114-Status: GOOD ( 20.14 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Thu, Nov 14, 2024 at 03:28:36PM +0200, Dmitry Baryshkov wrote: > On Thu, 14 Nov 2024 at 09:48, Varadarajan Narayanan > wrote: > > > > The IPQ5424 SoC has both USB2.0 and USB3.0 controllers. The USB3.0 > > can connect to either of USB2.0 or USB3.0 phy and operate in the > > respective mode. > > > > Signed-off-by: Varadarajan Narayanan > > --- > > v3: Regulator node names, labels and 'regulator-name' changed per review suggestions > > Stray newline removed > > > > v2: Add dm/dp_hs_phy_irq to usb3@8a00000 node > > Add u1/u2-entry quirks to usb@8a00000 node > > --- > > arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts | 66 ++++++++ > > arch/arm64/boot/dts/qcom/ipq5424.dtsi | 159 ++++++++++++++++++++ > > 2 files changed, 225 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts > > index d4d31026a026..859e15befb3f 100644 > > --- a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts > > +++ b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts > > @@ -16,12 +16,70 @@ / { > > aliases { > > serial0 = &uart1; > > }; > > + > > + vreg_misc_3p3: regulator-3300000 { > > Technically these names are correct. However they don't match the > approach that Qualcomm DT files have been using up to now. > You can compare your data with the output of `git grep :.regulator- > arch/arm64/boot/dts/qcom/` Dmitry, This name was suggested by Rob Herring [1]. Shall I rename them as follows regulator-usb-3p3 regulator-usb-1p8 regulator-usb-0p925 Thanks Varada 1 - https://lore.kernel.org/linux-arm-msm/20241113181138.GA1011553-robh@kernel.org/ > > + compatible = "regulator-fixed"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-boot-on; > > + regulator-always-on; > > + regulator-name = "usb_hs_vdda_3p3"; > > + }; > > + > > + vreg_misc_1p8: regulator-1800000 { > > + compatible = "regulator-fixed"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + regulator-boot-on; > > + regulator-always-on; > > + regulator-name = "vdda_1p8_usb"; > > + }; > > + > > + vreg_misc_0p925: regulator-0925000 { > > + compatible = "regulator-fixed"; > > + regulator-min-microvolt = <925000>; > > + regulator-max-microvolt = <925000>; > > + regulator-boot-on; > > + regulator-always-on; > > + regulator-name = "vdd_core_usb"; > > + }; > > +}; [. . .] -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy