From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4046C77B6E for ; Wed, 12 Apr 2023 08:32:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GEqZf4jInyJANuJSls7thBD4LOzZr15BiZ168QPzjpQ=; b=dZM9bahYoYPvKE /0PJByPwC4DKHIDsRbD7zPUWxeWNs2XRJ0/SelMTv47YJx0FXkIlJqz6XzLmisE2X1sJSo/GuhRyb /j1lYFMO2x1I+IEOWFOBuMMdBbSXrbUYrmulg3MqozSLychOoxeDrsE7yQrdM/uSkXSWzlxJ+mBFr uRiI763Sqfoky2dQo2vSLQOL8yS9fDpPzNVowOQ7Y4/EWX+f3CquVgWsJ8M/yI88Livu842wRMNsG 0DZCDsdnRLKmzSwR9acFiHeaJFmjBC84HZMIGdY/uSAnMz/4E7hdt7d50/D3MUll1UKmrOadRxVvd rLqk9Y/0S2UXqTq4zOdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmVuP-002Ggs-1g; Wed, 12 Apr 2023 08:32:53 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmVuN-002GfP-06 for linux-phy@lists.infradead.org; Wed, 12 Apr 2023 08:32:52 +0000 Received: by mail-ej1-x631.google.com with SMTP id qa44so26497873ejc.4 for ; Wed, 12 Apr 2023 01:32:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681288366; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GXiGiAF3mJm/6hgfCTKaagk5zrHngr0ItbqxTgvmii8=; b=C/51NnDG3cTMi1zIIBdXnNwtu+5/H+Te65ByqDIe1Dqfva8pHREGnFaHn/9lMjxBEu sBZQiMhtPvgDpe2ZtVfYQRmIus4pbBZMnWTOl47ORd9oEJ8XGCAAb4XJ6I1AfdxS1ves 3+rkSCLvC3SAPC5fF4nON0+qETWahP3+Apns3D5IvEmCT5VlggcPsZ+nFCYwpkOnqRhd cpvGtxqmHFHZV+eN4oyLUCCpVUKHXnHcKCbBe5zVImZzc10PVVSWz8bghARPUZX6iCFc qCZwb2Igfu73AYiIuAe3MixuQgC8IE4Dir6LD/sBpy0RUjdPoO581HJvkuTLTT3Wsm/X ehoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681288366; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GXiGiAF3mJm/6hgfCTKaagk5zrHngr0ItbqxTgvmii8=; b=Ek+I+bGLaciOJlyO3jLIPyNZ9u40H0VhnqXGjPjucSuwrNeQQGq0bILAqN50lWIdw5 NeaZmJBzGMIoYVjg6jASDo4Xw3maPaalmnvEFNXm0P7pEDuN4ox6ZuGWqo0H1xA1iWva W6AAXGoNipJX1V7frON1owfNZ4WUrmZUTCw/5kdLuTn365tvj1glhJiRJzUCVkpYhJEj dzfM4ME9ePnQ6qElRkaMX/+WLYvpEteWQvbdGBk/kEynmG4fDivJUX/7ohT2yCXUFGm4 y4WwCWoU278xLFaecwj6RdJZ5Vc15AM4GLmfUJACnd4atRhRDBJtOmoxK6lXM2j89say 3PLA== X-Gm-Message-State: AAQBX9cc6oS4NUQiQaGHTqz4NVrH+XennPoQePfgAe1g77wp/IPSnB8S 2dqL29Qt1J3BCKL19668DweOsw== X-Google-Smtp-Source: AKy350aonQuINRVoZBdNIRp5k/+iTxbe085iISMQDF1/o+RSzs78iZn4aQ4I9E5uICTAMMyjmj6qNw== X-Received: by 2002:a17:906:c78a:b0:947:eafc:a738 with SMTP id cw10-20020a170906c78a00b00947eafca738mr5025769ejb.60.1681288366167; Wed, 12 Apr 2023 01:32:46 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:8fa0:9989:3f72:b14f? ([2a02:810d:15c0:828:8fa0:9989:3f72:b14f]) by smtp.gmail.com with ESMTPSA id rv12-20020a1709068d0c00b0094e5fd589f9sm427786ejc.19.2023.04.12.01.32.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 01:32:45 -0700 (PDT) Message-ID: Date: Wed, 12 Apr 2023 10:32:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v4 5/7] dt-bindings: usb: Add StarFive JH7110 USB Bindings YAML schemas Content-Language: en-US To: Minda Chen , Emil Renner Berthing , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Pawel Laszczak , Greg Kroah-Hartman , Peter Chen , Roger Quadros , Philipp Zabel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org, linux-riscv@lists.infradead.org, Paul Walmsley , Palmer Dabbelt , Albert Ou , Mason Huo References: <20230406015216.27034-1-minda.chen@starfivetech.com> <20230406015216.27034-6-minda.chen@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20230406015216.27034-6-minda.chen@starfivetech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_013251_079734_9307C501 X-CRM114-Status: GOOD ( 18.55 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 06/04/2023 03:52, Minda Chen wrote: > StarFive JH7110 platforms USB have a wrapper module around > the Cadence USBSS-DRD controller. Add binding information doc > for that. That's one of the most redundant subjects I saw. You basically used four words for one meaning. These are not exactly synonyms, but they all are either imprecise or meaning the same. Subject: drop second/last, redundant "Bindings YAML schemas". The "dt-bindings" prefix is already stating that these are bindings. > > Signed-off-by: Minda Chen > Reviewed-by: Peter Chen > --- > .../bindings/usb/starfive,jh7110-usb.yaml | 136 ++++++++++++++++++ > 1 file changed, 136 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/starfive,jh7110-usb.yaml > > diff --git a/Documentation/devicetree/bindings/usb/starfive,jh7110-usb.yaml b/Documentation/devicetree/bindings/usb/starfive,jh7110-usb.yaml > new file mode 100644 > index 000000000000..c8b30b583854 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/starfive,jh7110-usb.yaml > @@ -0,0 +1,136 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/starfive,jh7110-usb.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive JH7110 wrapper module for the Cadence USBSS-DRD controller What do you wrap here? Are you sure this is a wrapper? I think this is just USB controller? > + > +maintainers: > + - Minda Chen > + > +properties: > + compatible: > + const: starfive,jh7110-usb > + > + reg: > + items: > + - description: OTG controller registers > + - description: XHCI Host controller registers > + - description: DEVICE controller registers > + > + reg-names: > + items: > + - const: otg > + - const: xhci > + - const: dev > + > + interrupts: > + items: > + - description: XHCI host controller interrupt > + - description: Device controller interrupt > + - description: OTG/DRD controller interrupt > + > + interrupt-names: > + items: > + - const: host > + - const: peripheral > + - const: otg > + > + clocks: > + items: > + - description: lpm clock > + - description: stb clock > + - description: apb clock > + - description: axi clock > + - description: utmi apb clock > + > + clock-names: > + items: > + - const: lpm > + - const: stb > + - const: apb > + - const: axi > + - const: utmi_apb > + > + resets: > + items: > + - description: PWRUP reset > + - description: APB clock reset > + - description: AXI clock reset > + - description: UTMI_APB clock reset > + > + reset-names: > + items: > + - const: pwrup > + - const: apb > + - const: axi > + - const: utmi > + > + starfive,stg-syscon: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + items: > + items: Same problem as for other patches. > + - description: phandle to System Register Controller stg_syscon node. > + - description: register offset of STG_SYSCONSAIF__SYSCFG register for USB. > + description: > + The phandle to System Register Controller syscon node and the offset > + of STG_SYSCONSAIF__SYSCFG register for USB. > + Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy