From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Varadarajan Narayanan <quic_varada@quicinc.com>,
bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com,
manivannan.sadhasivam@linaro.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
kishon@kernel.org, andersson@kernel.org, konradybcio@kernel.org,
p.zabel@pengutronix.de, quic_nsekar@quicinc.com,
dmitry.baryshkov@linaro.org, quic_srichara@quicinc.com,
linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org
Cc: Praveenkumar I <quic_ipkumar@quicinc.com>
Subject: Re: [PATCH v3 5/5] arm64: dts: qcom: ipq5332-rdp441: Enable PCIe phys and controllers
Date: Thu, 19 Dec 2024 22:34:46 +0100 [thread overview]
Message-ID: <a33c3da8-0f38-4194-9eb5-249cf6848928@oss.qualcomm.com> (raw)
In-Reply-To: <20241217100359.4017214-6-quic_varada@quicinc.com>
On 17.12.2024 11:03 AM, Varadarajan Narayanan wrote:
> From: Praveenkumar I <quic_ipkumar@quicinc.com>
>
> Enable the PCIe controller and PHY nodes for RDP 441.
>
> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> ---
> v3: Reorder nodes alphabetically
> Fix commit subject
> ---
> arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts | 74 +++++++++++++++++++++
> 1 file changed, 74 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts b/arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts
> index 846413817e9a..2be23827b481 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp441.dts
> @@ -32,6 +32,32 @@ &sdhc {
> status = "okay";
> };
>
> +&pcie0_phy {
> + status = "okay";
> +};
> +
> +&pcie0 {
Node names with suffixes sort below node names without suffixes
Python's PartialEq for strings works well for determining this
>>> 'pcie0_phy' < 'pcie0'
False
>>> 'a' < 'b'
True
> + pinctrl-names = "default";
> + pinctrl-0 = <&pcie0_default>;
Please follow this order:
property-n
property-names
> +
> + perst-gpios = <&tlmm 38 GPIO_ACTIVE_LOW>;
> + wake-gpios = <&tlmm 39 GPIO_ACTIVE_LOW>;
> + status = "okay";
And keep a newline before status
Konrad
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2024-12-19 21:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 10:03 [PATCH v3 0/5] Add PCIe support for Qualcomm IPQ5332 Varadarajan Narayanan
2024-12-17 10:03 ` [PATCH v3 1/5] dt-bindings: phy: qcom,uniphy-pcie: Document PCIe uniphy Varadarajan Narayanan
2024-12-18 10:28 ` Krzysztof Kozlowski
2024-12-23 7:49 ` Varadarajan Narayanan
2024-12-17 10:03 ` [PATCH v3 2/5] phy: qcom: Introduce PCIe UNIPHY 28LP driver Varadarajan Narayanan
2024-12-24 14:46 ` Vinod Koul
2024-12-17 10:03 ` [PATCH v3 3/5] dt-bindings: PCI: qcom: Reuse 'pcie-sdx55' reg bindings for ipq9574 Varadarajan Narayanan
2024-12-18 10:29 ` Krzysztof Kozlowski
2024-12-17 10:03 ` [PATCH v3 4/5] arm64: dts: qcom: ipq5332: Add PCIe related nodes Varadarajan Narayanan
2024-12-19 21:32 ` Konrad Dybcio
2024-12-17 10:03 ` [PATCH v3 5/5] arm64: dts: qcom: ipq5332-rdp441: Enable PCIe phys and controllers Varadarajan Narayanan
2024-12-19 21:34 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a33c3da8-0f38-4194-9eb5-249cf6848928@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=kishon@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_ipkumar@quicinc.com \
--cc=quic_nsekar@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox