From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pritam Manohar Sutar <pritam.sutar@samsung.com>,
'Krzysztof Kozlowski' <krzysztof.kozlowski@linaro.org>
Cc: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, alim.akhtar@samsung.com,
andre.draszik@linaro.org, peter.griffin@linaro.org,
neil.armstrong@linaro.org, kauschluss@disroot.org,
ivo.ivanov.ivanov1@gmail.com, m.szyprowski@samsung.com,
s.nawrocki@samsung.com, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, rosa.pila@samsung.com,
dev.tailor@samsung.com, faraz.ata@samsung.com,
muhammed.ali@samsung.com, selvarasu.g@samsung.com
Subject: Re: [PATCH v4 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible
Date: Thu, 17 Jul 2025 13:28:58 +0200 [thread overview]
Message-ID: <a43cfe4f-8ff9-4dbd-b7f4-07ccc3d8e01b@kernel.org> (raw)
In-Reply-To: <000c01dbf70b$ccdbf630$6693e290$@samsung.com>
On 17/07/2025 13:13, Pritam Manohar Sutar wrote:
>>
>>
>> Nothing is explained in changelog/cover letter. You claim you only added Rb tag.
>> This is an entirely silent change while keeping the review.
>
> Will add more explanations in cover letter/changelog why this block is added.
>
>> Combined with not even following DTS style!
>
> Ok got it. Will change supplies name as below
> avdd075_usb => avdd075-usb
> avdd18_usb20 => avdd18-usb20
> avdd33_usb20 => avdd33-usb20
>
> Confirm the above change that is meant in terms of DTS style.
Yes. I have doubts that actual supplies have suffix usb20. Are there
more than one avdd18 for this block?
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2025-07-17 12:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250701115952epcas5p27badecc600886088875ead6297807228@epcas5p2.samsung.com>
2025-07-01 12:07 ` [PATCH v4 0/6] initial usbdrd phy support for Exynosautov920 soc Pritam Manohar Sutar
[not found] ` <CGME20250701115955epcas5p320cfe73ca33522cd2f9f7970cfde1c63@epcas5p3.samsung.com>
2025-07-01 12:07 ` [PATCH v4 1/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 HS phy compatible Pritam Manohar Sutar
2025-07-06 9:40 ` Krzysztof Kozlowski
2025-07-09 8:46 ` Pritam Manohar Sutar
2025-07-12 8:13 ` Krzysztof Kozlowski
2025-07-17 11:13 ` Pritam Manohar Sutar
2025-07-17 11:28 ` Krzysztof Kozlowski [this message]
2025-07-22 4:34 ` Pritam Manohar Sutar
2025-07-22 6:07 ` Krzysztof Kozlowski
2025-07-23 5:11 ` Pritam Manohar Sutar
2025-07-23 8:42 ` Krzysztof Kozlowski
2025-07-23 12:45 ` Alim Akhtar
2025-07-24 9:54 ` Pritam Manohar Sutar
[not found] ` <CGME20250701115959epcas5p40f28954777a620b018251301eea13873@epcas5p4.samsung.com>
2025-07-01 12:07 ` [PATCH v4 2/6] phy: exynos5-usbdrd: support HS phy for ExynosAutov920 Pritam Manohar Sutar
2025-07-09 10:11 ` Pritam Manohar Sutar
2025-07-12 8:16 ` Krzysztof Kozlowski
2025-07-17 11:18 ` Pritam Manohar Sutar
[not found] ` <CGME20250701120002epcas5p2c4d728d599a819057bcc40b724881276@epcas5p2.samsung.com>
2025-07-01 12:07 ` [PATCH v4 3/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo HS phy Pritam Manohar Sutar
2025-07-06 9:42 ` Krzysztof Kozlowski
2025-07-09 8:51 ` Pritam Manohar Sutar
[not found] ` <CGME20250701120005epcas5p24a8cfb5037524127416756fb723ccae7@epcas5p2.samsung.com>
2025-07-01 12:07 ` [PATCH v4 4/6] phy: exynos5-usbdrd: support HS combo phy for ExynosAutov920 Pritam Manohar Sutar
[not found] ` <CGME20250701120009epcas5p46bc2870446c499f9c0008c1d396650bb@epcas5p4.samsung.com>
2025-07-01 12:07 ` [PATCH v4 5/6] dt-bindings: phy: samsung,usb3-drd-phy: add ExynosAutov920 combo SS phy Pritam Manohar Sutar
2025-07-06 9:44 ` Krzysztof Kozlowski
2025-07-09 8:53 ` Pritam Manohar Sutar
[not found] ` <CGME20250701120012epcas5p4def7f4d718241407b598ad961d32c1f8@epcas5p4.samsung.com>
2025-07-01 12:07 ` [PATCH v4 6/6] phy: exynos5-usbdrd: support SS combo phy for ExynosAutov920 Pritam Manohar Sutar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a43cfe4f-8ff9-4dbd-b7f4-07ccc3d8e01b@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=dev.tailor@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=faraz.ata@samsung.com \
--cc=ivo.ivanov.ivanov1@gmail.com \
--cc=kauschluss@disroot.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=muhammed.ali@samsung.com \
--cc=neil.armstrong@linaro.org \
--cc=peter.griffin@linaro.org \
--cc=pritam.sutar@samsung.com \
--cc=robh@kernel.org \
--cc=rosa.pila@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=selvarasu.g@samsung.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).