From: Geraldo Nascimento <geraldogabriel@gmail.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Rick wertenbroek" <rick.wertenbroek@gmail.com>,
linux-phy@lists.infradead.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v6 0/4] PCI: rockchip: Improve driver quality
Date: Sat, 21 Jun 2025 08:33:02 -0300 [thread overview]
Message-ID: <aFaYbqRRV2l7nPcr@geday> (raw)
In-Reply-To: <4760493.mogB4TqSGs@phil>
On Sat, Jun 21, 2025 at 09:39:08AM +0200, Heiko Stuebner wrote:
> Hi Geraldo,
>
> Am Samstag, 21. Juni 2025, 03:47:51 Mitteleuropäische Sommerzeit schrieb Geraldo Nascimento:
> > During a 30-day debugging-run fighting quirky PCIe devices on RK3399
> > some quality improvements began to take form and this is my attempt
> > at upstreaming it. It will ensure maximum chance of retraining to Gen2
> > 5.0GT/s, on all four lanes and fix async strobe TEST_WRITE disablement.
>
> just a driver by comment, you might want to drop the RFC element from
> the patch subjects.
>
> It does look like things take form nicely and how people read those
> RFC marks varies wildly. Some may even read it as "this is unfinished"
> or something and spent review time on other things.
>
> So if you're mostly happy with your changes, just drop the RFC part :-)
>
Hi Heiko,
thanks for heads-up, we really don't want people to ignore patches so
I'll drop RFC tag for next iteration. The cover letter needs some love
too.
Thanks,
Geraldo Nascimento
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
prev parent reply other threads:[~2025-06-21 11:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-21 1:47 [RFC PATCH v6 0/4] PCI: rockchip: Improve driver quality Geraldo Nascimento
2025-06-21 1:48 ` [RFC PATCH v6 1/4] PCI: rockchip: Use standard PCIe defines Geraldo Nascimento
2025-06-21 1:48 ` [RFC PATCH v6 2/4] PCI: rockchip: Set Target Link Speed before retraining Geraldo Nascimento
2025-06-21 1:48 ` [RFC PATCH v6 3/4] phy: rockchip-pcie: Enable all four lanes if required Geraldo Nascimento
2025-06-21 1:49 ` [RFC PATCH v6 4/4] phy: rockchip-pcie: Properly disable TEST_WRITE strobe signal Geraldo Nascimento
2025-06-21 7:39 ` [RFC PATCH v6 0/4] PCI: rockchip: Improve driver quality Heiko Stuebner
2025-06-21 11:33 ` Geraldo Nascimento [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFaYbqRRV2l7nPcr@geday \
--to=geraldogabriel@gmail.com \
--cc=bhelgaas@google.com \
--cc=heiko@sntech.de \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=rick.wertenbroek@gmail.com \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox